There was a single instance of this issue which was reasonably simple to solve. The code that triggered the issue was not wrong, but calling the grandparent constructor directly is not the cleanest code so it seems right to fix it. Switch revision initialization into an overridable function to remove the need to even have a constructor in the class. Change-Id: Ic2af0d93e8d55e93061e3f4b5c7a4122509543f0
46 lines
1.3 KiB
PHP
46 lines
1.3 KiB
PHP
<?php
|
|
/**
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @file
|
|
* @ingroup RevisionDelete
|
|
*/
|
|
|
|
/**
|
|
* Item class for a archive table row by ar_rev_id -- actually
|
|
* used via RevDelRevisionList.
|
|
*/
|
|
class RevDelArchivedRevisionItem extends RevDelArchiveItem {
|
|
public function getIdField() {
|
|
return 'ar_rev_id';
|
|
}
|
|
|
|
public function getId() {
|
|
return $this->revision->getId();
|
|
}
|
|
|
|
public function setBits( $bits ) {
|
|
$dbw = wfGetDB( DB_MASTER );
|
|
$dbw->update( 'archive',
|
|
[ 'ar_deleted' => $bits ],
|
|
[ 'ar_rev_id' => $this->row->ar_rev_id,
|
|
'ar_deleted' => $this->getBits()
|
|
],
|
|
__METHOD__ );
|
|
|
|
return (bool)$dbw->affectedRows();
|
|
}
|
|
}
|