82b19bd96a
MediaWiki::emitBufferedStatsdData() is never called for the PerDbName factory, so stats were being dropped. Instead of having two factories, turn the PerDbName one into a proxy/wrapper around the main factory that just adds a prefix in front of all of the keys. Bug: T202144 Change-Id: I31e376446abb58e41353b4ca3814120d2e914104
58 lines
1.7 KiB
PHP
58 lines
1.7 KiB
PHP
<?php
|
|
|
|
use Liuggio\StatsdClient\Factory\StatsdDataFactoryInterface;
|
|
|
|
/**
|
|
* @covers PrefixingStatsdDataFactoryProxy
|
|
*/
|
|
class PrefixingStatsdDataFactoryProxyTest extends PHPUnit\Framework\TestCase {
|
|
|
|
use PHPUnit4And6Compat;
|
|
|
|
public function provideMethodNames() {
|
|
return [
|
|
[ 'timing' ],
|
|
[ 'gauge' ],
|
|
[ 'set' ],
|
|
[ 'increment' ],
|
|
[ 'decrement' ],
|
|
[ 'updateCount' ],
|
|
[ 'produceStatsdData' ],
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @dataProvider provideMethodNames
|
|
*/
|
|
public function testPrefixingAndPassthrough( $method ) {
|
|
/** @var StatsdDataFactoryInterface|PHPUnit_Framework_MockObject_MockObject $innerFactory */
|
|
$innerFactory = $this->getMock(
|
|
\Liuggio\StatsdClient\Factory\StatsdDataFactoryInterface::class
|
|
);
|
|
$innerFactory->expects( $this->once() )
|
|
->method( $method )
|
|
->with( 'testprefix.' . 'metricname' );
|
|
|
|
$proxy = new PrefixingStatsdDataFactoryProxy( $innerFactory, 'testprefix' );
|
|
// 1,2,3,4 simply makes sure we provide enough parameters, without caring what they are
|
|
$proxy->$method( 'metricname', 1, 2, 3, 4 );
|
|
}
|
|
|
|
/**
|
|
* @dataProvider provideMethodNames
|
|
*/
|
|
public function testPrefixIsTrimmed( $method ) {
|
|
/** @var StatsdDataFactoryInterface|PHPUnit_Framework_MockObject_MockObject $innerFactory */
|
|
$innerFactory = $this->getMock(
|
|
\Liuggio\StatsdClient\Factory\StatsdDataFactoryInterface::class
|
|
);
|
|
$innerFactory->expects( $this->once() )
|
|
->method( $method )
|
|
->with( 'testprefix.' . 'metricname' );
|
|
|
|
$proxy = new PrefixingStatsdDataFactoryProxy( $innerFactory, 'testprefix...' );
|
|
// 1,2,3,4 simply makes sure we provide enough parameters, without caring what they are
|
|
$proxy->$method( 'metricname', 1, 2, 3, 4 );
|
|
}
|
|
|
|
}
|