1959b3eb5a
Instead test that LBFactory::getLBFactoryClass() does the right thing. In LBFactory::getLBFactoryClass(), the method now requires a configuration array as a parameter, and returns the class name as a string. LBFactory::singleton() now passes in $wgLBFactoryConf into getLBFactoryClass(), while tests can use test configuration. Only use of LBFactory::getLBFactoryClass() in core is in LBFactory::singleton(). No extension in gerrit uses getLBFactoryClass() and I can find no use of it when searching places like Github and Google, so it should be safe to make such change in LBFactory. Bug: 59105 Change-Id: I71ae7df16bc5c214b9389125140bca5ce68d274c
61 lines
1.9 KiB
PHP
61 lines
1.9 KiB
PHP
<?php
|
|
/**
|
|
* Holds tests for LBFactory abstract MediaWiki class.
|
|
*
|
|
* @section LICENSE
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @group Database
|
|
* @file
|
|
* @author Antoine Musso
|
|
* @copyright © 2013 Antoine Musso
|
|
* @copyright © 2013 Wikimedia Foundation Inc.
|
|
*/
|
|
class LBFactoryTest extends MediaWikiTestCase {
|
|
|
|
/**
|
|
* @dataProvider getLBFactoryClassProvider
|
|
*/
|
|
public function testGetLBFactoryClass( $expected, $deprecated ) {
|
|
$mockDB = $this->getMockBuilder( 'DatabaseMysql' )
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$config = array(
|
|
'class' => $deprecated,
|
|
'connection' => $mockDB,
|
|
# Various other parameters required:
|
|
'sectionsByDB' => array(),
|
|
'sectionLoads' => array(),
|
|
'serverTemplate' => array(),
|
|
);
|
|
|
|
$this->hideDeprecated( '$wgLBFactoryConf must be updated. See RELEASE-NOTES for details' );
|
|
$result = LBFactory::getLBFactoryClass( $config );
|
|
|
|
$this->assertEquals( $expected, $result );
|
|
}
|
|
|
|
public function getLBFactoryClassProvider() {
|
|
return array(
|
|
# Format: new class, old class
|
|
array( 'LBFactorySimple', 'LBFactory_Simple' ),
|
|
array( 'LBFactorySingle', 'LBFactory_Single' ),
|
|
array( 'LBFactoryMulti', 'LBFactory_Multi' ),
|
|
array( 'LBFactoryFake', 'LBFactory_Fake' ),
|
|
);
|
|
}
|
|
}
|