ff5fb5ea3e
This is the kind of easy to fix, hard to review bug. Email validation make uses of strings listing characters, those strings are then enclosed between brackets "[]". Inside brackets, the hyphen is used to describe a range of character [a-d] being a b c d. The string containing an unescaped hyphen, made JS/PHP validation to match the incorrect comma ",". * Backslash hyphen * JS,PHP: add tests for commas and hyphens in username or domain * JS: add var to rfc_1034_ldh_str * JS: minor code cleanup TESTS: php phpunit.php -c suite.xml --filter ValidEmail OK (13 tests, 32 assertions) Special:BlankPage?action=mwutiltest&debug=true Ran 66 tests. 66 passed test(s). 0 error(s). 0 partially passed test(s).
79 lines
2.4 KiB
PHP
79 lines
2.4 KiB
PHP
<?php
|
|
|
|
class UserIsValidEmailAddrTest extends MediaWikiTestCase {
|
|
|
|
private function checkEmail( $addr, $expected = true, $msg = '') {
|
|
if( $msg == '' ) { $msg = "Testing $addr"; }
|
|
$this->assertEquals(
|
|
$expected,
|
|
User::isValidEmailAddr( $addr ),
|
|
$msg
|
|
);
|
|
}
|
|
private function valid( $addr, $msg = '' ) {
|
|
$this->checkEmail( $addr, true, $msg );
|
|
}
|
|
private function invalid( $addr, $msg = '' ) {
|
|
$this->checkEmail( $addr, false, $msg );
|
|
}
|
|
|
|
function testEmailWellKnownUserAtHostDotTldAreValid() {
|
|
$this->valid( 'user@example.com' );
|
|
$this->valid( 'user@example.museum' );
|
|
}
|
|
function testEmailWithUpperCaseCharactersAreValid() {
|
|
$this->valid( 'USER@example.com' );
|
|
$this->valid( 'user@EXAMPLE.COM' );
|
|
$this->valid( 'user@Example.com' );
|
|
$this->valid( 'USER@eXAMPLE.com' );
|
|
}
|
|
function testEmailWithAPlusInUserName() {
|
|
$this->valid( 'user+sub@example.com' );
|
|
$this->valid( 'user+@example.com' );
|
|
}
|
|
function testEmailDoesNotNeedATopLevelDomain() {
|
|
$this->valid( "user@localhost" );
|
|
$this->valid( "FooBar@localdomain" );
|
|
$this->valid( "nobody@mycompany" );
|
|
}
|
|
function testEmailWithWhiteSpacesBeforeOrAfterAreInvalids() {
|
|
$this->invalid( " user@host.com" );
|
|
$this->invalid( "user@host.com " );
|
|
$this->invalid( "\tuser@host.com" );
|
|
$this->invalid( "user@host.com\t" );
|
|
}
|
|
function testEmailWithWhiteSpacesAreInvalids() {
|
|
$this->invalid( "User user@host" );
|
|
$this->invalid( "first last@mycompany" );
|
|
$this->invalid( "firstlast@my company" );
|
|
}
|
|
// bug 26948 : comma were matched by an incorrect regexp range
|
|
function testEmailWithCommasAreInvalids() {
|
|
$this->invalid( "user,foo@example.org" );
|
|
$this->invalid( "userfoo@ex,ample.org" );
|
|
}
|
|
function testEmailWithHyphens() {
|
|
$this->valid( "user-foo@example.org" );
|
|
$this->valid( "userfoo@ex-ample.org" );
|
|
}
|
|
function testEmailDomainCanNotBeginWithDot() {
|
|
$this->invalid( "user@." );
|
|
$this->invalid( "user@.localdomain" );
|
|
$this->invalid( "user@localdomain." );
|
|
$this->valid( "user.@localdomain" );
|
|
$this->valid( ".@localdomain" );
|
|
$this->invalid( ".@a............" );
|
|
}
|
|
function testEmailWithFunnyCharacters() {
|
|
$this->valid( "\$user!ex{this}@123.com" );
|
|
}
|
|
function testEmailTopLevelDomainCanBeNumerical() {
|
|
$this->valid( "user@example.1234" );
|
|
}
|
|
function testEmailWithoutAtSignIsInvalid() {
|
|
$this->invalid( 'useràexample.com' );
|
|
}
|
|
function testEmailWithOneCharacterDomainIsValid() {
|
|
$this->valid( 'user@a' );
|
|
}
|
|
}
|