d40cd42b9f
This is part of a chain that reverts:
e412ff5ecc.
NOTE:
- The feature is disabled by default
- User settings default to hiding changes
- T109707 Touching a file on wikisource adds and
removes it from a category... Even when page
has no changes.... WTF? See linked issue,
marked as stalled with a possible way forward
for this patch.
@see https://gerrit.wikimedia.org/r/#/c/235467/
Changes since version 1:
- T109604 - Page names in comment are no longer
url encoded / have _'s
- T109638 & T110338 - Reserved username now used
when we can't determine a username for the change
(we could perhaps set the user and id to be blank
in the RC table, but who knows what this might do)
- T109688 - History links are now disabled in RC....
(could be fine for the introduction and worked
on more in the future)
- Categorization changes are now always patrolled
- Touching on T109672 in this change emails will never
be sent regarding categorization changes. (this
can of course be changed in a followup)
- Added $wgRCWatchCategoryMembership defaulting to true
for enabling / disabling the feature
- T109700 - for cases when no revision was retrieved
for a category change set the bot flag to true.
This means all changes caused by parser functions
& Lua will be marked as bot, as will changes that
cant find their revision due to slave lag..
Bug: T9148
Bug: T109604
Bug: T109638
Bug: T109688
Bug: T109700
Bug: T110338
Bug: T110340
Change-Id: I51c2c1254de862f24a26ef9dbbf027c6c83e9063
132 lines
3.1 KiB
PHP
132 lines
3.1 KiB
PHP
<?php
|
||
/**
|
||
* Test class for SpecialRecentchanges class
|
||
*
|
||
* Copyright © 2011, Antoine Musso
|
||
*
|
||
* @author Antoine Musso
|
||
* @group Database
|
||
*
|
||
* @covers SpecialRecentChanges
|
||
*/
|
||
class SpecialRecentchangesTest extends MediaWikiTestCase {
|
||
|
||
protected function setUp() {
|
||
parent::setUp();
|
||
$this->setMwGlobals( 'wgRCWatchCategoryMembership', true );
|
||
}
|
||
|
||
/**
|
||
* @var SpecialRecentChanges
|
||
*/
|
||
protected $rc;
|
||
|
||
/** helper to test SpecialRecentchanges::buildMainQueryConds() */
|
||
private function assertConditions( $expected, $requestOptions = null, $message = '' ) {
|
||
$context = new RequestContext;
|
||
$context->setRequest( new FauxRequest( $requestOptions ) );
|
||
|
||
# setup the rc object
|
||
$this->rc = new SpecialRecentChanges();
|
||
$this->rc->setContext( $context );
|
||
$formOptions = $this->rc->setup( null );
|
||
|
||
# Filter out rc_timestamp conditions which depends on the test runtime
|
||
# This condition is not needed as of march 2, 2011 -- hashar
|
||
# @todo FIXME: Find a way to generate the correct rc_timestamp
|
||
$queryConditions = array_filter(
|
||
$this->rc->buildMainQueryConds( $formOptions ),
|
||
'SpecialRecentchangesTest::filterOutRcTimestampCondition'
|
||
);
|
||
|
||
$this->assertEquals(
|
||
$expected,
|
||
$queryConditions,
|
||
$message
|
||
);
|
||
}
|
||
|
||
/** return false if condition begin with 'rc_timestamp ' */
|
||
private static function filterOutRcTimestampCondition( $var ) {
|
||
return ( false === strpos( $var, 'rc_timestamp ' ) );
|
||
}
|
||
|
||
public function testRcNsFilter() {
|
||
$this->assertConditions(
|
||
array( # expected
|
||
'rc_bot' => 0,
|
||
0 => "rc_type != '6'",
|
||
1 => "rc_namespace = '0'",
|
||
),
|
||
array(
|
||
'namespace' => NS_MAIN,
|
||
),
|
||
"rc conditions with no options (aka default setting)"
|
||
);
|
||
}
|
||
|
||
public function testRcNsFilterInversion() {
|
||
$this->assertConditions(
|
||
array( # expected
|
||
'rc_bot' => 0,
|
||
0 => "rc_type != '6'",
|
||
1 => sprintf( "rc_namespace != '%s'", NS_MAIN ),
|
||
),
|
||
array(
|
||
'namespace' => NS_MAIN,
|
||
'invert' => 1,
|
||
),
|
||
"rc conditions with namespace inverted"
|
||
);
|
||
}
|
||
|
||
/**
|
||
* @bug 2429
|
||
* @dataProvider provideNamespacesAssociations
|
||
*/
|
||
public function testRcNsFilterAssociation( $ns1, $ns2 ) {
|
||
$this->assertConditions(
|
||
array( # expected
|
||
'rc_bot' => 0,
|
||
0 => "rc_type != '6'",
|
||
1 => sprintf( "(rc_namespace = '%s' OR rc_namespace = '%s')", $ns1, $ns2 ),
|
||
),
|
||
array(
|
||
'namespace' => $ns1,
|
||
'associated' => 1,
|
||
),
|
||
"rc conditions with namespace inverted"
|
||
);
|
||
}
|
||
|
||
/**
|
||
* @bug 2429
|
||
* @dataProvider provideNamespacesAssociations
|
||
*/
|
||
public function testRcNsFilterAssociationWithInversion( $ns1, $ns2 ) {
|
||
$this->assertConditions(
|
||
array( # expected
|
||
'rc_bot' => 0,
|
||
0 => "rc_type != '6'",
|
||
1 => sprintf( "(rc_namespace != '%s' AND rc_namespace != '%s')", $ns1, $ns2 ),
|
||
),
|
||
array(
|
||
'namespace' => $ns1,
|
||
'associated' => 1,
|
||
'invert' => 1,
|
||
),
|
||
"rc conditions with namespace inverted"
|
||
);
|
||
}
|
||
|
||
/**
|
||
* Provides associated namespaces to test recent changes
|
||
* namespaces association filtering.
|
||
*/
|
||
public static function provideNamespacesAssociations() {
|
||
return array( # (NS => Associated_NS)
|
||
array( NS_MAIN, NS_TALK ),
|
||
array( NS_TALK, NS_MAIN ),
|
||
);
|
||
}
|
||
}
|