wiki.techinc.nl/tests/phpunit/includes/auth/AbstractPasswordPrimaryAuthenticationProviderTest.php
vladshapik 3a150275de Implement injecting of dependencies to an AuthenticationProvider
init() method was added to AuthenticationProvider. It helps to inject
dependecies. Overridable postInitSetup() method was added to
AbstractAuthenticationProvider. A provider can override this to do
any necessary setup.
AbstractAuthenticationProvider ::setLogger(), ::setManager(), ::setConfig(),
::setHookContainer() were soft deprecated. Now developers must use
AbstractAuthenticationProvider::init().

Bug: T275030
Change-Id: I6ca63eddac1b177eeadbdcce992e71c44a480160
2021-04-26 15:17:34 +03:00

260 lines
8.3 KiB
PHP

<?php
namespace MediaWiki\Auth;
use MediaWiki\MediaWikiServices;
use MediaWiki\User\UserNameUtils;
use MultiConfig;
use Psr\Log\NullLogger;
use Wikimedia\TestingAccessWrapper;
/**
* @group AuthManager
* @covers \MediaWiki\Auth\AbstractPasswordPrimaryAuthenticationProvider
*/
class AbstractPasswordPrimaryAuthenticationProviderTest extends \MediaWikiIntegrationTestCase {
public function testConstructor() {
$provider = $this->getMockForAbstractClass(
AbstractPasswordPrimaryAuthenticationProvider::class
);
$providerPriv = TestingAccessWrapper::newFromObject( $provider );
$this->assertTrue( $providerPriv->authoritative );
$provider = $this->getMockForAbstractClass(
AbstractPasswordPrimaryAuthenticationProvider::class,
[ [ 'authoritative' => false ] ]
);
$providerPriv = TestingAccessWrapper::newFromObject( $provider );
$this->assertFalse( $providerPriv->authoritative );
}
public function testGetPasswordFactory() {
$provider = $this->getMockForAbstractClass(
AbstractPasswordPrimaryAuthenticationProvider::class
);
$provider->init(
$this->createNoOpMock( NullLogger::class ),
$this->createNoOpMock( AuthManager::class ),
$this->createHookContainer(),
$this->getServiceContainer()->getMainConfig(),
$this->createNoOpMock( UserNameUtils::class )
);
$providerPriv = TestingAccessWrapper::newFromObject( $provider );
$obj = $providerPriv->getPasswordFactory();
$this->assertInstanceOf( \PasswordFactory::class, $obj );
$this->assertSame( $obj, $providerPriv->getPasswordFactory() );
}
public function testGetPassword() {
$provider = $this->getMockForAbstractClass(
AbstractPasswordPrimaryAuthenticationProvider::class
);
$provider->init(
new NullLogger(),
$this->createNoOpMock( AuthManager::class ),
$this->createHookContainer(),
MediaWikiServices::getInstance()->getMainConfig(),
$this->createNoOpMock( UserNameUtils::class )
);
$providerPriv = TestingAccessWrapper::newFromObject( $provider );
$obj = $providerPriv->getPassword( null );
$this->assertInstanceOf( \Password::class, $obj );
$obj = $providerPriv->getPassword( 'invalid' );
$this->assertInstanceOf( \Password::class, $obj );
}
public function testGetNewPasswordExpiry() {
$config = new \HashConfig;
$provider = $this->getMockForAbstractClass(
AbstractPasswordPrimaryAuthenticationProvider::class
);
$provider->init(
new NullLogger(),
$this->createNoOpMock( AuthManager::class ),
$this->getServiceContainer()->getHookContainer(),
new MultiConfig( [ $config, $this->getServiceContainer()->getMainConfig() ] ),
$this->createNoOpMock( UserNameUtils::class )
);
$providerPriv = TestingAccessWrapper::newFromObject( $provider );
$this->mergeMwGlobalArrayValue( 'wgHooks', [ 'ResetPasswordExpiration' => [] ] );
$config->set( 'PasswordExpirationDays', 0 );
$this->assertNull( $providerPriv->getNewPasswordExpiry( 'UTSysop' ) );
$config->set( 'PasswordExpirationDays', 5 );
$this->assertEqualsWithDelta(
time() + 5 * 86400,
wfTimestamp( TS_UNIX, $providerPriv->getNewPasswordExpiry( 'UTSysop' ) ),
2 /* Fuzz */
);
$this->mergeMwGlobalArrayValue( 'wgHooks', [
'ResetPasswordExpiration' => [ function ( $user, &$expires ) {
$this->assertSame( 'UTSysop', $user->getName() );
$expires = '30001231235959';
} ]
] );
$this->assertSame( '30001231235959', $providerPriv->getNewPasswordExpiry( 'UTSysop' ) );
}
public function testCheckPasswordValidity() {
$uppCalled = 0;
$uppStatus = \Status::newGood( [] );
$this->setMwGlobals( [
'wgPasswordPolicy' => [
'policies' => [
'default' => [
'Check' => true,
],
],
'checks' => [
'Check' => static function () use ( &$uppCalled, &$uppStatus ) {
$uppCalled++;
return $uppStatus;
},
],
]
] );
$provider = $this->getMockForAbstractClass(
AbstractPasswordPrimaryAuthenticationProvider::class
);
$provider->init(
new NullLogger(),
$this->createNoOpMock( AuthManager::class ),
$this->createHookContainer(),
$this->getServiceContainer()->getMainConfig(),
$this->createNoOpMock( UserNameUtils::class )
);
$providerPriv = TestingAccessWrapper::newFromObject( $provider );
$this->assertEquals( $uppStatus, $providerPriv->checkPasswordValidity( 'foo', 'bar' ) );
$uppStatus->fatal( 'arbitrary-warning' );
$this->assertEquals( $uppStatus, $providerPriv->checkPasswordValidity( 'foo', 'bar' ) );
}
public function testSetPasswordResetFlag() {
$config = new \HashConfig( [
'InvalidPasswordReset' => true,
] );
$services = MediaWikiServices::getInstance();
$manager = new AuthManager(
new \FauxRequest(),
$services->getMainConfig(),
$services->getObjectFactory(),
$services->getHookContainer(),
$services->getReadOnlyMode(),
$services->getUserNameUtils(),
$services->getBlockManager(),
$services->getBlockErrorFormatter(),
$services->getWatchlistManager()
);
$provider = $this->getMockForAbstractClass(
AbstractPasswordPrimaryAuthenticationProvider::class
);
$provider->init(
new NullLogger(),
$manager,
$services->getHookContainer(),
$config,
$this->createNoOpMock( UserNameUtils::class )
);
$providerPriv = TestingAccessWrapper::newFromObject( $provider );
$manager->removeAuthenticationSessionData( null );
$status = \Status::newGood();
$providerPriv->setPasswordResetFlag( 'Foo', $status );
$this->assertNull( $manager->getAuthenticationSessionData( 'reset-pass' ) );
$manager->removeAuthenticationSessionData( null );
$status = \Status::newGood( [ 'suggestChangeOnLogin' => true ] );
$status->error( 'testing' );
$providerPriv->setPasswordResetFlag( 'Foo', $status );
$ret = $manager->getAuthenticationSessionData( 'reset-pass' );
$this->assertNotNull( $ret );
$this->assertSame( 'resetpass-validity-soft', $ret->msg->getKey() );
$this->assertFalse( $ret->hard );
$config->set( 'InvalidPasswordReset', false );
$manager->removeAuthenticationSessionData( null );
$providerPriv->setPasswordResetFlag( 'Foo', $status );
$ret = $manager->getAuthenticationSessionData( 'reset-pass' );
$this->assertNull( $ret );
}
public function testFailResponse() {
$provider = $this->getMockForAbstractClass(
AbstractPasswordPrimaryAuthenticationProvider::class,
[ [ 'authoritative' => false ] ]
);
$providerPriv = TestingAccessWrapper::newFromObject( $provider );
$req = new PasswordAuthenticationRequest;
$ret = $providerPriv->failResponse( $req );
$this->assertSame( AuthenticationResponse::ABSTAIN, $ret->status );
$provider = $this->getMockForAbstractClass(
AbstractPasswordPrimaryAuthenticationProvider::class,
[ [ 'authoritative' => true ] ]
);
$providerPriv = TestingAccessWrapper::newFromObject( $provider );
$req->password = '';
$ret = $providerPriv->failResponse( $req );
$this->assertSame( AuthenticationResponse::FAIL, $ret->status );
$this->assertSame( 'wrongpasswordempty', $ret->message->getKey() );
$req->password = 'X';
$ret = $providerPriv->failResponse( $req );
$this->assertSame( AuthenticationResponse::FAIL, $ret->status );
$this->assertSame( 'wrongpassword', $ret->message->getKey() );
}
/**
* @dataProvider provideGetAuthenticationRequests
* @param string $action
* @param array $response
*/
public function testGetAuthenticationRequests( $action, $response ) {
$provider = $this->getMockForAbstractClass(
AbstractPasswordPrimaryAuthenticationProvider::class
);
$this->assertEquals( $response, $provider->getAuthenticationRequests( $action, [] ) );
}
public static function provideGetAuthenticationRequests() {
return [
[ AuthManager::ACTION_LOGIN, [ new PasswordAuthenticationRequest() ] ],
[ AuthManager::ACTION_CREATE, [ new PasswordAuthenticationRequest() ] ],
[ AuthManager::ACTION_LINK, [] ],
[ AuthManager::ACTION_CHANGE, [ new PasswordAuthenticationRequest() ] ],
[ AuthManager::ACTION_REMOVE, [ new PasswordAuthenticationRequest() ] ],
];
}
public function testProviderRevokeAccessForUser() {
$req = new PasswordAuthenticationRequest;
$req->action = AuthManager::ACTION_REMOVE;
$req->username = 'foo';
$req->password = null;
$provider = $this->getMockForAbstractClass(
AbstractPasswordPrimaryAuthenticationProvider::class
);
$provider->expects( $this->once() )
->method( 'providerChangeAuthenticationData' )
->with( $req );
$provider->providerRevokeAccessForUser( 'foo' );
}
}