eabf8afbd8
This test was an awful, awful, mess. (And I take full responsibility.) Changing the global user language mid-way into execution is in no way supported by ResourceLoader and this test was going through great lengths to fool mw.loader about what's really going on. Basically, all we're doing is get a list of instructions on what tests to run, get comparison values based how the PHP side proceses these (for parity comparison), and then run the assertions. The mw.language singleton already has support for multiple languages, and mediawiki.jqueryMsg already supports injecting data and constructing new instances for each test case. Make use of that :) Instead of calling ResourceLoaderLanguageDataModule::getData by trying to hot load the same module repeatedly from load.php, just export this data using 'packageFiles'. The mediawiki.jqueryMsg QUnit suite previously took 4s to run locally and now only 0.1s (145ms). This is not only significant for this particular module, but also for QUnit in general as Headless Chrome only took about 7s to run all of MediaWiki core's test suites prior to this change, which is now down to ~3s. (MacBook Pro) For WMF CI: * Before (master commit): - mediawiki.jqueryMsg.test: ~2.1s (2135ms) - MediaWiki core total: ~4.8s * After (this patch): - mediawiki.jqueryMsg.test: ~0.015s (15ms) - MediaWiki core total: ~3.6s Bug: T250045 Bug: T225730 Change-Id: I5f1067feb0a43d63bfc5e7fff5110285a5e433c8
82 lines
2.5 KiB
PHP
82 lines
2.5 KiB
PHP
<?php
|
|
/**
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @file
|
|
* @author Santhosh Thottingal
|
|
*/
|
|
|
|
use MediaWiki\MediaWikiServices;
|
|
|
|
/**
|
|
* Module for populating language specific data, such as grammar forms.
|
|
*
|
|
* @ingroup ResourceLoader
|
|
* @internal
|
|
*/
|
|
class ResourceLoaderLanguageDataModule extends ResourceLoaderFileModule {
|
|
|
|
protected $targets = [ 'desktop', 'mobile' ];
|
|
|
|
/**
|
|
* Get all the dynamic data for the content language to an array.
|
|
*
|
|
* @internal Only public for use by GenerateJqueryMsgData (tests)
|
|
* @param string $langCode
|
|
* @return array
|
|
*/
|
|
public static function getData( $langCode ) {
|
|
$language = MediaWikiServices::getInstance()->getLanguageFactory()
|
|
->getLanguage( $langCode );
|
|
return [
|
|
'digitTransformTable' => $language->digitTransformTable(),
|
|
'separatorTransformTable' => $language->separatorTransformTable(),
|
|
'minimumGroupingDigits' => $language->minimumGroupingDigits(),
|
|
'grammarForms' => $language->getGrammarForms(),
|
|
'grammarTransformations' => $language->getGrammarTransformations(),
|
|
'pluralRules' => $language->getPluralRules(),
|
|
'digitGroupingPattern' => $language->digitGroupingPattern(),
|
|
'fallbackLanguages' => $language->getFallbackLanguages(),
|
|
'bcp47Map' => LanguageCode::getNonstandardLanguageCodeMapping(),
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @param ResourceLoaderContext $context
|
|
* @return string JavaScript code
|
|
*/
|
|
public function getScript( ResourceLoaderContext $context ) {
|
|
return parent::getScript( $context )
|
|
. 'mw.language.setData('
|
|
. $context->encodeJson( $context->getLanguage() ) . ','
|
|
. $context->encodeJson( self::getData( $context->getLanguage() ) )
|
|
. ');';
|
|
}
|
|
|
|
/**
|
|
* @return bool
|
|
*/
|
|
public function enableModuleContentVersion() {
|
|
return true;
|
|
}
|
|
|
|
/**
|
|
* @return bool
|
|
*/
|
|
public function supportsURLLoading() {
|
|
return false;
|
|
}
|
|
}
|