6aa6d10e86
There is native support for all of this now in PHP, thanks to changes and additions that have been made in later versions. There should be no need any more to ever use call_user_func() or call_user_func_array(). Reviewing this should be fairly easy: Because this patch touches exclusivly tests, but no production code, there is no such thing as "insufficent test coverage". As long as CI goes green, this should be fine. Change-Id: Ib9690103687734bb5a85d3dab0e5642a07087bbc
112 lines
2.9 KiB
PHP
112 lines
2.9 KiB
PHP
<?php
|
|
|
|
namespace MediaWiki\Auth;
|
|
|
|
/**
|
|
* @group AuthManager
|
|
* @covers \MediaWiki\Auth\AuthenticationResponse
|
|
*/
|
|
class AuthenticationResponseTest extends \MediaWikiUnitTestCase {
|
|
/**
|
|
* @dataProvider provideConstructors
|
|
* @param string $constructor
|
|
* @param array $args
|
|
* @param array|Exception $expect
|
|
*/
|
|
public function testConstructors( $constructor, $args, $expect ) {
|
|
if ( is_array( $expect ) ) {
|
|
$res = new AuthenticationResponse();
|
|
$res->messageType = 'warning';
|
|
foreach ( $expect as $field => $value ) {
|
|
$res->$field = $value;
|
|
}
|
|
$ret = AuthenticationResponse::$constructor( ...$args );
|
|
$this->assertEquals( $res, $ret );
|
|
} else {
|
|
try {
|
|
AuthenticationResponse::$constructor( ...$args );
|
|
$this->fail( 'Expected exception not thrown' );
|
|
} catch ( \Exception $ex ) {
|
|
$this->assertEquals( $expect, $ex );
|
|
}
|
|
}
|
|
}
|
|
|
|
public function provideConstructors() {
|
|
$req = $this->getMockForAbstractClass( AuthenticationRequest::class );
|
|
$msg = new \Message( 'mainpage' );
|
|
|
|
return [
|
|
[ 'newPass', [], [
|
|
'status' => AuthenticationResponse::PASS,
|
|
] ],
|
|
[ 'newPass', [ 'name' ], [
|
|
'status' => AuthenticationResponse::PASS,
|
|
'username' => 'name',
|
|
] ],
|
|
[ 'newPass', [ 'name', null ], [
|
|
'status' => AuthenticationResponse::PASS,
|
|
'username' => 'name',
|
|
] ],
|
|
|
|
[ 'newFail', [ $msg ], [
|
|
'status' => AuthenticationResponse::FAIL,
|
|
'message' => $msg,
|
|
'messageType' => 'error',
|
|
] ],
|
|
|
|
[ 'newRestart', [ $msg ], [
|
|
'status' => AuthenticationResponse::RESTART,
|
|
'message' => $msg,
|
|
] ],
|
|
|
|
[ 'newAbstain', [], [
|
|
'status' => AuthenticationResponse::ABSTAIN,
|
|
] ],
|
|
|
|
[ 'newUI', [ [ $req ], $msg ], [
|
|
'status' => AuthenticationResponse::UI,
|
|
'neededRequests' => [ $req ],
|
|
'message' => $msg,
|
|
'messageType' => 'warning',
|
|
] ],
|
|
|
|
[ 'newUI', [ [ $req ], $msg, 'warning' ], [
|
|
'status' => AuthenticationResponse::UI,
|
|
'neededRequests' => [ $req ],
|
|
'message' => $msg,
|
|
'messageType' => 'warning',
|
|
] ],
|
|
|
|
[ 'newUI', [ [ $req ], $msg, 'error' ], [
|
|
'status' => AuthenticationResponse::UI,
|
|
'neededRequests' => [ $req ],
|
|
'message' => $msg,
|
|
'messageType' => 'error',
|
|
] ],
|
|
[ 'newUI', [ [], $msg ],
|
|
new \InvalidArgumentException( '$reqs may not be empty' )
|
|
],
|
|
|
|
[ 'newRedirect', [ [ $req ], 'http://example.org/redir' ], [
|
|
'status' => AuthenticationResponse::REDIRECT,
|
|
'neededRequests' => [ $req ],
|
|
'redirectTarget' => 'http://example.org/redir',
|
|
] ],
|
|
[
|
|
'newRedirect',
|
|
[ [ $req ], 'http://example.org/redir', [ 'foo' => 'bar' ] ],
|
|
[
|
|
'status' => AuthenticationResponse::REDIRECT,
|
|
'neededRequests' => [ $req ],
|
|
'redirectTarget' => 'http://example.org/redir',
|
|
'redirectApiData' => [ 'foo' => 'bar' ],
|
|
]
|
|
],
|
|
[ 'newRedirect', [ [], 'http://example.org/redir' ],
|
|
new \InvalidArgumentException( '$reqs may not be empty' )
|
|
],
|
|
];
|
|
}
|
|
|
|
}
|