wiki.techinc.nl/includes/jobqueue/jobs/DoubleRedirectJob.php
Thiemo Kreuz 41ec072d16 Add missing null to string casts when using rd_fragment and such
These columns are nullable, but the method doesn't accept null.

Found in Logstash.

Change-Id: I3eaafe31005c9319fdd03f8f4b54e7b51ef430f9
2021-11-02 07:14:32 +00:00

264 lines
7.7 KiB
PHP

<?php
/**
* Job to fix double redirects after moving a page.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
* http://www.gnu.org/copyleft/gpl.html
*
* @file
* @ingroup JobQueue
*/
use MediaWiki\Cache\CacheKeyHelper;
use MediaWiki\Linker\LinkTarget;
use MediaWiki\MediaWikiServices;
use MediaWiki\Page\PageReference;
use MediaWiki\Revision\RevisionLookup;
use MediaWiki\Revision\SlotRecord;
/**
* Job to fix double redirects after moving a page
*
* @ingroup JobQueue
*/
class DoubleRedirectJob extends Job {
/** @var Title The title which has changed, redirects pointing to this
* title are fixed
*/
private $redirTitle;
/** @var User */
private static $user;
/**
* @param PageReference $page
* @param array $params Expected to contain these elements:
* - 'redirTitle' => string The title that changed and should be fixed.
* - 'reason' => string Reason for the change, can be "move" or "maintenance". Used as a suffix
* for the message keys "double-redirect-fixed-move" and
* "double-redirect-fixed-maintenance".
* ]
*/
public function __construct( PageReference $page, array $params ) {
parent::__construct( 'fixDoubleRedirect', $page, $params );
$this->redirTitle = Title::newFromText( $params['redirTitle'] );
}
/**
* Insert jobs into the job queue to fix redirects to the given title
* @param string $reason The reason for the fix, see message
* "double-redirect-fixed-<reason>"
* @param LinkTarget $redirTitle The title which has changed, redirects
* pointing to this title are fixed
*/
public static function fixRedirects( $reason, $redirTitle ) {
# Need to use the primary DB to get the redirect table updated in the same transaction
$dbw = wfGetDB( DB_PRIMARY );
$res = $dbw->select(
[ 'redirect', 'page' ],
[ 'page_namespace', 'page_title' ],
[
'page_id = rd_from',
'rd_namespace' => $redirTitle->getNamespace(),
'rd_title' => $redirTitle->getDBkey()
], __METHOD__ );
if ( !$res->numRows() ) {
return;
}
$jobs = [];
foreach ( $res as $row ) {
$title = Title::makeTitle( $row->page_namespace, $row->page_title );
if ( !$title ) {
continue;
}
$jobs[] = new self( $title, [
'reason' => $reason,
'redirTitle' => MediaWikiServices::getInstance()
->getTitleFormatter()
->getPrefixedDBkey( $redirTitle ),
] );
# Avoid excessive memory usage
if ( count( $jobs ) > 10000 ) {
JobQueueGroup::singleton()->push( $jobs );
$jobs = [];
}
}
JobQueueGroup::singleton()->push( $jobs );
}
/**
* @return bool
*/
public function run() {
if ( !$this->redirTitle ) {
$this->setLastError( 'Invalid title' );
return false;
}
$services = MediaWikiServices::getInstance();
$targetRev = $services->getRevisionLookup()
->getRevisionByTitle( $this->title, 0, RevisionLookup::READ_LATEST );
if ( !$targetRev ) {
wfDebug( __METHOD__ . ": target redirect already deleted, ignoring" );
return true;
}
$content = $targetRev->getContent( SlotRecord::MAIN );
$currentDest = $content ? $content->getRedirectTarget() : null;
if ( !$currentDest || !$currentDest->equals( $this->redirTitle ) ) {
wfDebug( __METHOD__ . ": Redirect has changed since the job was queued" );
return true;
}
// Check for a suppression tag (used e.g. in periodically archived discussions)
$mw = $services->getMagicWordFactory()->get( 'staticredirect' );
if ( $content->matchMagicWord( $mw ) ) {
wfDebug( __METHOD__ . ": skipping: suppressed with __STATICREDIRECT__" );
return true;
}
// Find the current final destination
$newTitle = self::getFinalDestination( $this->redirTitle );
if ( !$newTitle ) {
wfDebug( __METHOD__ .
": skipping: single redirect, circular redirect or invalid redirect destination" );
return true;
}
if ( $newTitle->equals( $this->redirTitle ) ) {
// The redirect is already right, no need to change it
// This can happen if the page was moved back (say after vandalism)
wfDebug( __METHOD__ . " : skipping, already good" );
}
// Preserve fragment (T16904)
$newTitle = Title::makeTitle( $newTitle->getNamespace(), $newTitle->getDBkey(),
$currentDest->getFragment(), $newTitle->getInterwiki() );
// Fix the text
$newContent = $content->updateRedirect( $newTitle );
if ( $newContent->equals( $content ) ) {
$this->setLastError( 'Content unchanged???' );
return false;
}
$user = $this->getUser();
if ( !$user ) {
$this->setLastError( 'Invalid user' );
return false;
}
// Save it
// phpcs:ignore MediaWiki.Usage.DeprecatedGlobalVariables.Deprecated$wgUser
global $wgUser;
$oldUser = $wgUser;
$wgUser = $user;
$article = $services->getWikiPageFactory()->newFromTitle( $this->title );
// Messages: double-redirect-fixed-move, double-redirect-fixed-maintenance
$reason = wfMessage( 'double-redirect-fixed-' . $this->params['reason'],
$this->redirTitle->getPrefixedText(), $newTitle->getPrefixedText()
)->inContentLanguage()->text();
$flags = EDIT_UPDATE | EDIT_SUPPRESS_RC | EDIT_INTERNAL;
$article->doUserEditContent( $newContent, $user, $reason, $flags );
$wgUser = $oldUser;
return true;
}
/**
* Get the final destination of a redirect
*
* @param LinkTarget $title
*
* @return Title|bool The final Title after following all redirects, or false if
* the page is not a redirect or the redirect loops.
*/
public static function getFinalDestination( $title ) {
$dbw = wfGetDB( DB_PRIMARY );
// Circular redirect check
$seenTitles = [];
$dest = false;
while ( true ) {
$titleText = CacheKeyHelper::getKeyForPage( $title );
if ( isset( $seenTitles[$titleText] ) ) {
wfDebug( __METHOD__, "Circular redirect detected, aborting" );
return false;
}
$seenTitles[$titleText] = true;
if ( $title->isExternal() ) {
// If the target is interwiki, we have to break early (T42352).
// Otherwise it will look up a row in the local page table
// with the namespace/page of the interwiki target which can cause
// unexpected results (e.g. X -> foo:Bar -> Bar -> .. )
break;
}
$row = $dbw->selectRow(
[ 'redirect', 'page' ],
[ 'rd_namespace', 'rd_title', 'rd_interwiki' ],
[
'rd_from=page_id',
'page_namespace' => $title->getNamespace(),
'page_title' => $title->getDBkey()
], __METHOD__ );
if ( !$row ) {
# No redirect from here, chain terminates
break;
} else {
$dest = $title = Title::makeTitle(
$row->rd_namespace,
$row->rd_title,
'',
$row->rd_interwiki ?? ''
);
}
}
return $dest;
}
/**
* Get a user object for doing edits, from a request-lifetime cache
* False will be returned if the user name specified in the
* 'double-redirect-fixer' message is invalid.
*
* @return User|bool
*/
private function getUser() {
if ( !self::$user ) {
$username = wfMessage( 'double-redirect-fixer' )->inContentLanguage()->text();
self::$user = User::newFromName( $username );
# User::newFromName() can return false on a badly configured wiki.
if ( self::$user && !self::$user->isRegistered() ) {
self::$user->addToDatabase();
}
}
return self::$user;
}
}