42a03b9752
The names of these methods are a little strange, that's probably why we missed them before. I tried to update closely related test cases, make use of PHP7 type hints, as well as yield where it feels it makes sense. Change-Id: I1cf27138e1e47f713739b6fd53101b9ec7d38fe7
130 lines
3.5 KiB
PHP
130 lines
3.5 KiB
PHP
<?php
|
|
|
|
/**
|
|
* @author Addshore
|
|
*
|
|
* @group Diff
|
|
*/
|
|
class ArrayDiffFormatterTest extends \MediaWikiUnitTestCase {
|
|
|
|
/**
|
|
* @param Diff $input
|
|
* @param array $expectedOutput
|
|
* @dataProvider provideTestFormat
|
|
* @covers ArrayDiffFormatter::format
|
|
*/
|
|
public function testFormat( Diff $input, array $expectedOutput ) {
|
|
$instance = new ArrayDiffFormatter();
|
|
$output = $instance->format( $input );
|
|
$this->assertSame( $expectedOutput, $output );
|
|
}
|
|
|
|
private function getMockDiff( array $edits ) {
|
|
$diff = $this->getMockBuilder( Diff::class )
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
$diff->expects( $this->any() )
|
|
->method( 'getEdits' )
|
|
->will( $this->returnValue( $edits ) );
|
|
return $diff;
|
|
}
|
|
|
|
private function getMockDiffOp( string $type, $orig = [], array $closing = [] ) {
|
|
$diffOp = $this->getMockBuilder( DiffOp::class )
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
$diffOp->expects( $this->any() )
|
|
->method( 'getType' )
|
|
->will( $this->returnValue( $type ) );
|
|
$diffOp->expects( $this->any() )
|
|
->method( 'getOrig' )
|
|
->will( $this->returnValue( $orig ) );
|
|
if ( $type === 'change' ) {
|
|
$diffOp->expects( $this->any() )
|
|
->method( 'getClosing' )
|
|
->with( $this->isType( 'integer' ) )
|
|
->will( $this->returnCallback( function () {
|
|
return 'mockLine';
|
|
} ) );
|
|
} else {
|
|
$diffOp->expects( $this->any() )
|
|
->method( 'getClosing' )
|
|
->will( $this->returnValue( $closing ) );
|
|
}
|
|
return $diffOp;
|
|
}
|
|
|
|
public function provideTestFormat() {
|
|
$emptyArrayTestCases = [
|
|
$this->getMockDiff( [] ),
|
|
$this->getMockDiff( [ $this->getMockDiffOp( 'add' ) ] ),
|
|
$this->getMockDiff( [ $this->getMockDiffOp( 'delete' ) ] ),
|
|
$this->getMockDiff( [ $this->getMockDiffOp( 'change' ) ] ),
|
|
$this->getMockDiff( [ $this->getMockDiffOp( 'copy' ) ] ),
|
|
$this->getMockDiff( [ $this->getMockDiffOp( 'FOOBARBAZ' ) ] ),
|
|
$this->getMockDiff( [ $this->getMockDiffOp( 'add', 'line' ) ] ),
|
|
$this->getMockDiff( [ $this->getMockDiffOp( 'delete', [], [ 'line' ] ) ] ),
|
|
$this->getMockDiff( [ $this->getMockDiffOp( 'copy', [], [ 'line' ] ) ] ),
|
|
];
|
|
foreach ( $emptyArrayTestCases as $testCase ) {
|
|
yield [ $testCase, [] ];
|
|
}
|
|
|
|
yield [
|
|
$this->getMockDiff( [ $this->getMockDiffOp( 'add', [], [ 'a1' ] ) ] ),
|
|
[ [ 'action' => 'add', 'new' => 'a1', 'newline' => 1 ] ],
|
|
];
|
|
yield [
|
|
$this->getMockDiff( [ $this->getMockDiffOp( 'add', [], [ 'a1', 'a2' ] ) ] ),
|
|
[
|
|
[ 'action' => 'add', 'new' => 'a1', 'newline' => 1 ],
|
|
[ 'action' => 'add', 'new' => 'a2', 'newline' => 2 ],
|
|
],
|
|
];
|
|
yield [
|
|
$this->getMockDiff( [ $this->getMockDiffOp( 'delete', [ 'd1' ] ) ] ),
|
|
[ [ 'action' => 'delete', 'old' => 'd1', 'oldline' => 1 ] ],
|
|
];
|
|
yield [
|
|
$this->getMockDiff( [ $this->getMockDiffOp( 'delete', [ 'd1', 'd2' ] ) ] ),
|
|
[
|
|
[ 'action' => 'delete', 'old' => 'd1', 'oldline' => 1 ],
|
|
[ 'action' => 'delete', 'old' => 'd2', 'oldline' => 2 ],
|
|
],
|
|
];
|
|
yield [
|
|
$this->getMockDiff( [ $this->getMockDiffOp( 'change', [ 'd1' ], [ 'a1' ] ) ] ),
|
|
[ [
|
|
'action' => 'change',
|
|
'old' => 'd1',
|
|
'new' => 'mockLine',
|
|
'oldline' => 1,
|
|
'newline' => 1,
|
|
] ],
|
|
];
|
|
yield [
|
|
$this->getMockDiff( [ $this->getMockDiffOp(
|
|
'change',
|
|
[ 'd1', 'd2' ],
|
|
[ 'a1', 'a2' ]
|
|
) ] ),
|
|
[
|
|
[
|
|
'action' => 'change',
|
|
'old' => 'd1',
|
|
'new' => 'mockLine',
|
|
'oldline' => 1,
|
|
'newline' => 1,
|
|
],
|
|
[
|
|
'action' => 'change',
|
|
'old' => 'd2',
|
|
'new' => 'mockLine',
|
|
'oldline' => 2,
|
|
'newline' => 2,
|
|
],
|
|
],
|
|
];
|
|
}
|
|
|
|
}
|