wiki.techinc.nl/includes/recentchanges
Dreamy Jazz 49907788ab SECURITY: Use ManualLogEntry::getDeleted in ::getRecentChange
CVE-2025-61639

Why:
* ManualLogEntry::getRecentChange creates the RecentChange object
  for the ManualLogEntry instance.
** This does not currently include the deleted flags set in the
   ManualLogEntry
** Without this, the RecentChange that is created will not be
   marked as deleted and published as public.
* Therefore, this means that any code which hides a log entry
  from the creation of the entry will cause a unintentionally
  public recent change entry.
** The AbuseFilter extension attempts to suppress the log entry
   for the block on it's creation, which therefore hits this
   security bug.

What:
* Update RecentChange::newLogEntry to accept a $deleted field
  which is set by default as 0 which is used as the value of
  rc_deleted.
* Update ManualLogEntry::getRecentChange to pass the value of
  ManualLogEntry::getDeleted to RecentChange::newLogEntry.
* Test that this fix worked.

Bug: T280413
Change-Id: I681a49ac7d7b22ffe259b976ad5315490dda467b
2025-10-02 19:38:49 +00:00
..
Hook
RCFeed objectcache: Move RedisConnRef.php to /libs/objectcache/ 2024-11-07 08:40:54 +00:00
CategoryMembershipChange.php recentchanges: Use current time for imported revision category changes 2024-10-23 11:43:34 +00:00
ChangesFeed.php recentchanges: Add missing documentation to class properties 2024-09-14 10:09:46 +02:00
ChangesList.php Remove a no longer needed workaround in watchlist page 2024-10-21 23:26:27 +00:00
ChangesListBooleanFilter.php
ChangesListBooleanFilterGroup.php
ChangesListFilter.php
ChangesListFilterGroup.php
ChangesListStringOptionsFilter.php
ChangesListStringOptionsFilterGroup.php
EnhancedChangesList.php SECURITY: Prevent leaking hidden usernames in Watchlist/RecentChanges 2025-10-02 19:38:49 +00:00
OldChangesList.php Use HTML markup instead of bidi control chars in wiki changes 2024-10-04 00:27:00 +03:30
RCCacheEntry.php
RCCacheEntryFactory.php
RecentChange.php SECURITY: Use ManualLogEntry::getDeleted in ::getRecentChange 2025-10-02 19:38:49 +00:00
RecentChangesUpdateJob.php