e4272518f7
assertEquals( false, … ) still succeeds when the actual value is 0, null, an empty string, even an empty array. All these should be reported as a failure, I would argue. Note this patch previously also touched assertSame( false ). I reverted these. The only benefit would have been consistency within this codebase, but there is no strict reason to prefer one over the other. assertFalse() and assertSame( false ) are functionally identical. Change-Id: Ic5f1c7d504e7249002d3184520012e03313137b4
67 lines
1.9 KiB
PHP
67 lines
1.9 KiB
PHP
<?php
|
|
/**
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*/
|
|
|
|
/**
|
|
* Validates all loaded extensions and skins using the ExtensionRegistry
|
|
* against the extension.json schema in the docs/ folder.
|
|
*/
|
|
class ExtensionJsonValidationTest extends PHPUnit\Framework\TestCase {
|
|
|
|
use MediaWikiCoversValidator;
|
|
|
|
/**
|
|
* @var ExtensionJsonValidator
|
|
*/
|
|
protected $validator;
|
|
|
|
public function setUp() {
|
|
parent::setUp();
|
|
|
|
$this->validator = new ExtensionJsonValidator( [ $this, 'markTestSkipped' ] );
|
|
$this->validator->checkDependencies();
|
|
|
|
if ( !ExtensionRegistry::getInstance()->getAllThings() ) {
|
|
$this->markTestSkipped(
|
|
'There are no extensions or skins loaded via the ExtensionRegistry'
|
|
);
|
|
}
|
|
}
|
|
|
|
public static function providePassesValidation() {
|
|
$values = [];
|
|
foreach ( ExtensionRegistry::getInstance()->getAllThings() as $thing ) {
|
|
$values[] = [ $thing['path'] ];
|
|
}
|
|
|
|
return $values;
|
|
}
|
|
|
|
/**
|
|
* @dataProvider providePassesValidation
|
|
* @param string $path Path to thing's json file
|
|
*/
|
|
public function testPassesValidation( $path ) {
|
|
try {
|
|
$this->validator->validate( $path );
|
|
// All good
|
|
$this->assertTrue( true );
|
|
} catch ( ExtensionJsonValidationError $e ) {
|
|
$this->assertFalse( $e->getMessage() );
|
|
}
|
|
}
|
|
}
|