The handling of the 'editsection' option prior to I7fb9ffca9 was unusual: it was included in the cache key, but the getter didn't ever flag it as "used". This was overlooked in I7fb9ffca9. This fixes the handling to restore that behavior. It's no longer considered to be a real parser option, so changing it won't make isSafeToCache() fail while reading it won't flag it as 'used'. But to keep Wikibase working (see T85252), if 'editsection' is supplied in $forOptions optionsHash() will still include it in the hash so whatever Wikibase is doing by forcing that doesn't break. The hash when it is included is the same as was used in I7fb9ffca9 to reuse keys. Once optionsHashPre30() is removed, Wikibase should be changed to use some other method to fix T85252 so we can remove that hack from optionsHash(). Change-Id: I77b5519c5a1122a1fafbfc523b77b2268c0efeb1 |
||
|---|---|---|
| .. | ||
| MagicVariableTest.php | ||
| ParserIntegrationTest.php | ||
| ParserMethodsTest.php | ||
| ParserOptionsTest.php | ||
| ParserOutputTest.php | ||
| ParserPreloadTest.php | ||
| PreprocessorTest.php | ||
| TagHooksTest.php | ||
| TidyTest.php | ||