wiki.techinc.nl/tests/phpunit/includes/parser/LinkHolderArrayIntegrationTest.php
thiemowmde 4ebc778eb7 parser: Make all LinkHolderArray properties private
I could not find any use outside of core, or even outside of this
class.

The class is instantiated a single time in core:
https://codesearch.wmcloud.org/search/?q=new%5CW%2BLinkHolderArray&files=%5C.php%24
This instance is not used anywhere else:
https://codesearch.wmcloud.org/search/?q=mLinkHolders&files=%5C.php%24

I would argue this doesn't really qualify as a breaking change. This
was always meant to be private.

Change-Id: I4c614dae1fe1d61c9cf8b7a03c37eb93fae33873
2023-03-15 10:44:04 +01:00

118 lines
2.8 KiB
PHP

<?php
declare( strict_types = 1 );
use MediaWiki\MainConfigNames;
use MediaWiki\Title\Title;
use Wikimedia\TestingAccessWrapper;
/**
* @covers LinkHolderArray
*/
class LinkHolderArrayIntegrationTest extends MediaWikiLangTestCase {
/**
* @dataProvider provideIsBig
* @covers LinkHolderArray::isBig
*
* @param int $size
* @param int $global
* @param bool $expected
*/
public function testIsBig( int $size, int $global, bool $expected ) {
$this->overrideConfigValue( MainConfigNames::LinkHolderBatchSize, $global );
$linkHolderArray = new LinkHolderArray(
$this->createMock( Parser::class ),
$this->createMock( ILanguageConverter::class ),
$this->createHookContainer()
);
/** @var LinkHolderArray $linkHolderArray */
$linkHolderArray = TestingAccessWrapper::newFromObject( $linkHolderArray );
$linkHolderArray->size = $size;
$this->assertSame( $expected, $linkHolderArray->isBig() );
}
public function provideIsBig() {
yield [ 0, 0, false ];
yield [ 0, 1, false ];
yield [ 1, 0, true ];
yield [ 1, 1, false ];
}
/**
* @dataProvider provideMakeHolder_withNsText
* @covers LinkHolderArray::makeHolder
*
* @param bool $isExternal
* @param string $expected
*/
public function testMakeHolder_withNsText(
bool $isExternal,
string $expected
) {
$link = new LinkHolderArray(
$this->createMock( Parser::class ),
$this->createMock( ILanguageConverter::class ),
$this->createHookContainer()
);
/** @var LinkHolderArray $link */
$link = TestingAccessWrapper::newFromObject( $link );
$parser = $this->createMock( Parser::class );
$parser->method( 'nextLinkID' )->willReturn( 9 );
$link->parent = $parser;
$title = $this->createMock( Title::class );
$title->method( 'getPrefixedDBkey' )->willReturn( 'Talk:Dummy' );
$title->method( 'getNamespace' )->willReturn( 1234 );
$title->method( 'isExternal' )->willReturn( $isExternal );
$this->assertSame( 0, $link->size );
$result = $link->makeHolder(
$title,
'test1 text',
'test2 trail',
'test3 prefix'
);
$this->assertSame( $expected, $result );
$this->assertSame( 1, $link->size );
if ( $isExternal ) {
$this->assertArrayEquals(
[
9 => [
'title' => $title,
'text' => 'test3 prefixtest1 texttest',
'pdbk' => 'Talk:Dummy',
],
],
$link->interwikis
);
$this->assertCount( 0, $link->internals );
} else {
$this->assertArrayEquals(
[
1234 => [
9 => [
'title' => $title,
'text' => 'test3 prefixtest1 texttest',
'pdbk' => 'Talk:Dummy',
],
],
],
$link->internals
);
$this->assertCount( 0, $link->interwikis );
}
}
public function provideMakeHolder_withNsText() {
yield [
false,
'<!--LINK\'" 1234:9-->2 trail',
];
yield [
true,
'<!--IWLINK\'" 9-->2 trail',
];
}
}