50e7985d4d
Squiz.WhiteSpace.LanguageConstructSpacing:
Language constructs must be followed by a single space;
expected "require_once expression" but found
"require_once(expression)"
It is a keyword (e.g. like `new`, `return` and `print`). As
such the parentheses don't make sense.
Per our code conventions, we use a space after keywords like
these. We appeared to have an unwritten exception for `require`
that doesn't make sense. About 60% of require/include usage
was missing the space and/or had superfluous parentheses.
It is as silly as print("foo") or return("foo"), it works
because keywords have no significance for whitespace between
it and the expression that follows, and since experessions can
be wrapped in parentheses for clarity (e.g. when doing string
concatenation or mathematical operations) the parenthesis
before and after basiclaly just ignored.
Change-Id: I2df2f80b8123714bea7e0771bf94b51ad5bb4b87
77 lines
2.1 KiB
PHP
77 lines
2.1 KiB
PHP
<?php
|
|
/**
|
|
* Test JavaScript validity parses using jsmin+'s parser
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @file
|
|
* @ingroup Maintenance
|
|
*/
|
|
|
|
require_once( __DIR__ . '/Maintenance.php' );
|
|
|
|
/**
|
|
* Maintenance script to do test JavaScript validity parses using jsmin+'s parser
|
|
*
|
|
* @ingroup Maintenance
|
|
*/
|
|
class JSParseHelper extends Maintenance {
|
|
public $errs = 0;
|
|
|
|
public function __construct() {
|
|
parent::__construct();
|
|
$this->mDescription = "Runs parsing/syntax checks on JavaScript files";
|
|
$this->addArg( 'file(s)', 'JavaScript file to test', false );
|
|
}
|
|
|
|
public function execute() {
|
|
if ( $this->hasArg() ) {
|
|
$files = $this->mArgs;
|
|
} else {
|
|
$this->maybeHelp( true ); // @todo fixme this is a lame API :)
|
|
exit( 1 ); // it should exit from the above first...
|
|
}
|
|
|
|
$parser = new JSParser();
|
|
foreach ( $files as $filename ) {
|
|
wfSuppressWarnings();
|
|
$js = file_get_contents( $filename );
|
|
wfRestoreWarnings();
|
|
if ( $js === false ) {
|
|
$this->output( "$filename ERROR: could not read file\n" );
|
|
$this->errs++;
|
|
continue;
|
|
}
|
|
|
|
try {
|
|
$parser->parse( $js, $filename, 1 );
|
|
} catch ( Exception $e ) {
|
|
$this->errs++;
|
|
$this->output( "$filename ERROR: " . $e->getMessage() . "\n" );
|
|
continue;
|
|
}
|
|
|
|
$this->output( "$filename OK\n" );
|
|
}
|
|
|
|
if ( $this->errs > 0 ) {
|
|
exit( 1 );
|
|
}
|
|
}
|
|
}
|
|
|
|
$maintClass = "JSParseHelper";
|
|
require_once RUN_MAINTENANCE_IF_MAIN;
|