During development a lot of classes were placed in MediaWiki\Storage\. The precedent set would mean that every class relating to something stored in a database table, plus all related value classes and such, would go into that namespace. Let's put them into MediaWiki\Revision\ instead. Then future classes related to the 'page' table can go into MediaWiki\Page\, future classes related to the 'user' table can go into MediaWiki\User\, and so on. Note I didn't move DerivedPageDataUpdater, PageUpdateException, PageUpdater, or RevisionSlotsUpdate in this patch. If these are kept long-term, they probably belong in MediaWiki\Page\ or MediaWiki\Edit\ instead. Bug: T204158 Change-Id: I16bea8927566a3c73c07e4f4afb3537e05aa04a5
257 lines
8.7 KiB
PHP
257 lines
8.7 KiB
PHP
<?php
|
|
|
|
namespace MediaWiki\Tests\Revision;
|
|
|
|
use InvalidArgumentException;
|
|
use MediaWiki\Revision\RevisionAccessException;
|
|
use MediaWiki\Revision\RevisionSlots;
|
|
use MediaWiki\Revision\SlotRecord;
|
|
use MediaWikiTestCase;
|
|
use TextContent;
|
|
use WikitextContent;
|
|
|
|
class RevisionSlotsTest extends MediaWikiTestCase {
|
|
|
|
/**
|
|
* @param SlotRecord[] $slots
|
|
* @return RevisionSlots
|
|
*/
|
|
protected function newRevisionSlots( $slots = [] ) {
|
|
return new RevisionSlots( $slots );
|
|
}
|
|
|
|
public function provideConstructorFailue() {
|
|
yield 'not an array or callable' => [
|
|
'foo'
|
|
];
|
|
yield 'array of the wrong thing' => [
|
|
[ 1, 2, 3 ]
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @dataProvider provideConstructorFailue
|
|
* @param $slots
|
|
*
|
|
* @covers \MediaWiki\Revision\RevisionSlots::__construct
|
|
* @covers \MediaWiki\Revision\RevisionSlots::setSlotsInternal
|
|
*/
|
|
public function testConstructorFailue( $slots ) {
|
|
$this->setExpectedException( InvalidArgumentException::class );
|
|
|
|
new RevisionSlots( $slots );
|
|
}
|
|
|
|
/**
|
|
* @covers \MediaWiki\Revision\RevisionSlots::getSlot
|
|
*/
|
|
public function testGetSlot() {
|
|
$mainSlot = SlotRecord::newUnsaved( SlotRecord::MAIN, new WikitextContent( 'A' ) );
|
|
$auxSlot = SlotRecord::newUnsaved( 'aux', new WikitextContent( 'B' ) );
|
|
$slots = $this->newRevisionSlots( [ $mainSlot, $auxSlot ] );
|
|
|
|
$this->assertSame( $mainSlot, $slots->getSlot( SlotRecord::MAIN ) );
|
|
$this->assertSame( $auxSlot, $slots->getSlot( 'aux' ) );
|
|
$this->setExpectedException( RevisionAccessException::class );
|
|
$slots->getSlot( 'nothere' );
|
|
}
|
|
|
|
/**
|
|
* @covers \MediaWiki\Revision\RevisionSlots::hasSlot
|
|
*/
|
|
public function testHasSlot() {
|
|
$mainSlot = SlotRecord::newUnsaved( SlotRecord::MAIN, new WikitextContent( 'A' ) );
|
|
$auxSlot = SlotRecord::newUnsaved( 'aux', new WikitextContent( 'B' ) );
|
|
$slots = $this->newRevisionSlots( [ $mainSlot, $auxSlot ] );
|
|
|
|
$this->assertTrue( $slots->hasSlot( SlotRecord::MAIN ) );
|
|
$this->assertTrue( $slots->hasSlot( 'aux' ) );
|
|
$this->assertFalse( $slots->hasSlot( 'AUX' ) );
|
|
$this->assertFalse( $slots->hasSlot( 'xyz' ) );
|
|
}
|
|
|
|
/**
|
|
* @covers \MediaWiki\Revision\RevisionSlots::getContent
|
|
*/
|
|
public function testGetContent() {
|
|
$mainContent = new WikitextContent( 'A' );
|
|
$auxContent = new WikitextContent( 'B' );
|
|
$mainSlot = SlotRecord::newUnsaved( SlotRecord::MAIN, $mainContent );
|
|
$auxSlot = SlotRecord::newUnsaved( 'aux', $auxContent );
|
|
$slots = $this->newRevisionSlots( [ $mainSlot, $auxSlot ] );
|
|
|
|
$this->assertSame( $mainContent, $slots->getContent( SlotRecord::MAIN ) );
|
|
$this->assertSame( $auxContent, $slots->getContent( 'aux' ) );
|
|
$this->setExpectedException( RevisionAccessException::class );
|
|
$slots->getContent( 'nothere' );
|
|
}
|
|
|
|
/**
|
|
* @covers \MediaWiki\Revision\RevisionSlots::getSlotRoles
|
|
*/
|
|
public function testGetSlotRoles_someSlots() {
|
|
$mainSlot = SlotRecord::newUnsaved( SlotRecord::MAIN, new WikitextContent( 'A' ) );
|
|
$auxSlot = SlotRecord::newUnsaved( 'aux', new WikitextContent( 'B' ) );
|
|
$slots = $this->newRevisionSlots( [ $mainSlot, $auxSlot ] );
|
|
|
|
$this->assertSame( [ 'main', 'aux' ], $slots->getSlotRoles() );
|
|
}
|
|
|
|
/**
|
|
* @covers \MediaWiki\Revision\RevisionSlots::getSlotRoles
|
|
*/
|
|
public function testGetSlotRoles_noSlots() {
|
|
$slots = $this->newRevisionSlots( [] );
|
|
|
|
$this->assertSame( [], $slots->getSlotRoles() );
|
|
}
|
|
|
|
/**
|
|
* @covers \MediaWiki\Revision\RevisionSlots::getSlots
|
|
*/
|
|
public function testGetSlots() {
|
|
$mainSlot = SlotRecord::newUnsaved( SlotRecord::MAIN, new WikitextContent( 'A' ) );
|
|
$auxSlot = SlotRecord::newUnsaved( 'aux', new WikitextContent( 'B' ) );
|
|
$slotsArray = [ $mainSlot, $auxSlot ];
|
|
$slots = $this->newRevisionSlots( $slotsArray );
|
|
|
|
$this->assertEquals( [ 'main' => $mainSlot, 'aux' => $auxSlot ], $slots->getSlots() );
|
|
}
|
|
|
|
/**
|
|
* @covers \MediaWiki\Revision\RevisionSlots::getInheritedSlots
|
|
*/
|
|
public function testGetInheritedSlots() {
|
|
$mainSlot = SlotRecord::newUnsaved( SlotRecord::MAIN, new WikitextContent( 'A' ) );
|
|
$auxSlot = SlotRecord::newInherited(
|
|
SlotRecord::newSaved(
|
|
7, 7, 'foo',
|
|
SlotRecord::newUnsaved( 'aux', new WikitextContent( 'B' ) )
|
|
)
|
|
);
|
|
$slotsArray = [ $mainSlot, $auxSlot ];
|
|
$slots = $this->newRevisionSlots( $slotsArray );
|
|
|
|
$this->assertEquals( [ 'aux' => $auxSlot ], $slots->getInheritedSlots() );
|
|
}
|
|
|
|
/**
|
|
* @covers \MediaWiki\Revision\RevisionSlots::getOriginalSlots
|
|
*/
|
|
public function testGetOriginalSlots() {
|
|
$mainSlot = SlotRecord::newUnsaved( SlotRecord::MAIN, new WikitextContent( 'A' ) );
|
|
$auxSlot = SlotRecord::newInherited(
|
|
SlotRecord::newSaved(
|
|
7, 7, 'foo',
|
|
SlotRecord::newUnsaved( 'aux', new WikitextContent( 'B' ) )
|
|
)
|
|
);
|
|
$slotsArray = [ $mainSlot, $auxSlot ];
|
|
$slots = $this->newRevisionSlots( $slotsArray );
|
|
|
|
$this->assertEquals( [ 'main' => $mainSlot ], $slots->getOriginalSlots() );
|
|
}
|
|
|
|
public function provideComputeSize() {
|
|
yield [ 1, [ 'A' ] ];
|
|
yield [ 2, [ 'AA' ] ];
|
|
yield [ 4, [ 'AA', 'X', 'H' ] ];
|
|
}
|
|
|
|
/**
|
|
* @dataProvider provideComputeSize
|
|
* @covers \MediaWiki\Revision\RevisionSlots::computeSize
|
|
*/
|
|
public function testComputeSize( $expected, $contentStrings ) {
|
|
$slotsArray = [];
|
|
foreach ( $contentStrings as $key => $contentString ) {
|
|
$slotsArray[] = SlotRecord::newUnsaved( strval( $key ), new WikitextContent( $contentString ) );
|
|
}
|
|
$slots = $this->newRevisionSlots( $slotsArray );
|
|
|
|
$this->assertSame( $expected, $slots->computeSize() );
|
|
}
|
|
|
|
public function provideComputeSha1() {
|
|
yield [ 'ctqm7794fr2dp1taki8a88ovwnvmnmj', [ 'A' ] ];
|
|
yield [ 'eyq8wiwlcofnaiy4eid97gyfy60uw51', [ 'AA' ] ];
|
|
yield [ 'lavctqfpxartyjr31f853drgfl4kj1g', [ 'AA', 'X', 'H' ] ];
|
|
}
|
|
|
|
/**
|
|
* @dataProvider provideComputeSha1
|
|
* @covers \MediaWiki\Revision\RevisionSlots::computeSha1
|
|
* @note this test is a bit brittle as the hashes are hardcoded, perhaps just check that strings
|
|
* are returned and different Slots objects return different strings?
|
|
*/
|
|
public function testComputeSha1( $expected, $contentStrings ) {
|
|
$slotsArray = [];
|
|
foreach ( $contentStrings as $key => $contentString ) {
|
|
$slotsArray[] = SlotRecord::newUnsaved( strval( $key ), new WikitextContent( $contentString ) );
|
|
}
|
|
$slots = $this->newRevisionSlots( $slotsArray );
|
|
|
|
$this->assertSame( $expected, $slots->computeSha1() );
|
|
}
|
|
|
|
public function provideHasSameContent() {
|
|
$fooX = SlotRecord::newUnsaved( 'x', new TextContent( 'Foo' ) );
|
|
$barZ = SlotRecord::newUnsaved( 'z', new TextContent( 'Bar' ) );
|
|
$fooY = SlotRecord::newUnsaved( 'y', new TextContent( 'Foo' ) );
|
|
$barZS = SlotRecord::newSaved( 7, 7, 'xyz', $barZ );
|
|
$barZ2 = SlotRecord::newUnsaved( 'z', new TextContent( 'Baz' ) );
|
|
|
|
$a = $this->newRevisionSlots( [ 'x' => $fooX, 'z' => $barZ ] );
|
|
$a2 = $this->newRevisionSlots( [ 'x' => $fooX, 'z' => $barZ ] );
|
|
$a3 = $this->newRevisionSlots( [ 'x' => $fooX, 'z' => $barZS ] );
|
|
$b = $this->newRevisionSlots( [ 'y' => $fooY, 'z' => $barZ ] );
|
|
$c = $this->newRevisionSlots( [ 'x' => $fooX, 'z' => $barZ2 ] );
|
|
|
|
yield 'same instance' => [ $a, $a, true ];
|
|
yield 'same slots' => [ $a, $a2, true ];
|
|
yield 'same content' => [ $a, $a3, true ];
|
|
|
|
yield 'different roles' => [ $a, $b, false ];
|
|
yield 'different content' => [ $a, $c, false ];
|
|
}
|
|
|
|
/**
|
|
* @dataProvider provideHasSameContent
|
|
* @covers \MediaWiki\Revision\RevisionSlots::hasSameContent
|
|
*/
|
|
public function testHasSameContent( RevisionSlots $a, RevisionSlots $b, $same ) {
|
|
$this->assertSame( $same, $a->hasSameContent( $b ) );
|
|
$this->assertSame( $same, $b->hasSameContent( $a ) );
|
|
}
|
|
|
|
public function provideGetRolesWithDifferentContent() {
|
|
$fooX = SlotRecord::newUnsaved( 'x', new TextContent( 'Foo' ) );
|
|
$barZ = SlotRecord::newUnsaved( 'z', new TextContent( 'Bar' ) );
|
|
$fooY = SlotRecord::newUnsaved( 'y', new TextContent( 'Foo' ) );
|
|
$barZS = SlotRecord::newSaved( 7, 7, 'xyz', $barZ );
|
|
$barZ2 = SlotRecord::newUnsaved( 'z', new TextContent( 'Baz' ) );
|
|
|
|
$a = $this->newRevisionSlots( [ 'x' => $fooX, 'z' => $barZ ] );
|
|
$a2 = $this->newRevisionSlots( [ 'x' => $fooX, 'z' => $barZ ] );
|
|
$a3 = $this->newRevisionSlots( [ 'x' => $fooX, 'z' => $barZS ] );
|
|
$b = $this->newRevisionSlots( [ 'y' => $fooY, 'z' => $barZ ] );
|
|
$c = $this->newRevisionSlots( [ 'x' => $fooX, 'z' => $barZ2 ] );
|
|
|
|
yield 'same instance' => [ $a, $a, [] ];
|
|
yield 'same slots' => [ $a, $a2, [] ];
|
|
yield 'same content' => [ $a, $a3, [] ];
|
|
|
|
yield 'different roles' => [ $a, $b, [ 'x', 'y' ] ];
|
|
yield 'different content' => [ $a, $c, [ 'z' ] ];
|
|
}
|
|
|
|
/**
|
|
* @dataProvider provideGetRolesWithDifferentContent
|
|
* @covers \MediaWiki\Revision\RevisionSlots::getRolesWithDifferentContent
|
|
*/
|
|
public function testGetRolesWithDifferentContent( RevisionSlots $a, RevisionSlots $b, $roles ) {
|
|
$this->assertArrayEquals( $roles, $a->getRolesWithDifferentContent( $b ) );
|
|
$this->assertArrayEquals( $roles, $b->getRolesWithDifferentContent( $a ) );
|
|
}
|
|
|
|
}
|