The default will remain PHPUnit 4.x due to PHP 5.5 support. But, we should allow developers to run tests with newer PHPUnit versions which are noticably faster (especially for code coverage reports). * <https://github.com/sebastianbergmann/phpunit/wiki/Release-Announcement-for-PHPUnit-5.4.0> PHPUnit 5 deprecates the getMock() shortcut for getMockBuilder()->getMock(). It instead introduces the shortcut createMock() which has better defaults than getMockBuilder(). For example, it sets 'disableArgumentCloning' and other things by default. Going forward, code should either use getMockBuilder directly and configure it using the setter methods (instead of the confusing variadic arguments of getMock) or simply use the new minimalistic createMock method. This patch backports the createMock method to MediaWikiTestCase so that we can start using it. Change-Id: I091c0289b21d2b1c876adba89529dc3e72b99af2
257 lines
8 KiB
PHP
257 lines
8 KiB
PHP
<?php
|
||
|
||
/**
|
||
* @group Search
|
||
* @group Database
|
||
*
|
||
* @covers SearchEngine<extended>
|
||
* @note Coverage will only ever show one of on of the Search* classes
|
||
*/
|
||
class SearchEngineTest extends MediaWikiLangTestCase {
|
||
|
||
/**
|
||
* @var SearchEngine
|
||
*/
|
||
protected $search;
|
||
|
||
/**
|
||
* Checks for database type & version.
|
||
* Will skip current test if DB does not support search.
|
||
*/
|
||
protected function setUp() {
|
||
parent::setUp();
|
||
|
||
// Search tests require MySQL or SQLite with FTS
|
||
$dbType = $this->db->getType();
|
||
$dbSupported = ( $dbType === 'mysql' )
|
||
|| ( $dbType === 'sqlite' && $this->db->getFulltextSearchModule() == 'FTS3' );
|
||
|
||
if ( !$dbSupported ) {
|
||
$this->markTestSkipped( "MySQL or SQLite with FTS3 only" );
|
||
}
|
||
|
||
$searchType = SearchEngineFactory::getSearchEngineClass( $this->db );
|
||
$this->setMwGlobals( [
|
||
'wgSearchType' => $searchType
|
||
] );
|
||
|
||
$this->search = new $searchType( $this->db );
|
||
}
|
||
|
||
protected function tearDown() {
|
||
unset( $this->search );
|
||
|
||
parent::tearDown();
|
||
}
|
||
|
||
public function addDBDataOnce() {
|
||
if ( !$this->isWikitextNS( NS_MAIN ) ) {
|
||
// @todo cover the case of non-wikitext content in the main namespace
|
||
return;
|
||
}
|
||
|
||
// Reset the search type back to default - some extensions may have
|
||
// overridden it.
|
||
$this->setMwGlobals( [ 'wgSearchType' => null ] );
|
||
|
||
$this->insertPage( 'Not_Main_Page', 'This is not a main page' );
|
||
$this->insertPage(
|
||
'Talk:Not_Main_Page',
|
||
'This is not a talk page to the main page, see [[smithee]]'
|
||
);
|
||
$this->insertPage( 'Smithee', 'A smithee is one who smiths. See also [[Alan Smithee]]' );
|
||
$this->insertPage( 'Talk:Smithee', 'This article sucks.' );
|
||
$this->insertPage( 'Unrelated_page', 'Nothing in this page is about the S word.' );
|
||
$this->insertPage( 'Another_page', 'This page also is unrelated.' );
|
||
$this->insertPage( 'Help:Help', 'Help me!' );
|
||
$this->insertPage( 'Thppt', 'Blah blah' );
|
||
$this->insertPage( 'Alan_Smithee', 'yum' );
|
||
$this->insertPage( 'Pages', 'are\'food' );
|
||
$this->insertPage( 'HalfOneUp', 'AZ' );
|
||
$this->insertPage( 'FullOneUp', 'AZ' );
|
||
$this->insertPage( 'HalfTwoLow', 'az' );
|
||
$this->insertPage( 'FullTwoLow', 'az' );
|
||
$this->insertPage( 'HalfNumbers', '1234567890' );
|
||
$this->insertPage( 'FullNumbers', '1234567890' );
|
||
$this->insertPage( 'DomainName', 'example.com' );
|
||
}
|
||
|
||
protected function fetchIds( $results ) {
|
||
if ( !$this->isWikitextNS( NS_MAIN ) ) {
|
||
$this->markTestIncomplete( __CLASS__ . " does no yet support non-wikitext content "
|
||
. "in the main namespace" );
|
||
}
|
||
$this->assertTrue( is_object( $results ) );
|
||
|
||
$matches = [];
|
||
$row = $results->next();
|
||
while ( $row ) {
|
||
$matches[] = $row->getTitle()->getPrefixedText();
|
||
$row = $results->next();
|
||
}
|
||
$results->free();
|
||
# Search is not guaranteed to return results in a certain order;
|
||
# sort them numerically so we will compare simply that we received
|
||
# the expected matches.
|
||
sort( $matches );
|
||
|
||
return $matches;
|
||
}
|
||
|
||
public function testFullWidth() {
|
||
$this->assertEquals(
|
||
[ 'FullOneUp', 'FullTwoLow', 'HalfOneUp', 'HalfTwoLow' ],
|
||
$this->fetchIds( $this->search->searchText( 'AZ' ) ),
|
||
"Search for normalized from Half-width Upper" );
|
||
$this->assertEquals(
|
||
[ 'FullOneUp', 'FullTwoLow', 'HalfOneUp', 'HalfTwoLow' ],
|
||
$this->fetchIds( $this->search->searchText( 'az' ) ),
|
||
"Search for normalized from Half-width Lower" );
|
||
$this->assertEquals(
|
||
[ 'FullOneUp', 'FullTwoLow', 'HalfOneUp', 'HalfTwoLow' ],
|
||
$this->fetchIds( $this->search->searchText( 'AZ' ) ),
|
||
"Search for normalized from Full-width Upper" );
|
||
$this->assertEquals(
|
||
[ 'FullOneUp', 'FullTwoLow', 'HalfOneUp', 'HalfTwoLow' ],
|
||
$this->fetchIds( $this->search->searchText( 'az' ) ),
|
||
"Search for normalized from Full-width Lower" );
|
||
}
|
||
|
||
public function testTextSearch() {
|
||
$this->assertEquals(
|
||
[ 'Smithee' ],
|
||
$this->fetchIds( $this->search->searchText( 'smithee' ) ),
|
||
"Plain search failed" );
|
||
}
|
||
|
||
public function testTextPowerSearch() {
|
||
$this->search->setNamespaces( [ 0, 1, 4 ] );
|
||
$this->assertEquals(
|
||
[
|
||
'Smithee',
|
||
'Talk:Not Main Page',
|
||
],
|
||
$this->fetchIds( $this->search->searchText( 'smithee' ) ),
|
||
"Power search failed" );
|
||
}
|
||
|
||
public function testTitleSearch() {
|
||
$this->assertEquals(
|
||
[
|
||
'Alan Smithee',
|
||
'Smithee',
|
||
],
|
||
$this->fetchIds( $this->search->searchTitle( 'smithee' ) ),
|
||
"Title search failed" );
|
||
}
|
||
|
||
public function testTextTitlePowerSearch() {
|
||
$this->search->setNamespaces( [ 0, 1, 4 ] );
|
||
$this->assertEquals(
|
||
[
|
||
'Alan Smithee',
|
||
'Smithee',
|
||
'Talk:Smithee',
|
||
],
|
||
$this->fetchIds( $this->search->searchTitle( 'smithee' ) ),
|
||
"Title power search failed" );
|
||
}
|
||
|
||
/**
|
||
* @covers SearchEngine::getSearchIndexFields
|
||
*/
|
||
public function testSearchIndexFields() {
|
||
/**
|
||
* @var $mockEngine SearchEngine
|
||
*/
|
||
$mockEngine = $this->getMockBuilder( 'SearchEngine' )
|
||
->setMethods( [ 'makeSearchFieldMapping' ] )->getMock();
|
||
|
||
$mockFieldBuilder = function ( $name, $type ) {
|
||
$mockField =
|
||
$this->getMockBuilder( 'SearchIndexFieldDefinition' )->setConstructorArgs( [
|
||
$name,
|
||
$type
|
||
] )->getMock();
|
||
|
||
$mockField->expects( $this->any() )->method( 'getMapping' )->willReturn( [
|
||
'testData' => 'test',
|
||
'name' => $name,
|
||
'type' => $type,
|
||
] );
|
||
|
||
$mockField->expects( $this->any() )
|
||
->method( 'merge' )
|
||
->willReturn( $mockField );
|
||
|
||
return $mockField;
|
||
};
|
||
|
||
$mockEngine->expects( $this->atLeastOnce() )
|
||
->method( 'makeSearchFieldMapping' )
|
||
->willReturnCallback( $mockFieldBuilder );
|
||
|
||
// Not using mock since PHPUnit mocks do not work properly with references in params
|
||
$this->setTemporaryHook( 'SearchIndexFields',
|
||
function ( &$fields, SearchEngine $engine ) use ( $mockFieldBuilder ) {
|
||
$fields['testField'] =
|
||
$mockFieldBuilder( "testField", SearchIndexField::INDEX_TYPE_TEXT );
|
||
return true;
|
||
} );
|
||
|
||
$fields = $mockEngine->getSearchIndexFields();
|
||
$this->assertArrayHasKey( 'language', $fields );
|
||
$this->assertArrayHasKey( 'category', $fields );
|
||
$this->assertInstanceOf( 'SearchIndexField', $fields['testField'] );
|
||
|
||
$mapping = $fields['testField']->getMapping( $mockEngine );
|
||
$this->assertArrayHasKey( 'testData', $mapping );
|
||
$this->assertEquals( 'test', $mapping['testData'] );
|
||
}
|
||
|
||
public function hookSearchIndexFields( $mockFieldBuilder, &$fields, SearchEngine $engine ) {
|
||
$fields['testField'] = $mockFieldBuilder( "testField", SearchIndexField::INDEX_TYPE_TEXT );
|
||
return true;
|
||
}
|
||
|
||
public function testAugmentorSearch() {
|
||
$this->search->setNamespaces( [ 0, 1, 4 ] );
|
||
$resultSet = $this->search->searchText( 'smithee' );
|
||
// Not using mock since PHPUnit mocks do not work properly with references in params
|
||
$this->mergeMwGlobalArrayValue( 'wgHooks',
|
||
[ 'SearchResultsAugment' => [ [ $this, 'addAugmentors' ] ] ] );
|
||
$this->search->augmentSearchResults( $resultSet );
|
||
for ( $result = $resultSet->next(); $result; $result = $resultSet->next() ) {
|
||
$id = $result->getTitle()->getArticleID();
|
||
$augmentData = "Result:$id:" . $result->getTitle()->getText();
|
||
$augmentData2 = "Result2:$id:" . $result->getTitle()->getText();
|
||
$this->assertEquals( [ 'testSet' => $augmentData, 'testRow' => $augmentData2 ],
|
||
$result->getExtensionData() );
|
||
}
|
||
}
|
||
|
||
public function addAugmentors( &$setAugmentors, &$rowAugmentors ) {
|
||
$setAugmentor = $this->createMock( 'ResultSetAugmentor' );
|
||
$setAugmentor->expects( $this->once() )
|
||
->method( 'augmentAll' )
|
||
->willReturnCallback( function ( SearchResultSet $resultSet ) {
|
||
$data = [];
|
||
for ( $result = $resultSet->next(); $result; $result = $resultSet->next() ) {
|
||
$id = $result->getTitle()->getArticleID();
|
||
$data[$id] = "Result:$id:" . $result->getTitle()->getText();
|
||
}
|
||
$resultSet->rewind();
|
||
return $data;
|
||
} );
|
||
$setAugmentors['testSet'] = $setAugmentor;
|
||
|
||
$rowAugmentor = $this->createMock( 'ResultAugmentor' );
|
||
$rowAugmentor->expects( $this->exactly( 2 ) )
|
||
->method( 'augment' )
|
||
->willReturnCallback( function ( SearchResult $result ) {
|
||
$id = $result->getTitle()->getArticleID();
|
||
return "Result2:$id:" . $result->getTitle()->getText();
|
||
} );
|
||
$rowAugmentors['testRow'] = $rowAugmentor;
|
||
}
|
||
}
|