A provider that uses SessionProvider::hashToSessionId() will likely have issues if something such as a call to $user->setToken() causes SessionManager::loadSessionInfoFromStore() to fail, since the provider can't just arbitrarily change the session ID it returns. The two solutions to this problem are: * Somehow include everything that could cause loadSessionInfoFromStore to fail in the data hashed by hashToSessionId. * Flag the SessionInfo so that, if stored data and the SessionInfo conflict, it should delete the stored data instead of discarding the SessionInfo. Since the second is less complexity overall due to the lack of need to define "everything", this patch takes that approach. Change-Id: I8c6fab2ec295e71242bbcb19d0ee5ade6bd655df
286 lines
7.9 KiB
PHP
286 lines
7.9 KiB
PHP
<?php
|
|
/**
|
|
* MediaWiki session info
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @file
|
|
* @ingroup Session
|
|
*/
|
|
|
|
namespace MediaWiki\Session;
|
|
|
|
/**
|
|
* Value object returned by SessionProvider
|
|
*
|
|
* This holds the data necessary to construct a Session.
|
|
*
|
|
* @ingroup Session
|
|
* @since 1.27
|
|
*/
|
|
class SessionInfo {
|
|
/** Minimum allowed priority */
|
|
const MIN_PRIORITY = 1;
|
|
|
|
/** Maximum allowed priority */
|
|
const MAX_PRIORITY = 100;
|
|
|
|
/** @var SessionProvider|null */
|
|
private $provider;
|
|
|
|
/** @var string */
|
|
private $id;
|
|
|
|
/** @var int */
|
|
private $priority;
|
|
|
|
/** @var UserInfo|null */
|
|
private $userInfo = null;
|
|
|
|
private $persisted = false;
|
|
private $remembered = false;
|
|
private $forceHTTPS = false;
|
|
private $idIsSafe = false;
|
|
private $forceUse = false;
|
|
|
|
/** @var array|null */
|
|
private $providerMetadata = null;
|
|
|
|
/**
|
|
* @param int $priority Session priority
|
|
* @param array $data
|
|
* - provider: (SessionProvider|null) If not given, the provider will be
|
|
* determined from the saved session data.
|
|
* - id: (string|null) Session ID
|
|
* - userInfo: (UserInfo|null) User known from the request. If
|
|
* $provider->canChangeUser() is false, a verified user
|
|
* must be provided.
|
|
* - persisted: (bool) Whether this session was persisted
|
|
* - remembered: (bool) Whether the verified user was remembered.
|
|
* Defaults to true.
|
|
* - forceHTTPS: (bool) Whether to force HTTPS for this session
|
|
* - metadata: (array) Provider metadata, to be returned by
|
|
* Session::getProviderMetadata().
|
|
* - idIsSafe: (bool) Set true if the 'id' did not come from the user.
|
|
* Generally you'll use this from SessionProvider::newEmptySession(),
|
|
* and not from any other method.
|
|
* - forceUse: (bool) Set true if the 'id' is from
|
|
* SessionProvider::hashToSessionId() to delete conflicting session
|
|
* store data instead of discarding this SessionInfo. Ignored unless
|
|
* both 'provider' and 'id' are given.
|
|
* - copyFrom: (SessionInfo) SessionInfo to copy other data items from.
|
|
*/
|
|
public function __construct( $priority, array $data ) {
|
|
if ( $priority < self::MIN_PRIORITY || $priority > self::MAX_PRIORITY ) {
|
|
throw new \InvalidArgumentException( 'Invalid priority' );
|
|
}
|
|
|
|
if ( isset( $data['copyFrom'] ) ) {
|
|
$from = $data['copyFrom'];
|
|
if ( !$from instanceof SessionInfo ) {
|
|
throw new \InvalidArgumentException( 'Invalid copyFrom' );
|
|
}
|
|
$data += [
|
|
'provider' => $from->provider,
|
|
'id' => $from->id,
|
|
'userInfo' => $from->userInfo,
|
|
'persisted' => $from->persisted,
|
|
'remembered' => $from->remembered,
|
|
'forceHTTPS' => $from->forceHTTPS,
|
|
'metadata' => $from->providerMetadata,
|
|
'idIsSafe' => $from->idIsSafe,
|
|
'forceUse' => $from->forceUse,
|
|
// @codeCoverageIgnoreStart
|
|
];
|
|
// @codeCoverageIgnoreEnd
|
|
} else {
|
|
$data += [
|
|
'provider' => null,
|
|
'id' => null,
|
|
'userInfo' => null,
|
|
'persisted' => false,
|
|
'remembered' => true,
|
|
'forceHTTPS' => false,
|
|
'metadata' => null,
|
|
'idIsSafe' => false,
|
|
'forceUse' => false,
|
|
// @codeCoverageIgnoreStart
|
|
];
|
|
// @codeCoverageIgnoreEnd
|
|
}
|
|
|
|
if ( $data['id'] !== null && !SessionManager::validateSessionId( $data['id'] ) ) {
|
|
throw new \InvalidArgumentException( 'Invalid session ID' );
|
|
}
|
|
|
|
if ( $data['userInfo'] !== null && !$data['userInfo'] instanceof UserInfo ) {
|
|
throw new \InvalidArgumentException( 'Invalid userInfo' );
|
|
}
|
|
|
|
if ( !$data['provider'] && $data['id'] === null ) {
|
|
throw new \InvalidArgumentException(
|
|
'Must supply an ID when no provider is given'
|
|
);
|
|
}
|
|
|
|
if ( $data['metadata'] !== null && !is_array( $data['metadata'] ) ) {
|
|
throw new \InvalidArgumentException( 'Invalid metadata' );
|
|
}
|
|
|
|
$this->provider = $data['provider'];
|
|
if ( $data['id'] !== null ) {
|
|
$this->id = $data['id'];
|
|
$this->idIsSafe = $data['idIsSafe'];
|
|
$this->forceUse = $data['forceUse'] && $this->provider;
|
|
} else {
|
|
$this->id = $this->provider->getManager()->generateSessionId();
|
|
$this->idIsSafe = true;
|
|
$this->forceUse = false;
|
|
}
|
|
$this->priority = (int)$priority;
|
|
$this->userInfo = $data['userInfo'];
|
|
$this->persisted = (bool)$data['persisted'];
|
|
if ( $data['provider'] !== null ) {
|
|
if ( $this->userInfo !== null && !$this->userInfo->isAnon() && $this->userInfo->isVerified() ) {
|
|
$this->remembered = (bool)$data['remembered'];
|
|
}
|
|
$this->providerMetadata = $data['metadata'];
|
|
}
|
|
$this->forceHTTPS = (bool)$data['forceHTTPS'];
|
|
}
|
|
|
|
/**
|
|
* Return the provider
|
|
* @return SessionProvider|null
|
|
*/
|
|
final public function getProvider() {
|
|
return $this->provider;
|
|
}
|
|
|
|
/**
|
|
* Return the session ID
|
|
* @return string
|
|
*/
|
|
final public function getId() {
|
|
return $this->id;
|
|
}
|
|
|
|
/**
|
|
* Indicate whether the ID is "safe"
|
|
*
|
|
* The ID is safe in the following cases:
|
|
* - The ID was randomly generated by the constructor.
|
|
* - The ID was found in the backend data store.
|
|
* - $this->getProvider()->persistsSessionId() is false.
|
|
* - The constructor was explicitly told it's safe using the 'idIsSafe'
|
|
* parameter.
|
|
*
|
|
* @return bool
|
|
*/
|
|
final public function isIdSafe() {
|
|
return $this->idIsSafe;
|
|
}
|
|
|
|
/**
|
|
* Force use of this SessionInfo if validation fails
|
|
*
|
|
* The normal behavior is to discard the SessionInfo if validation against
|
|
* the data stored in the session store fails. If this returns true,
|
|
* SessionManager will instead delete the session store data so this
|
|
* SessionInfo may still be used.
|
|
*
|
|
* @return bool
|
|
*/
|
|
final public function forceUse() {
|
|
return $this->forceUse;
|
|
}
|
|
|
|
/**
|
|
* Return the priority
|
|
* @return int
|
|
*/
|
|
final public function getPriority() {
|
|
return $this->priority;
|
|
}
|
|
|
|
/**
|
|
* Return the user
|
|
* @return UserInfo|null
|
|
*/
|
|
final public function getUserInfo() {
|
|
return $this->userInfo;
|
|
}
|
|
|
|
/**
|
|
* Return whether the session is persisted
|
|
* @return bool
|
|
*/
|
|
final public function wasPersisted() {
|
|
return $this->persisted;
|
|
}
|
|
|
|
/**
|
|
* Return provider metadata
|
|
* @return array|null
|
|
*/
|
|
final public function getProviderMetadata() {
|
|
return $this->providerMetadata;
|
|
}
|
|
|
|
/**
|
|
* Return whether the user was remembered
|
|
*
|
|
* For providers that can persist the user separately from the session,
|
|
* the human using it may not actually *want* that to be done. For example,
|
|
* a cookie-based provider can set cookies that are longer-lived than the
|
|
* backend session data, but on a public terminal the human likely doesn't
|
|
* want those cookies set.
|
|
*
|
|
* This is false unless a non-anonymous verified user was passed to
|
|
* the SessionInfo constructor by the provider, and the provider didn't
|
|
* pass false for the 'remembered' data item.
|
|
*
|
|
* @return bool
|
|
*/
|
|
final public function wasRemembered() {
|
|
return $this->remembered;
|
|
}
|
|
|
|
/**
|
|
* Whether this session should only be used over HTTPS
|
|
* @return bool
|
|
*/
|
|
final public function forceHTTPS() {
|
|
return $this->forceHTTPS;
|
|
}
|
|
|
|
public function __toString() {
|
|
return '[' . $this->getPriority() . ']' .
|
|
( $this->getProvider() ?: 'null' ) .
|
|
( $this->userInfo ?: '<null>' ) . $this->getId();
|
|
}
|
|
|
|
/**
|
|
* Compare two SessionInfo objects by priority
|
|
* @param SessionInfo $a
|
|
* @param SessionInfo $b
|
|
* @return int Negative if $a < $b, positive if $a > $b, zero if equal
|
|
*/
|
|
public static function compare( $a, $b ) {
|
|
return $a->getPriority() - $b->getPriority();
|
|
}
|
|
|
|
}
|