The service locator, MediaWikiServices, is intended to facilitate "manual" dependency injection in static entry points. See also the Dependency Injection RFC T384 and Service Locator RFC T124792 for details. The following key points were implemented according the discussion surrounding these RFCs: * a configurable DI container that allows extensions to add and replace services. * no auto-wiring, since it's prone to add confusion in large and complex applications. * no 3rd party framework, since they typically do too much. The following services in MediaWiki core are made accessible via the service locator mechanism to showcase the bootstrapping mechanism: * ConfigFactory and MainConfig * SiteLookup and SiteStore However, the implementation of these services was not yet converted to using proper DI throughout the code. Bug: T124792 Change-Id: I3c25c0ac17300d3dd13e1cf5100558a605eee15f
166 lines
4.4 KiB
PHP
166 lines
4.4 KiB
PHP
<?php
|
|
|
|
/**
|
|
* Tests for the DBSiteStore class.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @file
|
|
* @since 1.21
|
|
*
|
|
* @ingroup Site
|
|
* @ingroup Test
|
|
*
|
|
* @group Site
|
|
* @group Database
|
|
*
|
|
* @author Jeroen De Dauw < jeroendedauw@gmail.com >
|
|
*/
|
|
class DBSiteStoreTest extends MediaWikiTestCase {
|
|
|
|
/**
|
|
* @return DBSiteStore
|
|
*/
|
|
private function newDBSiteStore() {
|
|
// NOTE: Use the real DB load balancer for now. Eventually, the test framework should
|
|
// provide a LoadBalancer that is safe to use in unit tests.
|
|
return new DBSiteStore( wfGetLB() );
|
|
}
|
|
|
|
/**
|
|
* @covers DBSiteStore::getSites
|
|
*/
|
|
public function testGetSites() {
|
|
$expectedSites = TestSites::getSites();
|
|
TestSites::insertIntoDb();
|
|
|
|
$store = $this->newDBSiteStore();
|
|
|
|
$sites = $store->getSites();
|
|
|
|
$this->assertInstanceOf( 'SiteList', $sites );
|
|
|
|
/**
|
|
* @var Site $site
|
|
*/
|
|
foreach ( $sites as $site ) {
|
|
$this->assertInstanceOf( 'Site', $site );
|
|
}
|
|
|
|
foreach ( $expectedSites as $site ) {
|
|
if ( $site->getGlobalId() !== null ) {
|
|
$this->assertTrue( $sites->hasSite( $site->getGlobalId() ) );
|
|
}
|
|
}
|
|
}
|
|
|
|
/**
|
|
* @covers DBSiteStore::saveSites
|
|
*/
|
|
public function testSaveSites() {
|
|
$store = $this->newDBSiteStore();
|
|
|
|
$sites = [];
|
|
|
|
$site = new Site();
|
|
$site->setGlobalId( 'ertrywuutr' );
|
|
$site->setLanguageCode( 'en' );
|
|
$sites[] = $site;
|
|
|
|
$site = new MediaWikiSite();
|
|
$site->setGlobalId( 'sdfhxujgkfpth' );
|
|
$site->setLanguageCode( 'nl' );
|
|
$sites[] = $site;
|
|
|
|
$this->assertTrue( $store->saveSites( $sites ) );
|
|
|
|
$site = $store->getSite( 'ertrywuutr' );
|
|
$this->assertInstanceOf( 'Site', $site );
|
|
$this->assertEquals( 'en', $site->getLanguageCode() );
|
|
$this->assertTrue( is_integer( $site->getInternalId() ) );
|
|
$this->assertTrue( $site->getInternalId() >= 0 );
|
|
|
|
$site = $store->getSite( 'sdfhxujgkfpth' );
|
|
$this->assertInstanceOf( 'Site', $site );
|
|
$this->assertEquals( 'nl', $site->getLanguageCode() );
|
|
$this->assertTrue( is_integer( $site->getInternalId() ) );
|
|
$this->assertTrue( $site->getInternalId() >= 0 );
|
|
}
|
|
|
|
/**
|
|
* @covers DBSiteStore::reset
|
|
*/
|
|
public function testReset() {
|
|
$store1 = $this->newDBSiteStore();
|
|
$store2 = $this->newDBSiteStore();
|
|
|
|
// initialize internal cache
|
|
$this->assertGreaterThan( 0, $store1->getSites()->count() );
|
|
$this->assertGreaterThan( 0, $store2->getSites()->count() );
|
|
|
|
// Clear actual data. Will purge the external cache and reset the internal
|
|
// cache in $store1, but not the internal cache in store2.
|
|
$this->assertTrue( $store1->clear() );
|
|
|
|
// sanity check: $store2 should have a stale cache now
|
|
$this->assertNotNull( $store2->getSite( 'enwiki' ) );
|
|
|
|
// purge cache
|
|
$store2->reset();
|
|
|
|
// ...now the internal cache of $store2 should be updated and thus empty.
|
|
$site = $store2->getSite( 'enwiki' );
|
|
$this->assertNull( $site );
|
|
}
|
|
|
|
/**
|
|
* @covers DBSiteStore::clear
|
|
*/
|
|
public function testClear() {
|
|
$store = $this->newDBSiteStore();
|
|
$this->assertTrue( $store->clear() );
|
|
|
|
$site = $store->getSite( 'enwiki' );
|
|
$this->assertNull( $site );
|
|
|
|
$sites = $store->getSites();
|
|
$this->assertEquals( 0, $sites->count() );
|
|
}
|
|
|
|
/**
|
|
* @covers DBSiteStore::getSites
|
|
*/
|
|
public function testGetSitesDefaultOrder() {
|
|
$store = $this->newDBSiteStore();
|
|
$siteB = new Site();
|
|
$siteB->setGlobalId( 'B' );
|
|
$siteA = new Site();
|
|
$siteA->setGlobalId( 'A' );
|
|
$store->saveSites( [ $siteB, $siteA ] );
|
|
|
|
$sites = $store->getSites();
|
|
$siteIdentifiers = [];
|
|
/** @var Site $site */
|
|
foreach ( $sites as $site ) {
|
|
$siteIdentifiers[] = $site->getGlobalId();
|
|
}
|
|
$this->assertSame( [ 'A', 'B' ], $siteIdentifiers );
|
|
|
|
// Note: SiteList::getGlobalIdentifiers uses an other internal state. Iteration must be
|
|
// tested separately.
|
|
$this->assertSame( [ 'A', 'B' ], $sites->getGlobalIdentifiers() );
|
|
}
|
|
}
|