This issue came up in I8a49143, see https://integration.wikimedia.org/ci/job/mediawiki-quibble-vendor-postgres-php70-docker/2453/console The third parameter of assertArrayEquals() is called $ordered and is meant to take the order of elements into account. Providing a string sets this to true. The SQL query in ChangesListSpecialPageTest seems to behave a bit random in Postgres and does not always return the elements in the same order. This is fine. It's just the assertion that was to strict, by accident. I found a few more instances of the same issue with a regular expression. In most cases I intentionally changed it to assertSame() because the order of elements is actually guaranteed by the code, and needs to be (e.g. mixing width and height of an image would be fatal). Change-Id: Ice66cab873a7271d55809a486ce28cf637e43e33 |
||
|---|---|---|
| .. | ||
| ApiPrefixUniquenessTest.php | ||
| ApiStructureTest.php | ||
| AutoLoaderStructureTest.php | ||
| AvailableRightsTest.php | ||
| ContentHandlerSanityTest.php | ||
| DatabaseIntegrationTest.php | ||
| ExtensionJsonValidationTest.php | ||
| PasswordPolicyStructureTest.php | ||
| ResourcesTest.php | ||
| SpecialPageFatalTest.php | ||
| StructureTest.php | ||