62cfede3fa
Follow-up to 298ec8382b, which replaced
`public $errors` with `public $status`, causing T372181.
* Add a deprecated fallback getter/setter for $errors
* Make $permission private and add a deprecated getter/setter
* Make $status private
Bug: T372181
Change-Id: If44b2256289d6bde9e9abb901d9dc145555c971f
64 lines
1.9 KiB
PHP
64 lines
1.9 KiB
PHP
<?php
|
|
|
|
use MediaWiki\Message\Message;
|
|
use MediaWiki\Permissions\PermissionStatus;
|
|
use Wikimedia\TestingAccessWrapper;
|
|
|
|
/**
|
|
* @covers \PermissionsError
|
|
*/
|
|
class PermissionsErrorTest extends MediaWikiIntegrationTestCase {
|
|
|
|
protected function setUp(): void {
|
|
parent::setUp();
|
|
$this->setGroupPermissions( '*', 'testpermission', true );
|
|
}
|
|
|
|
public static function provideConstruction() {
|
|
$status = new PermissionStatus();
|
|
$status->error( 'cat', 1, 2 );
|
|
$status->error( 'dog', 3, 4 );
|
|
$array = [ [ 'cat', 1, 2 ], [ 'dog', 3, 4 ] ];
|
|
yield [ null, $status, $status ];
|
|
yield [ null, $array, $status ];
|
|
yield [ 'testpermission', $status, $status ];
|
|
yield [ 'testpermission', $array, $status ];
|
|
|
|
yield [ 'testpermission', [],
|
|
PermissionStatus::newEmpty()->fatal( 'badaccess-groups', Message::listParam( [ '*' ], 'comma' ), 1 ) ];
|
|
}
|
|
|
|
/**
|
|
* @dataProvider provideConstruction
|
|
*/
|
|
public function testConstruction( $permission, $errors, $expected ) {
|
|
$e = new PermissionsError( $permission, $errors );
|
|
$et = TestingAccessWrapper::newFromObject( $e );
|
|
|
|
$this->expectDeprecationAndContinue( '/Use of PermissionsError::\\$permission/' );
|
|
$this->assertEquals( $permission, $e->permission );
|
|
|
|
$this->assertStatusMessagesExactly( $expected, $et->status );
|
|
|
|
$this->expectDeprecationAndContinue( '/Use of PermissionsError::\\$errors/' );
|
|
$this->assertArrayEquals( $expected->toLegacyErrorArray(), $e->errors );
|
|
|
|
// Test the deprecated public property setter
|
|
$e->errors = $e->errors;
|
|
$this->assertStatusMessagesExactly( $expected, $et->status );
|
|
}
|
|
|
|
public static function provideInvalidConstruction() {
|
|
yield [ null, null ];
|
|
yield [ null, [] ];
|
|
yield [ null, new PermissionStatus() ];
|
|
}
|
|
|
|
/**
|
|
* @dataProvider provideInvalidConstruction
|
|
*/
|
|
public function testInvalidConstruction( $permission, $errors ) {
|
|
$this->expectException( InvalidArgumentException::class );
|
|
$e = new PermissionsError( $permission, $errors );
|
|
}
|
|
}
|