5d0b5a402e
This was introduced in OutputPage before support for getPreloadLinks() was added to ResourceLoader. The introduction in ResourceLoader was actually inspired by this original implementation. Now that we have it, we should make use of it for this module as well. Doing so has several benefits: * Makes the code cleaner by not requiring every skin to implement the extra boolean method. Instead, it naturally works. If the skin loads the SkinModule, it gets the preload as well. If not (such as Minerva, which has a different logo config), then it also doesn't get the preload link. Naturally, automatic. * Makes code cleaner by not having static methods, and by not having OutputPage call into a Module class. * Fixes the problem where, if a site's logo is changed, all cached HTML is preloading the old logo whilst the stylesheet fetches the newer one. Causing both to be downloaded. * Still preloads the logo well before it can render. Change-Id: I11b390f2e4f5e7db8b4506ab547839152888005c |
||
|---|---|---|
| .. | ||
| data | ||
| docs | ||
| documentation | ||
| includes | ||
| languages | ||
| maintenance | ||
| mocks | ||
| skins | ||
| structure | ||
| suites | ||
| tests | ||
| bootstrap.php | ||
| HamcrestPHPUnitIntegration.php | ||
| LessFileCompilationTest.php | ||
| Makefile | ||
| MediaWikiCoversValidator.php | ||
| MediaWikiLangTestCase.php | ||
| MediaWikiPHPUnitTestListener.php | ||
| MediaWikiTestCase.php | ||
| phpunit.php | ||
| PHPUnit4And6Compat.php | ||
| README | ||
| ResourceLoaderTestCase.php | ||
| run-tests.bat | ||
| suite.xml | ||
| TODO | ||
== MediaWiki PHPUnit Tests == The unit tests for MediaWiki are implemented using the PHPUnit testing framework and require PHPUnit to run. === WARNING === Some of the unit tests are DESTRUCTIVE and WILL ALTER YOUR WIKI'S CONTENTS. DO NOT RUN THESE TESTS ON A PRODUCTION SYSTEM OR ON ANY SYSTEM WHERE YOU NEED TO RETAIN YOUR DATA. == Installation == If you used composer to install MediaWiki's dependencies PHPUnit will already be available, unless you explicitly specified the --no-dev flag during the install. In this case just run "composer update". Otherwise follow the installation instructions in the PHPUnit Manual at: https://phpunit.de/manual/current/en/installation.html == Running tests == The tests are run from your operating system's command line. Ensure that you are in the tests/phpunit directory of your MediaWiki installation. On Unix-like operating systems, the tests runs are controlled with a makefile. Run command: make help for a full list of options for running tests. On Windows-family operating systems, run the 'run-tests.bat' batch file. === Writing tests === A guide to writing PHP unit tests for MediaWiki can be found at: https://www.mediawiki.org/wiki/Manual:PHP_unit_testing