The unit tests spend nearly half of their run time resetting the user table for each test. But the majority of tests do not depend on the user table having the exact value that the setup code resets it to, and do not need to modify the user objects they require to run. Fix that by providing an API for tests to get User objects, and to indicate whether the User object will be subject to destructive modification or not. This allows User objects to be reused across multiple unit tests. Change-Id: I17ef1f519759c5e7796c259282afe730ef722e96
181 lines
5.6 KiB
PHP
181 lines
5.6 KiB
PHP
<?php
|
|
|
|
/**
|
|
* @covers CentralIdLookup
|
|
* @group Database
|
|
*/
|
|
class CentralIdLookupTest extends MediaWikiTestCase {
|
|
|
|
public function testFactory() {
|
|
$mock = $this->getMockForAbstractClass( 'CentralIdLookup' );
|
|
|
|
$this->setMwGlobals( [
|
|
'wgCentralIdLookupProviders' => [
|
|
'local' => [ 'class' => 'LocalIdLookup' ],
|
|
'local2' => [ 'class' => 'LocalIdLookup' ],
|
|
'mock' => [ 'factory' => function () use ( $mock ) {
|
|
return $mock;
|
|
} ],
|
|
'bad' => [ 'class' => 'stdClass' ],
|
|
],
|
|
'wgCentralIdLookupProvider' => 'mock',
|
|
] );
|
|
|
|
$this->assertSame( $mock, CentralIdLookup::factory() );
|
|
$this->assertSame( $mock, CentralIdLookup::factory( 'mock' ) );
|
|
$this->assertSame( 'mock', $mock->getProviderId() );
|
|
|
|
$local = CentralIdLookup::factory( 'local' );
|
|
$this->assertNotSame( $mock, $local );
|
|
$this->assertInstanceOf( 'LocalIdLookup', $local );
|
|
$this->assertSame( $local, CentralIdLookup::factory( 'local' ) );
|
|
$this->assertSame( 'local', $local->getProviderId() );
|
|
|
|
$local2 = CentralIdLookup::factory( 'local2' );
|
|
$this->assertNotSame( $local, $local2 );
|
|
$this->assertInstanceOf( 'LocalIdLookup', $local2 );
|
|
$this->assertSame( 'local2', $local2->getProviderId() );
|
|
|
|
$this->assertNull( CentralIdLookup::factory( 'unconfigured' ) );
|
|
$this->assertNull( CentralIdLookup::factory( 'bad' ) );
|
|
}
|
|
|
|
public function testCheckAudience() {
|
|
$mock = TestingAccessWrapper::newFromObject(
|
|
$this->getMockForAbstractClass( 'CentralIdLookup' )
|
|
);
|
|
|
|
$user = static::getTestSysop()->getUser();
|
|
$this->assertSame( $user, $mock->checkAudience( $user ) );
|
|
|
|
$user = $mock->checkAudience( CentralIdLookup::AUDIENCE_PUBLIC );
|
|
$this->assertInstanceOf( 'User', $user );
|
|
$this->assertSame( 0, $user->getId() );
|
|
|
|
$this->assertNull( $mock->checkAudience( CentralIdLookup::AUDIENCE_RAW ) );
|
|
|
|
try {
|
|
$mock->checkAudience( 100 );
|
|
$this->fail( 'Expected exception not thrown' );
|
|
} catch ( InvalidArgumentException $ex ) {
|
|
$this->assertSame( 'Invalid audience', $ex->getMessage() );
|
|
}
|
|
}
|
|
|
|
public function testNameFromCentralId() {
|
|
$mock = $this->getMockForAbstractClass( 'CentralIdLookup' );
|
|
$mock->expects( $this->once() )->method( 'lookupCentralIds' )
|
|
->with(
|
|
$this->equalTo( [ 15 => null ] ),
|
|
$this->equalTo( CentralIdLookup::AUDIENCE_RAW ),
|
|
$this->equalTo( CentralIdLookup::READ_LATEST )
|
|
)
|
|
->will( $this->returnValue( [ 15 => 'FooBar' ] ) );
|
|
|
|
$this->assertSame(
|
|
'FooBar',
|
|
$mock->nameFromCentralId( 15, CentralIdLookup::AUDIENCE_RAW, CentralIdLookup::READ_LATEST )
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @dataProvider provideLocalUserFromCentralId
|
|
* @param string $name
|
|
* @param bool $succeeds
|
|
*/
|
|
public function testLocalUserFromCentralId( $name, $succeeds ) {
|
|
$mock = $this->getMockForAbstractClass( 'CentralIdLookup' );
|
|
$mock->expects( $this->any() )->method( 'isAttached' )
|
|
->will( $this->returnValue( true ) );
|
|
$mock->expects( $this->once() )->method( 'lookupCentralIds' )
|
|
->with(
|
|
$this->equalTo( [ 42 => null ] ),
|
|
$this->equalTo( CentralIdLookup::AUDIENCE_RAW ),
|
|
$this->equalTo( CentralIdLookup::READ_LATEST )
|
|
)
|
|
->will( $this->returnValue( [ 42 => $name ] ) );
|
|
|
|
$user = $mock->localUserFromCentralId(
|
|
42, CentralIdLookup::AUDIENCE_RAW, CentralIdLookup::READ_LATEST
|
|
);
|
|
if ( $succeeds ) {
|
|
$this->assertInstanceOf( 'User', $user );
|
|
$this->assertSame( $name, $user->getName() );
|
|
} else {
|
|
$this->assertNull( $user );
|
|
}
|
|
|
|
$mock = $this->getMockForAbstractClass( 'CentralIdLookup' );
|
|
$mock->expects( $this->any() )->method( 'isAttached' )
|
|
->will( $this->returnValue( false ) );
|
|
$mock->expects( $this->once() )->method( 'lookupCentralIds' )
|
|
->with(
|
|
$this->equalTo( [ 42 => null ] ),
|
|
$this->equalTo( CentralIdLookup::AUDIENCE_RAW ),
|
|
$this->equalTo( CentralIdLookup::READ_LATEST )
|
|
)
|
|
->will( $this->returnValue( [ 42 => $name ] ) );
|
|
$this->assertNull(
|
|
$mock->localUserFromCentralId( 42, CentralIdLookup::AUDIENCE_RAW, CentralIdLookup::READ_LATEST )
|
|
);
|
|
}
|
|
|
|
public static function provideLocalUserFromCentralId() {
|
|
return [
|
|
[ 'UTSysop', true ],
|
|
[ 'UTDoesNotExist', false ],
|
|
[ null, false ],
|
|
[ '', false ],
|
|
[ '<X>', false ],
|
|
];
|
|
}
|
|
|
|
public function testCentralIdFromName() {
|
|
$mock = $this->getMockForAbstractClass( 'CentralIdLookup' );
|
|
$mock->expects( $this->once() )->method( 'lookupUserNames' )
|
|
->with(
|
|
$this->equalTo( [ 'FooBar' => 0 ] ),
|
|
$this->equalTo( CentralIdLookup::AUDIENCE_RAW ),
|
|
$this->equalTo( CentralIdLookup::READ_LATEST )
|
|
)
|
|
->will( $this->returnValue( [ 'FooBar' => 23 ] ) );
|
|
|
|
$this->assertSame(
|
|
23,
|
|
$mock->centralIdFromName( 'FooBar', CentralIdLookup::AUDIENCE_RAW, CentralIdLookup::READ_LATEST )
|
|
);
|
|
}
|
|
|
|
public function testCentralIdFromLocalUser() {
|
|
$mock = $this->getMockForAbstractClass( 'CentralIdLookup' );
|
|
$mock->expects( $this->any() )->method( 'isAttached' )
|
|
->will( $this->returnValue( true ) );
|
|
$mock->expects( $this->once() )->method( 'lookupUserNames' )
|
|
->with(
|
|
$this->equalTo( [ 'FooBar' => 0 ] ),
|
|
$this->equalTo( CentralIdLookup::AUDIENCE_RAW ),
|
|
$this->equalTo( CentralIdLookup::READ_LATEST )
|
|
)
|
|
->will( $this->returnValue( [ 'FooBar' => 23 ] ) );
|
|
|
|
$this->assertSame(
|
|
23,
|
|
$mock->centralIdFromLocalUser(
|
|
User::newFromName( 'FooBar' ), CentralIdLookup::AUDIENCE_RAW, CentralIdLookup::READ_LATEST
|
|
)
|
|
);
|
|
|
|
$mock = $this->getMockForAbstractClass( 'CentralIdLookup' );
|
|
$mock->expects( $this->any() )->method( 'isAttached' )
|
|
->will( $this->returnValue( false ) );
|
|
$mock->expects( $this->never() )->method( 'lookupUserNames' );
|
|
|
|
$this->assertSame(
|
|
0,
|
|
$mock->centralIdFromLocalUser(
|
|
User::newFromName( 'FooBar' ), CentralIdLookup::AUDIENCE_RAW, CentralIdLookup::READ_LATEST
|
|
)
|
|
);
|
|
}
|
|
|
|
}
|