Just methods where adding "static" to the declaration was enough, I didn't do anything with providers that used $this. Initially by search and replace. There were many mistakes which I found mostly by running the PHPStorm inspection which searches for $this usage in a static method. Later I used the PHPStorm "make static" action which avoids the more obvious mistakes. Bug: T332865 Change-Id: I47ed6692945607dfa5c139d42edbd934fa4f3a36
56 lines
1.6 KiB
PHP
56 lines
1.6 KiB
PHP
<?php
|
|
|
|
/**
|
|
* @covers FileContentsHasherTest
|
|
*/
|
|
class FileContentsHasherTest extends PHPUnit\Framework\TestCase {
|
|
|
|
use MediaWikiCoversValidator;
|
|
|
|
public static function provideSingleFile() {
|
|
return array_map( static function ( $file ) {
|
|
return [ $file, file_get_contents( $file ) ];
|
|
}, glob( __DIR__ . '/../../data/filecontentshasher/*.*' ) );
|
|
}
|
|
|
|
/**
|
|
* @covers FileContentsHasher::getFileContentsHash
|
|
* @covers FileContentsHasher::getFileContentsHashInternal
|
|
* @dataProvider provideSingleFile
|
|
*/
|
|
public function testSingleFileHash( $fileName, $contents ) {
|
|
$expected = hash( 'md4', $contents );
|
|
$actualHash = FileContentsHasher::getFileContentsHash( $fileName );
|
|
$this->assertEquals( $expected, $actualHash );
|
|
|
|
$actualHashRepeat = FileContentsHasher::getFileContentsHash( $fileName );
|
|
$this->assertEquals( $expected, $actualHashRepeat );
|
|
}
|
|
|
|
public function provideMultipleFiles() {
|
|
return [
|
|
[ $this->provideSingleFile() ]
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @covers FileContentsHasher::getFileContentsHash
|
|
* @covers FileContentsHasher::getFileContentsHashInternal
|
|
* @dataProvider provideMultipleFiles
|
|
*/
|
|
public function testMultipleFileHash( $files ) {
|
|
$fileNames = [];
|
|
$hashes = [];
|
|
foreach ( $files as [ $fileName, $contents ] ) {
|
|
$fileNames[] = $fileName;
|
|
$hashes[] = hash( 'md4', $contents );
|
|
}
|
|
|
|
$expectedHash = hash( 'md4', implode( '', $hashes ) );
|
|
$actualHash = FileContentsHasher::getFileContentsHash( $fileNames );
|
|
$this->assertEquals( $expectedHash, $actualHash );
|
|
|
|
$actualHashRepeat = FileContentsHasher::getFileContentsHash( $fileNames );
|
|
$this->assertEquals( $expectedHash, $actualHashRepeat );
|
|
}
|
|
}
|