wiki.techinc.nl/tests/phpunit/includes/api/ApiBlockTest.php
Daimona Eaytoy 5f06efb318 Revert "Store block reasons as CommentStoreComments in block classes"
This reverts commit 9335363789.

Reason for revert: It's full of code accessing AbstractBlock::mReason
out there, see [1]. Also, it was never hard deprecated. While that may
be acceptable under some circumstances, it's definitely not OK to remove
code when there are consumers around. I'd have fixed it right now without
reverting if it were a single repo, but there's just too many.

[1] - https://codesearch.wmflabs.org/search/?q=-%3EmReason&i=nope&files=&repos=

Change-Id: I8669f502b50cff89e28dada0f65fe2b130ae9b37
2019-10-19 18:55:45 +00:00

354 lines
9.2 KiB
PHP

<?php
use MediaWiki\Block\DatabaseBlock;
use MediaWiki\Block\Restriction\PageRestriction;
use MediaWiki\Block\Restriction\NamespaceRestriction;
/**
* @group API
* @group Database
* @group medium
*
* @covers ApiBlock
*/
class ApiBlockTest extends ApiTestCase {
protected $mUser = null;
protected function setUp() {
parent::setUp();
$this->tablesUsed = array_merge(
$this->tablesUsed,
[ 'ipblocks', 'change_tag', 'change_tag_def', 'logging' ]
);
$this->mUser = $this->getMutableTestUser()->getUser();
$this->setMwGlobals( 'wgBlockCIDRLimit', [
'IPv4' => 16,
'IPv6' => 19,
] );
}
protected function getTokens() {
return $this->getTokenList( self::$users['sysop'] );
}
/**
* @param array $extraParams Extra API parameters to pass to doApiRequest
* @param User $blocker User to do the blocking, null to pick
* arbitrarily
*/
private function doBlock( array $extraParams = [], User $blocker = null ) {
if ( $blocker === null ) {
$blocker = self::$users['sysop']->getUser();
}
$tokens = $this->getTokens();
$this->assertNotNull( $this->mUser, 'Sanity check' );
$this->assertArrayHasKey( 'blocktoken', $tokens, 'Sanity check' );
$params = [
'action' => 'block',
'user' => $this->mUser->getName(),
'reason' => 'Some reason',
'token' => $tokens['blocktoken'],
];
if ( array_key_exists( 'userid', $extraParams ) ) {
// Make sure we don't have both user and userid
unset( $params['user'] );
}
$ret = $this->doApiRequest( array_merge( $params, $extraParams ), null,
false, $blocker );
$block = DatabaseBlock::newFromTarget( $this->mUser->getName() );
$this->assertTrue( !is_null( $block ), 'Block is valid' );
$this->assertSame( $this->mUser->getName(), (string)$block->getTarget() );
$this->assertSame( 'Some reason', $block->getReason() );
return $ret;
}
/**
* Block by username
*/
public function testNormalBlock() {
$this->doBlock();
}
/**
* Block by user ID
*/
public function testBlockById() {
$this->doBlock( [ 'userid' => $this->mUser->getId() ] );
}
/**
* A blocked user can't block
*/
public function testBlockByBlockedUser() {
$this->expectException( ApiUsageException::class );
$this->expectExceptionMessage(
'You cannot block or unblock other users because you are yourself blocked.'
);
$blocked = $this->getMutableTestUser( [ 'sysop' ] )->getUser();
$block = new DatabaseBlock( [
'address' => $blocked->getName(),
'by' => self::$users['sysop']->getUser()->getId(),
'reason' => 'Capriciousness',
'timestamp' => '19370101000000',
'expiry' => 'infinity',
] );
$block->insert();
$this->doBlock( [], $blocked );
}
public function testBlockOfNonexistentUser() {
$this->expectException( ApiUsageException::class );
$this->expectExceptionMessage(
'There is no user by the name "Nonexistent". Check your spelling.'
);
$this->doBlock( [ 'user' => 'Nonexistent' ] );
}
public function testBlockOfNonexistentUserId() {
$id = 948206325;
$this->expectException( ApiUsageException::class );
$this->expectExceptionMessage( "There is no user with ID $id." );
$this->assertFalse( User::whoIs( $id ), 'Sanity check' );
$this->doBlock( [ 'userid' => $id ] );
}
public function testBlockWithTag() {
ChangeTags::defineTag( 'custom tag' );
$this->doBlock( [ 'tags' => 'custom tag' ] );
$dbw = wfGetDB( DB_MASTER );
$this->assertSame( 1, (int)$dbw->selectField(
[ 'change_tag', 'logging', 'change_tag_def' ],
'COUNT(*)',
[ 'log_type' => 'block', 'ctd_name' => 'custom tag' ],
__METHOD__,
[],
[
'change_tag' => [ 'JOIN', 'ct_log_id = log_id' ],
'change_tag_def' => [ 'JOIN', 'ctd_id = ct_tag_id' ],
]
) );
}
public function testBlockWithProhibitedTag() {
$this->expectException( ApiUsageException::class );
$this->expectExceptionMessage(
'You do not have permission to apply change tags along with your changes.'
);
ChangeTags::defineTag( 'custom tag' );
$this->setMwGlobals( 'wgRevokePermissions',
[ 'user' => [ 'applychangetags' => true ] ] );
$this->doBlock( [ 'tags' => 'custom tag' ] );
}
public function testBlockWithHide() {
global $wgGroupPermissions;
$newPermissions = $wgGroupPermissions['sysop'];
$newPermissions['hideuser'] = true;
$this->mergeMwGlobalArrayValue( 'wgGroupPermissions',
[ 'sysop' => $newPermissions ] );
$res = $this->doBlock( [ 'hidename' => '' ] );
$dbw = wfGetDB( DB_MASTER );
$this->assertSame( '1', $dbw->selectField(
'ipblocks',
'ipb_deleted',
[ 'ipb_id' => $res[0]['block']['id'] ],
__METHOD__
) );
}
public function testBlockWithProhibitedHide() {
$this->expectException( ApiUsageException::class );
$this->expectExceptionMessage(
"You don't have permission to hide user names from the block log."
);
$this->doBlock( [ 'hidename' => '' ] );
}
public function testBlockWithEmailBlock() {
$this->setMwGlobals( [
'wgEnableEmail' => true,
'wgEnableUserEmail' => true,
] );
$res = $this->doBlock( [ 'noemail' => '' ] );
$dbw = wfGetDB( DB_MASTER );
$this->assertSame( '1', $dbw->selectField(
'ipblocks',
'ipb_block_email',
[ 'ipb_id' => $res[0]['block']['id'] ],
__METHOD__
) );
}
public function testBlockWithProhibitedEmailBlock() {
$this->setMwGlobals( [
'wgEnableEmail' => true,
'wgEnableUserEmail' => true,
] );
$this->expectException( ApiUsageException::class );
$this->expectExceptionMessage(
"You don't have permission to block users from sending email through the wiki."
);
$this->setMwGlobals( 'wgRevokePermissions',
[ 'sysop' => [ 'blockemail' => true ] ] );
$this->doBlock( [ 'noemail' => '' ] );
}
public function testBlockWithExpiry() {
$res = $this->doBlock( [ 'expiry' => '1 day' ] );
$dbw = wfGetDB( DB_MASTER );
$expiry = $dbw->selectField(
'ipblocks',
'ipb_expiry',
[ 'ipb_id' => $res[0]['block']['id'] ],
__METHOD__
);
// Allow flakiness up to one second
$this->assertLessThanOrEqual( 1,
abs( wfTimestamp( TS_UNIX, $expiry ) - ( time() + 86400 ) ) );
}
public function testBlockWithInvalidExpiry() {
$this->expectException( ApiUsageException::class );
$this->expectExceptionMessage( "Expiry time invalid." );
$this->doBlock( [ 'expiry' => '' ] );
}
public function testBlockWithoutRestrictions() {
$this->setMwGlobals( [
'wgEnablePartialBlocks' => true,
] );
$this->doBlock();
$block = DatabaseBlock::newFromTarget( $this->mUser->getName() );
$this->assertTrue( $block->isSitewide() );
$this->assertCount( 0, $block->getRestrictions() );
}
public function testBlockWithRestrictions() {
$this->setMwGlobals( [
'wgEnablePartialBlocks' => true,
] );
$title = 'Foo';
$page = $this->getExistingTestPage( $title );
$namespace = NS_TALK;
$this->doBlock( [
'partial' => true,
'pagerestrictions' => $title,
'namespacerestrictions' => $namespace,
'allowusertalk' => true,
] );
$block = DatabaseBlock::newFromTarget( $this->mUser->getName() );
$this->assertFalse( $block->isSitewide() );
$this->assertCount( 2, $block->getRestrictions() );
$this->assertInstanceOf( PageRestriction::class, $block->getRestrictions()[0] );
$this->assertEquals( $title, $block->getRestrictions()[0]->getTitle()->getText() );
$this->assertInstanceOf( NamespaceRestriction::class, $block->getRestrictions()[1] );
$this->assertEquals( $namespace, $block->getRestrictions()[1]->getValue() );
}
public function testBlockingActionWithNoToken() {
$this->expectException( ApiUsageException::class );
$this->expectExceptionMessage( 'The "token" parameter must be set' );
$this->doApiRequest(
[
'action' => 'block',
'user' => $this->mUser->getName(),
'reason' => 'Some reason',
],
null,
false,
self::$users['sysop']->getUser()
);
}
public function testBlockWithLargeRange() {
$tokens = $this->getTokens();
$this->expectException( ApiUsageException::class );
$this->expectExceptionMessage( 'Invalid value "127.0.0.1/64" for user parameter "user".' );
$this->doApiRequest(
[
'action' => 'block',
'user' => '127.0.0.1/64',
'reason' => 'Some reason',
'token' => $tokens['blocktoken'],
],
null,
false,
self::$users['sysop']->getUser()
);
}
public function testBlockingTooManyPageRestrictions() {
$this->setMwGlobals( [
'wgEnablePartialBlocks' => true,
] );
$tokens = $this->getTokens();
$this->expectException( ApiUsageException::class );
$this->expectExceptionMessage(
"Too many values supplied for parameter \"pagerestrictions\". The limit is 10." );
$this->doApiRequest(
[
'action' => 'block',
'user' => $this->mUser->getName(),
'reason' => 'Some reason',
'partial' => true,
'pagerestrictions' => 'One|Two|Three|Four|Five|Six|Seven|Eight|Nine|Ten|Eleven',
'token' => $tokens['blocktoken'],
],
null,
false,
self::$users['sysop']->getUser()
);
}
public function testRangeBlock() {
$this->mUser = User::newFromName( '128.0.0.0/16', false );
$this->doBlock();
}
public function testVeryLargeRangeBlock() {
$this->mUser = User::newFromName( '128.0.0.0/1', false );
$this->expectException( ApiUsageException::class );
$this->expectExceptionMessage( "Range blocks larger than /16 are not allowed." );
$this->doBlock();
}
}