A terminating line break has not been required in wfDebug() since 2014, however no migration was done. Some of these line breaks found their way into LoggerInterface::debug() calls, where they mess up the formatting of the debug log. So, remove terminating line breaks from wfDebug() and LoggerInterface::debug() calls. Also: * Fix the stripping of leading line breaks from the log header emitted by Setup.php. This feature, accidentally broken in 2014, allows requests to be distinguished in the log file. * Avoid using the global variable $self. * Move the logging of the client IP back to Setup.php. It was moved to WebRequest in the hopes that it would not always be needed, however $wgRequest->getIP() is now called unconditionally a few lines up in Setup.php. This means that it is put in its proper place after the "start request" message. * Wrap the log header code in a closure so that variables like $name do not leak into global scope. * In Linker.php, remove a few instances of an unnecessary second parameter to wfDebug(). Change-Id: I96651d3044a95b9d210b51cb8368edc76bebbb9e
184 lines
6.2 KiB
PHP
184 lines
6.2 KiB
PHP
<?php
|
|
/**
|
|
* @defgroup ExternalStorage ExternalStorage
|
|
*/
|
|
|
|
use Psr\Log\LoggerAwareInterface;
|
|
use Psr\Log\LoggerInterface;
|
|
use Psr\Log\NullLogger;
|
|
|
|
/**
|
|
* Key/value blob storage for a collection of storage medium types (e.g. RDBMs, files)
|
|
*
|
|
* Multiple medium types can be active and each one can have multiple "locations" available.
|
|
* Blobs are stored under URLs of the form "<protocol>://<location>/<path>". Each type of storage
|
|
* medium has an associated protocol. Insertions will randomly pick mediums and locations from
|
|
* the provided list of writable medium-qualified locations. Insertions will also fail-over to
|
|
* other writable locations or mediums if one or more are not available.
|
|
*
|
|
* @ingroup ExternalStorage
|
|
* @since 1.34
|
|
*/
|
|
class ExternalStoreAccess implements LoggerAwareInterface {
|
|
/** @var ExternalStoreFactory */
|
|
private $storeFactory;
|
|
/** @var LoggerInterface */
|
|
private $logger;
|
|
|
|
/**
|
|
* @param ExternalStoreFactory $factory
|
|
* @param LoggerInterface|null $logger
|
|
*/
|
|
public function __construct( ExternalStoreFactory $factory, LoggerInterface $logger = null ) {
|
|
$this->storeFactory = $factory;
|
|
$this->logger = $logger ?: new NullLogger();
|
|
}
|
|
|
|
public function setLogger( LoggerInterface $logger ) {
|
|
$this->logger = $logger;
|
|
}
|
|
|
|
/**
|
|
* Fetch data from given URL
|
|
*
|
|
* @see ExternalStoreFactory::getStore()
|
|
*
|
|
* @param string $url The URL of the text to get
|
|
* @param array $params Map of context parameters; same as ExternalStoreFactory::getStore()
|
|
* @return string|bool The text stored or false on error
|
|
* @throws ExternalStoreException
|
|
*/
|
|
public function fetchFromURL( $url, array $params = [] ) {
|
|
return $this->storeFactory->getStoreForUrl( $url, $params )->fetchFromURL( $url );
|
|
}
|
|
|
|
/**
|
|
* Fetch data from multiple URLs with a minimum of round trips
|
|
*
|
|
* @see ExternalStoreFactory::getStore()
|
|
*
|
|
* @param array $urls The URLs of the text to get
|
|
* @param array $params Map of context parameters; same as ExternalStoreFactory::getStore()
|
|
* @return array Map of (url => string or false if not found)
|
|
* @throws ExternalStoreException
|
|
*/
|
|
public function fetchFromURLs( array $urls, array $params = [] ) {
|
|
$batches = $this->storeFactory->getUrlsByProtocol( $urls );
|
|
$retval = [];
|
|
foreach ( $batches as $proto => $batchedUrls ) {
|
|
$store = $this->storeFactory->getStore( $proto, $params );
|
|
$retval += $store->batchFetchFromURLs( $batchedUrls );
|
|
}
|
|
// invalid, not found, db dead, etc.
|
|
$missing = array_diff( $urls, array_keys( $retval ) );
|
|
foreach ( $missing as $url ) {
|
|
$retval[$url] = false;
|
|
}
|
|
|
|
return $retval;
|
|
}
|
|
|
|
/**
|
|
* Insert data into storage and return the assigned URL
|
|
*
|
|
* This will randomly pick one of the available write storage locations to put the data.
|
|
* It will keep failing-over to any untried storage locations whenever one location is
|
|
* not usable.
|
|
*
|
|
* @see ExternalStoreFactory::getStore()
|
|
*
|
|
* @param string $data
|
|
* @param array $params Map of context parameters; same as ExternalStoreFactory::getStore()
|
|
* @param string[]|null $tryStores Base URLs to try, e.g. [ "DB://cluster1" ]
|
|
* @return string|bool The URL of the stored data item, or false on error
|
|
* @throws ExternalStoreException
|
|
*/
|
|
public function insert( $data, array $params = [], array $tryStores = null ) {
|
|
$tryStores = $tryStores ?? $this->storeFactory->getWriteBaseUrls();
|
|
if ( !$tryStores ) {
|
|
throw new ExternalStoreException( "List of external stores provided is empty." );
|
|
}
|
|
|
|
$error = false; // track the last exception thrown
|
|
$readOnlyCount = 0; // track if a store was read-only
|
|
while ( count( $tryStores ) > 0 ) {
|
|
$index = mt_rand( 0, count( $tryStores ) - 1 );
|
|
$storeUrl = $tryStores[$index];
|
|
|
|
$this->logger->debug( __METHOD__ . ": trying $storeUrl" );
|
|
|
|
$store = $this->storeFactory->getStoreForUrl( $storeUrl, $params );
|
|
if ( $store === false ) {
|
|
throw new ExternalStoreException( "Invalid external storage protocol - $storeUrl" );
|
|
}
|
|
|
|
$location = $this->storeFactory->getStoreLocationFromUrl( $storeUrl );
|
|
try {
|
|
if ( $store->isReadOnly( $location ) ) {
|
|
$readOnlyCount++;
|
|
$msg = 'read only';
|
|
} else {
|
|
$url = $store->store( $location, $data );
|
|
if ( strlen( $url ) ) {
|
|
// A store accepted the write; done!
|
|
return $url;
|
|
}
|
|
throw new ExternalStoreException(
|
|
"No URL returned by storage medium ($storeUrl)"
|
|
);
|
|
}
|
|
} catch ( Exception $ex ) {
|
|
$error = $ex;
|
|
$msg = 'caught ' . get_class( $error ) . ' exception: ' . $error->getMessage();
|
|
}
|
|
|
|
unset( $tryStores[$index] ); // Don't try this one again!
|
|
$tryStores = array_values( $tryStores ); // Must have consecutive keys
|
|
$this->logger->error(
|
|
"Unable to store text to external storage {store_path} ({failure})",
|
|
[ 'store_path' => $storeUrl, 'failure' => $msg ]
|
|
);
|
|
}
|
|
|
|
// We only get here when all stores failed.
|
|
if ( $error ) {
|
|
// At least one store threw an exception. Re-throw the most recent one.
|
|
throw $error;
|
|
} elseif ( $readOnlyCount ) {
|
|
// If no exceptions where thrown and we get here,
|
|
// this should mean that all stores were in read-only mode.
|
|
throw new ReadOnlyError();
|
|
} else {
|
|
// We shouldn't get here. If there were no failures, this method should have returned
|
|
// from inside the body of the loop.
|
|
throw new LogicException( "Unexpected failure to store text to external store" );
|
|
}
|
|
}
|
|
|
|
/**
|
|
* @param string[]|string|null $storeUrls Base URL(s) to check, e.g. [ "DB://cluster1" ]
|
|
* @return bool Whether all the default insertion stores are marked as read-only
|
|
* @throws ExternalStoreException
|
|
*/
|
|
public function isReadOnly( $storeUrls = null ) {
|
|
if ( $storeUrls === null ) {
|
|
$storeUrls = $this->storeFactory->getWriteBaseUrls();
|
|
} else {
|
|
$storeUrls = is_array( $storeUrls ) ? $storeUrls : [ $storeUrls ];
|
|
}
|
|
|
|
if ( !$storeUrls ) {
|
|
return false; // no stores exists which can be "read only"
|
|
}
|
|
|
|
foreach ( $storeUrls as $storeUrl ) {
|
|
$store = $this->storeFactory->getStoreForUrl( $storeUrl );
|
|
$location = $this->storeFactory->getStoreLocationFromUrl( $storeUrl );
|
|
if ( $store !== false && !$store->isReadOnly( $location ) ) {
|
|
return false; // at least one store is not read-only
|
|
}
|
|
}
|
|
|
|
return true; // all stores are read-only
|
|
}
|
|
}
|