Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
wiki.techinc.nl/tests/phpunit/unit/includes
History
Thiemo Kreuz 9c57ea2b7f Replace complicated assertions with assertIsString() and such 
This patch tries to make assertions in tests more readable by using more
self-documenting assertions as provided by modern PHPUnit versions. Among
a few others, these two main changes are done:

* I found a lot of assertions with the expected value being the *second*
parameter. I did not changed all of them. Only some that can be replaced
with assertNull() and such.

* I try to replace all `assertTrue( is_…() )` with dedicated assertions.

Change-Id: I1fc72188fbd0edacf13886e7f9a9eacbd85f13c2
2020-01-28 19:17:58 +00:00
..
auth
cache Add LinkBatchFactory to inject services into LinkBatch 2020-01-06 17:02:31 +01:00
changes
composer
config Coding style: Auto-fix MediaWiki.Usage.PHPUnit* 2020-01-10 10:17:12 +00:00
content
debug/logger Stop using assertContains with string haystack 2019-12-15 00:22:44 +00:00
deferred
diff
exception Autofix 94 PHPUnit 8 compat issues 2019-12-13 15:29:10 +01:00
filebackend Deprecate FileJournal::factory 2019-11-04 15:17:56 +01:00
filerepo/file
GlobalFunctions Add public as visibility in tests folder 2019-10-10 21:55:37 +02:00
htmlform Coding style: Auto-fix MediaWiki.Usage.PHPUnit* 2020-01-10 10:17:12 +00:00
http
installer
interwiki
jobqueue
json FormatJson: Improve parse() error code handling and tests 2020-01-01 02:34:44 -08:00
language Autofix 94 PHPUnit 8 compat issues 2019-12-13 15:29:10 +01:00
libs services: Add specific RecursiveServiceDependencyException class 2020-01-09 20:04:29 +00:00
media
objectcache
page Replace Linker::link usage with LinkRenderer in includes 2020-01-11 11:20:17 +01:00
parser Hard-deprecate Sanitizer::escapeId() 2020-01-26 22:05:45 +00:00
password PasswordFactoryTest: assertArraySubset() is deprecated 2020-01-17 16:04:47 +00:00
preferences tests, preferences: Use $this-> instead of self:: when creating TD 2020-01-19 13:30:29 +00:00
registration registration: Rewrite odd !(bool) cast in VersionCheckerTest 2020-01-24 02:15:22 +00:00
resourceloader
Rest Coding style: Auto-fix MediaWiki.Classes.UnsortedUseStatements.UnsortedUse 2020-01-10 09:32:25 -08:00
Revision
search
session Coding style: Auto-fix MediaWiki.Classes.UnsortedUseStatements.UnsortedUse 2020-01-10 09:32:25 -08:00
shell
skins
Storage Add public as visibility in tests folder 2019-10-10 21:55:37 +02:00
tidy
title Coding style: Auto-fix MediaWiki.Usage.PHPUnit* 2020-01-10 10:17:12 +00:00
user
utils Replace some oldskool @see with @inheritDoc 2019-11-08 18:00:27 +00:00
watcheditem
BadFileLookupTest.php
DerivativeRequestTest.php
FactoryArgTestTrait.php Add LinkBatchFactory to inject services into LinkBatch 2020-01-06 17:02:31 +01:00
FauxResponseTest.php
FormOptionsInitializationTest.php
FormOptionsTest.php
LicensesTest.php
PathRouterTest.php
SanitizerValidateEmailTest.php
ServiceWiringTest.php
SiteConfigurationTest.php
TitleArrayFromResultTest.php
XmlJsTest.php
XmlSelectTest.php Replace complicated assertions with assertIsString() and such 2020-01-28 19:17:58 +00:00