wiki.techinc.nl/includes/cache/LinkBatchFactory.php
Tim Starling 16979ecf29 Fix pollution of LinkBatch/LinkCache with interwiki link
* In LinkBatch::addObj(), reject interwiki links with a warning.
  Otherwise the link is added to the batch by ns/title and later
  reconstructed as if it were a local link without an interwiki
  prefix.
* In CommentParser, treat interwiki links as always good, don't defer
  the existence check.
* In LinkBatch, inject a LoggerInstance instead of calling LoggerFactory
  in four places.
* Add a regression test, and some general tests for known links.

Bug: T300311
Change-Id: I0e5825eb48a6ba2932aea69a4d0fff3439c50ff5
2022-01-28 10:52:38 +11:00

102 lines
2.3 KiB
PHP

<?php
/**
* Factory to create LinkBatch objects for querying page existence.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
* http://www.gnu.org/copyleft/gpl.html
*
* @file
* @ingroup Cache
*/
namespace MediaWiki\Cache;
use GenderCache;
use Language;
use LinkBatch;
use LinkCache;
use MediaWiki\Linker\LinkTarget;
use MediaWiki\Page\PageReference;
use Psr\Log\LoggerInterface;
use TitleFormatter;
use Wikimedia\Rdbms\ILoadBalancer;
/**
* @ingroup Cache
* @since 1.35
*/
class LinkBatchFactory {
/**
* @var LinkCache
*/
private $linkCache;
/**
* @var TitleFormatter
*/
private $titleFormatter;
/**
* @var Language
*/
private $contentLanguage;
/**
* @var GenderCache
*/
private $genderCache;
/**
* @var ILoadBalancer
*/
private $loadBalancer;
/** @var LoggerInterface */
private $logger;
public function __construct(
LinkCache $linkCache,
TitleFormatter $titleFormatter,
Language $contentLanguage,
GenderCache $genderCache,
ILoadBalancer $loadBalancer,
LoggerInterface $logger
) {
$this->linkCache = $linkCache;
$this->titleFormatter = $titleFormatter;
$this->contentLanguage = $contentLanguage;
$this->genderCache = $genderCache;
$this->loadBalancer = $loadBalancer;
$this->logger = $logger;
}
/**
* @param iterable<LinkTarget>|iterable<PageReference> $initialItems items to be added
*
* @return LinkBatch
*/
public function newLinkBatch( iterable $initialItems = [] ): LinkBatch {
return new LinkBatch(
$initialItems,
$this->linkCache,
$this->titleFormatter,
$this->contentLanguage,
$this->genderCache,
$this->loadBalancer,
$this->logger
);
}
}