wiki.techinc.nl/includes/htmlform/fields
Tim Starling ca71e69fc6 Try not to discard Excimer timeout exceptions
Don't catch and discard exceptions from the RequestTimeout library,
except when the exception is properly handled and the code seems to be
trying to wrap things up.

In most cases the exception is rethrown. Ideally it should instead be
done by narrowing the catch, and this was feasible in a few cases. But
sometimes the exception being caught is an instance of the base class
(notably DateTime::__construct()). Often Exception is the root of the
hierarchy of exceptions being thrown and so is the obvious catch-all.

Notes on specific callers:

* In the case of ResourceLoader::respond(), exceptions were caught for API
  correctness, but processing continued. I added an outer try block for
  timeout handling so that termination would be more prompt.
* In LCStoreCDB the Exception being caught was Cdb\Exception not
  \Exception. I added an alias to avoid confusion.
* In ImageGallery I added a special exception class.
* In Message::__toString() the rationale for catching disappears
  in PHP 7.4.0+, so I added a PHP version check.
* In PoolCounterRedis, let the shutdown function do its thing, but
  rethrow the exception for logging.

Change-Id: I4c3770b9efc76a1ce42ed9f59329c36de04d657c
2022-02-02 16:27:44 +11:00
..
HTMLApiField.php HTML Classes stability annotations 2020-07-13 14:54:28 +02:00
HTMLAutoCompleteSelectField.php Add cond-state classes in the server-side 2022-01-07 22:14:23 +01:00
HTMLButtonField.php Fix broken PHPDoc comments that don't start with /** 2020-07-23 16:09:41 +00:00
HTMLCheckField.php Refactor global variables to use MediaWikiServices instead 2022-01-10 13:55:53 -05:00
HTMLCheckMatrix.php Add cond-state classes in the server-side 2022-01-07 22:14:23 +01:00
HTMLComboboxField.php HTML Classes stability annotations 2020-07-13 14:54:28 +02:00
HTMLDateTimeField.php Try not to discard Excimer timeout exceptions 2022-02-02 16:27:44 +11:00
HTMLEditTools.php HTML Classes stability annotations 2020-07-13 14:54:28 +02:00
HTMLExpiryField.php HTML Classes stability annotations 2020-07-13 14:54:28 +02:00
HTMLFileField.php HTMLFileField: Make 'accept' parameter optional 2021-01-22 16:24:53 +00:00
HTMLFloatField.php HTML Classes stability annotations 2020-07-13 14:54:28 +02:00
HTMLFormFieldCloner.php HTMLFormFieldCloner: Cache form fields for further use 2022-01-31 16:19:44 +00:00
HTMLFormFieldWithButton.php Fix broken PHPDoc comments that don't start with /** 2020-07-23 16:09:41 +00:00
HTMLHiddenField.php Fix broken PHPDoc comments that don't start with /** 2020-07-23 16:09:41 +00:00
HTMLInfoField.php Fix typos in comments (E-H) 2021-12-30 18:14:43 +05:30
HTMLIntField.php HTML Classes stability annotations 2020-07-13 14:54:28 +02:00
HTMLMultiSelectField.php Allow placeholder to be set for multiselect fields in dropdown mode 2021-12-09 03:03:04 +00:00
HTMLNamespacesMultiselectField.php Rename CSS class 'mw-htmlform-field-autoinfuse' to fit the convention 2021-06-19 15:57:43 +02:00
HTMLRadioField.php Refactor global variables to use MediaWikiServices instead 2022-01-10 13:55:53 -05:00
HTMLRestrictionsField.php Fix broken PHPDoc comments that don't start with /** 2020-07-23 16:09:41 +00:00
HTMLSelectAndOtherField.php Fix broken PHPDoc comments that don't start with /** 2020-07-23 16:09:41 +00:00
HTMLSelectField.php HTML Classes stability annotations 2020-07-13 14:54:28 +02:00
HTMLSelectLanguageField.php Refactor global variables to use MediaWikiServices instead 2022-01-10 13:55:53 -05:00
HTMLSelectLimitField.php Fix typos in comments (E-H) 2021-12-30 18:14:43 +05:30
HTMLSelectNamespace.php Fix broken PHPDoc comments that don't start with /** 2020-07-23 16:09:41 +00:00
HTMLSelectNamespaceWithButton.php Fix broken PHPDoc comments that don't start with /** 2020-07-23 16:09:41 +00:00
HTMLSelectOrOtherField.php Fix broken PHPDoc comments that don't start with /** 2020-07-23 16:09:41 +00:00
HTMLSizeFilterField.php HTML Classes stability annotations 2020-07-13 14:54:28 +02:00
HTMLSubmitField.php HTML Classes stability annotations 2020-07-13 14:54:28 +02:00
HTMLTagFilter.php HTML Classes stability annotations 2020-07-13 14:54:28 +02:00
HTMLTagMultiselectField.php Rename CSS class 'mw-htmlform-field-autoinfuse' to fit the convention 2021-06-19 15:57:43 +02:00
HTMLTextAreaField.php Remove unneeded explicit true/false inside conditions 2021-08-17 21:52:34 +02:00
HTMLTextField.php Remove unneeded explicit true/false inside conditions 2021-08-17 21:52:34 +02:00
HTMLTextFieldWithButton.php Fix broken PHPDoc comments that don't start with /** 2020-07-23 16:09:41 +00:00
HTMLTitlesMultiselectField.php Rename CSS class 'mw-htmlform-field-autoinfuse' to fit the convention 2021-06-19 15:57:43 +02:00
HTMLTitleTextField.php HTMLTitleTextField: Remove B&C code 2021-09-22 00:48:59 -07:00
HTMLUsersMultiselectField.php Rename CSS class 'mw-htmlform-field-autoinfuse' to fit the convention 2021-06-19 15:57:43 +02:00
HTMLUserTextField.php Fix typos in comments (E-H) 2021-12-30 18:14:43 +05:30