* Document that Maintenance::shutdown is the CLI equivalent of MediaWiki::restInPeace. * Centrally document in the emitStats method why we flush stats regularly, and clarify that these OOM concerns are specific to CLI processes there. That isn't to say it could never happen on a web request, but all our early flush handling (even DB trx hooks) are explicitly limited to command-line mode today and always have been. * Ref T253547. It is now clear why --profiler=text doesn't work on the CLI (it is missing the non-external profiler output handling), which I'll fix in a follow-up. * Ref T292269. The WebRequest-dependency in Profiler is now much more clearly problematic. Previously this was masked by wfLogProfilingData effectively silencing the warning on the CLI without it being so obviously wrong. I'll fix that in a follow-up. * Ref T292253. All this is already post-send, and flame graphs confirm that we don't have any calls to emitBufferedStatsdData nor StatsdClient::send apart from the post-send one via restInPeace. Bug: T253547 Bug: T292269 Bug: T292253 Change-Id: If78c37046cf8651c7a8d6690e01d38c3ca29d8d8 |
||
|---|---|---|
| .. | ||
| CloneDatabase.php | ||
| MWLBFactory.php | ||