64734f61ee
https://gerrit.wikimedia.org/r/q/owner:Krinkle+is:merged+message:Widen > Given all called methods are de-facto and liberally claimed, and > that we keep the coverage limited to the subject class, it maintains > the spirit and intent by listing the class explicitly instead. > > PHPUnit offers a more precise tool when you need it (i.e. when testing > legacy monster/god classes), but for well-written code, the > class-wide tag is exactly what you want. > > We lose useful coverage and waste valuable time on keeping tags > accurate through refactors (or worse, forget to do so). > Tracking tiny per-method details wastes time in realizing (and > fixing) when people inevitably don't keep them in sync, and time > lost in finding uncovered code to write tests to realize it was > already covered but "not yet claimed". While at it, also fix PHPUnit warnings in CssContentHandlerIntegrationTest and JavaScriptContentHandlerIntegrationTest about not having any `@covers` annotations. Change-Id: I5afd9fe0bca0fa86cc096f6e5e79f2ba1cfbfa77
50 lines
1.2 KiB
PHP
50 lines
1.2 KiB
PHP
<?php
|
|
|
|
/**
|
|
* @group ContentHandler
|
|
* @group Database
|
|
* ^--- needed, because we do need the database to test link updates
|
|
* @covers \JavaScriptContentHandler
|
|
*/
|
|
class JavaScriptContentHandlerIntegrationTest extends TextContentHandlerIntegrationTest {
|
|
public static function provideGetParserOutput() {
|
|
yield 'Basic render' => [
|
|
'title' => 'MediaWiki:Test.js',
|
|
'model' => null,
|
|
'text' => "hello <world>\n",
|
|
'expectedHtml' => "<pre class=\"mw-code mw-js\" dir=\"ltr\">\nhello <world>\n\n</pre>",
|
|
'expectedFields' => [
|
|
'Links' => [
|
|
],
|
|
'Sections' => [
|
|
],
|
|
],
|
|
];
|
|
yield 'Links' => [
|
|
'title' => 'MediaWiki:Test.js',
|
|
'model' => null,
|
|
'text' => "hello(); // [[world]]\n",
|
|
'expectedHtml' => "<pre class=\"mw-code mw-js\" dir=\"ltr\">\nhello(); // [[world]]\n\n</pre>",
|
|
'expectedFields' => [
|
|
'Links' => [
|
|
[ 'World' => 0, ],
|
|
],
|
|
'Sections' => [
|
|
],
|
|
],
|
|
];
|
|
yield 'TOC' => [
|
|
'title' => 'MediaWiki:Test.js',
|
|
'model' => null,
|
|
'text' => "==One==\n<h2>Two</h2>",
|
|
'expectedHtml' => "<pre class=\"mw-code mw-js\" dir=\"ltr\">\n==One==\n<h2>Two</h2>\n</pre>",
|
|
'expectedFields' => [
|
|
'Links' => [
|
|
],
|
|
# T307691
|
|
'Sections' => [
|
|
],
|
|
],
|
|
];
|
|
}
|
|
}
|