1c60cafab4
With PHPUnit 9, tests without @covers tags are considered risky and emit warnings. Not having @covers is bad practice anyway, so use @coversNothing instead to make the intention clear, and re-enable the phpcs rule. Also rewrite an assertion in ResourcesTest that was bothering me. Bug: T243600 Change-Id: I6dd683f93b6b2faed5f107be2ca7860602277fbc
70 lines
1.8 KiB
PHP
70 lines
1.8 KiB
PHP
<?php
|
|
|
|
use PhpParser\Node;
|
|
use PhpParser\Node\Expr;
|
|
use PhpParser\Node\Stmt;
|
|
use PhpParser\ParserFactory;
|
|
|
|
/**
|
|
* @coversNothing
|
|
*/
|
|
class ScopeStructureTest extends MediaWikiIntegrationTestCase {
|
|
|
|
public static function provideAutoloadNoFileScope() {
|
|
global $wgAutoloadLocalClasses;
|
|
$files = array_unique( $wgAutoloadLocalClasses );
|
|
$args = [];
|
|
foreach ( $files as $file ) {
|
|
$args[$file] = [ $file ];
|
|
}
|
|
return $args;
|
|
}
|
|
|
|
/**
|
|
* Confirm that all files in $wgAutoloadLocalClasses have no file-scope code
|
|
* apart from specific exemptions.
|
|
*
|
|
* This is slow (~15s).
|
|
*
|
|
* @dataProvider provideAutoloadNoFileScope
|
|
*/
|
|
public function testAutoloadNoFileScope( $file ) {
|
|
$parser = ( new ParserFactory )->create( ParserFactory::ONLY_PHP7 );
|
|
$ast = $parser->parse( file_get_contents( $file ) );
|
|
foreach ( $ast as $node ) {
|
|
if ( $node instanceof Stmt\ClassLike
|
|
|| $node instanceof Stmt\Namespace_
|
|
|| $node instanceof Stmt\Use_
|
|
|| $node instanceof Stmt\Nop
|
|
|| $node instanceof Stmt\Declare_
|
|
|| $node instanceof Stmt\Function_
|
|
) {
|
|
continue;
|
|
}
|
|
if ( $node instanceof Stmt\Expression ) {
|
|
$expr = $node->expr;
|
|
if ( $expr instanceof Expr\FuncCall ) {
|
|
if ( $expr->name instanceof Node\Name ) {
|
|
if ( in_array( $expr->name->toString(), [
|
|
'class_alias',
|
|
'define'
|
|
] ) ) {
|
|
continue;
|
|
}
|
|
}
|
|
} elseif ( $expr instanceof Expr\Include_ ) {
|
|
if ( $expr->type === Expr\Include_::TYPE_REQUIRE_ONCE ) {
|
|
continue;
|
|
}
|
|
} elseif ( $expr instanceof Expr\Assign ) {
|
|
if ( $expr->var->name === 'maintClass' ) {
|
|
continue;
|
|
}
|
|
}
|
|
}
|
|
$line = $node->getLine();
|
|
$this->assertNull( $node, "Found file scope code in $file at line $line" );
|
|
}
|
|
$this->assertTrue( true );
|
|
}
|
|
}
|