wiki.techinc.nl/tests/phpunit/includes/Request
Robert Timm 7026c5cd0b WebRequest: detectServer appends default ports that should be omitted
In MediaWiki 1.41.0 the function WebRequest::detectServer() started to generate server URL strings containing default ports such as 80
for http and 443 for https.

Before 1.41.0: https://my.wiki
After  1.41.0: https://my.wiki:443

detectServer() uses IPUtils::combineHostAndPort() to build the URL. The
latter function has actually a mechanism built in that intends to omit
standard ports, so the new behavior in MW 1.41.0 seems unintended.

As this broke WDQS over here in our Wikibase Suite bundle, I
investigated the cause.

MediaWiki 1.41.0 updates IPUtils from 4 to 5. With this update, there
was a change that compares the port now via === instead of ==.
(e68cf6a14e%5E%21/#F1
Line 383) The new behavior is correct, as the function expects an int.
MediaWiki passes in a string though. This bug was hidden with IPUtils 4,
but is triggered now in IPUtils 5.

I think this should be backported to REL1_41.

Change-Id: Ib707ee72e02cf99225168d268d5fedab3f548ead
Bug: T360608
2024-03-28 11:03:28 +00:00
..
ContentSecurityPolicyTest.php tests: Fix @covers and @coversDefaultClass to have leading \ 2024-02-16 22:43:56 +00:00
FauxRequestTest.php tests: Fix @covers and @coversDefaultClass to have leading \ 2024-02-16 22:43:56 +00:00
WebRequestTest.php WebRequest: detectServer appends default ports that should be omitted 2024-03-28 11:03:28 +00:00
WebResponseTest.php tests: Fix @covers and @coversDefaultClass to have leading \ 2024-02-16 22:43:56 +00:00