* Use time() instead of: - wfTimestamp() - wfTimestamp( TS_UNIX ) - wfTimestamp( TS_UNIX, 0 ) - wfTimestamp( TS_UNIX, time() ) - intval( wfTimestamp( TS_UNIX, time() ) ) * Consistently use 1 as default instead of 0. Previously the unwritten convention was that anything "final" max()'ed with 1, and any internal method would use 0, but this wasn't applied consistently made it fragile. There doesn't seem to be any value in returning 0 only to have it maxed up to 1 (because if the 0 would ever make it out alive, we'd be in trouble). * wfTimestamp returns a string for TS_UNIX. In PHP this doesn't matter much. In fact, max() takes number-like integers so transparently, it even preserves it: > max( 1, 3, '2' ); < 3 > max( 1, '3', 2 ); < "3" Just cast it in one place at the very end (StartupModule) instead of doing intval( wfTimestamp() ). * Fix weird documentation claiming getModifiedTime can return an array, or mixed. * Remove 'version > 1 ? version : 1' logic in ResourceLoader::makeLoaderRegisterScript. The client doesn't have "0 means now" behaviour so this isn't needed. And the method was only doing it for variadic argument calls. Removal of quotes around timestamps reduced the size of the startup module from 26.8KB to 25.9KB before gzip. After gzip the size was and still is 5.7KB, though. (From 5456 bytes to 5415 bytes.) Change-Id: If92ca3e7511e78fa779f2f2701e2ab24db78c8a8
266 lines
7.8 KiB
PHP
266 lines
7.8 KiB
PHP
<?php
|
|
/**
|
|
* Abstraction for resource loader modules which pull from wiki pages.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @file
|
|
* @author Trevor Parscal
|
|
* @author Roan Kattouw
|
|
*/
|
|
|
|
/**
|
|
* Abstraction for resource loader modules which pull from wiki pages
|
|
*
|
|
* This can only be used for wiki pages in the MediaWiki and User namespaces,
|
|
* because of its dependence on the functionality of
|
|
* Title::isCssJsSubpage.
|
|
*/
|
|
abstract class ResourceLoaderWikiModule extends ResourceLoaderModule {
|
|
|
|
/* Protected Members */
|
|
|
|
# Origin is user-supplied code
|
|
protected $origin = self::ORIGIN_USER_SITEWIDE;
|
|
|
|
// In-object cache for title info
|
|
protected $titleInfo = array();
|
|
|
|
/* Abstract Protected Methods */
|
|
|
|
/**
|
|
* Subclasses should return an associative array of resources in the module.
|
|
* Keys should be the title of a page in the MediaWiki or User namespace.
|
|
*
|
|
* Values should be a nested array of options. The supported keys are 'type' and
|
|
* (CSS only) 'media'.
|
|
*
|
|
* For scripts, 'type' should be 'script'.
|
|
*
|
|
* For stylesheets, 'type' should be 'style'.
|
|
* There is an optional media key, the value of which can be the
|
|
* medium ('screen', 'print', etc.) of the stylesheet.
|
|
*
|
|
* @param ResourceLoaderContext $context
|
|
* @return array
|
|
*/
|
|
abstract protected function getPages( ResourceLoaderContext $context );
|
|
|
|
/* Protected Methods */
|
|
|
|
/**
|
|
* Get the Database object used in getTitleMTimes(). Defaults to the local slave DB
|
|
* but subclasses may want to override this to return a remote DB object, or to return
|
|
* null if getTitleMTimes() shouldn't access the DB at all.
|
|
*
|
|
* NOTE: This ONLY works for getTitleMTimes() and getModifiedTime(), NOT FOR ANYTHING ELSE.
|
|
* In particular, it doesn't work for getting the content of JS and CSS pages. That functionality
|
|
* will use the local DB irrespective of the return value of this method.
|
|
*
|
|
* @return IDatabase|null
|
|
*/
|
|
protected function getDB() {
|
|
return wfGetDB( DB_SLAVE );
|
|
}
|
|
|
|
/**
|
|
* @param Title $title
|
|
* @return null|string
|
|
*/
|
|
protected function getContent( $title ) {
|
|
$handler = ContentHandler::getForTitle( $title );
|
|
if ( $handler->isSupportedFormat( CONTENT_FORMAT_CSS ) ) {
|
|
$format = CONTENT_FORMAT_CSS;
|
|
} elseif ( $handler->isSupportedFormat( CONTENT_FORMAT_JAVASCRIPT ) ) {
|
|
$format = CONTENT_FORMAT_JAVASCRIPT;
|
|
} else {
|
|
return null;
|
|
}
|
|
|
|
$revision = Revision::newFromTitle( $title, false, Revision::READ_NORMAL );
|
|
if ( !$revision ) {
|
|
return null;
|
|
}
|
|
|
|
$content = $revision->getContent( Revision::RAW );
|
|
|
|
if ( !$content ) {
|
|
wfDebugLog( 'resourceloader', __METHOD__ . ': failed to load content of JS/CSS page!' );
|
|
return null;
|
|
}
|
|
|
|
return $content->serialize( $format );
|
|
}
|
|
|
|
/* Methods */
|
|
|
|
/**
|
|
* @param ResourceLoaderContext $context
|
|
* @return string
|
|
*/
|
|
public function getScript( ResourceLoaderContext $context ) {
|
|
$scripts = '';
|
|
foreach ( $this->getPages( $context ) as $titleText => $options ) {
|
|
if ( $options['type'] !== 'script' ) {
|
|
continue;
|
|
}
|
|
$title = Title::newFromText( $titleText );
|
|
if ( !$title || $title->isRedirect() ) {
|
|
continue;
|
|
}
|
|
$script = $this->getContent( $title );
|
|
if ( strval( $script ) !== '' ) {
|
|
$script = $this->validateScriptFile( $titleText, $script );
|
|
$scripts .= ResourceLoader::makeComment( $titleText ) . $script . "\n";
|
|
}
|
|
}
|
|
return $scripts;
|
|
}
|
|
|
|
/**
|
|
* @param ResourceLoaderContext $context
|
|
* @return array
|
|
*/
|
|
public function getStyles( ResourceLoaderContext $context ) {
|
|
$styles = array();
|
|
foreach ( $this->getPages( $context ) as $titleText => $options ) {
|
|
if ( $options['type'] !== 'style' ) {
|
|
continue;
|
|
}
|
|
$title = Title::newFromText( $titleText );
|
|
if ( !$title || $title->isRedirect() ) {
|
|
continue;
|
|
}
|
|
$media = isset( $options['media'] ) ? $options['media'] : 'all';
|
|
$style = $this->getContent( $title );
|
|
if ( strval( $style ) === '' ) {
|
|
continue;
|
|
}
|
|
if ( $this->getFlip( $context ) ) {
|
|
$style = CSSJanus::transform( $style, true, false );
|
|
}
|
|
$style = CSSMin::remap( $style, false, $this->getConfig()->get( 'ScriptPath' ), true );
|
|
if ( !isset( $styles[$media] ) ) {
|
|
$styles[$media] = array();
|
|
}
|
|
$style = ResourceLoader::makeComment( $titleText ) . $style;
|
|
$styles[$media][] = $style;
|
|
}
|
|
return $styles;
|
|
}
|
|
|
|
/**
|
|
* @param ResourceLoaderContext $context
|
|
* @return int
|
|
*/
|
|
public function getModifiedTime( ResourceLoaderContext $context ) {
|
|
$modifiedTime = 1;
|
|
$titleInfo = $this->getTitleInfo( $context );
|
|
if ( count( $titleInfo ) ) {
|
|
$mtimes = array_map( function ( $value ) {
|
|
return $value['timestamp'];
|
|
}, $titleInfo );
|
|
$modifiedTime = max( $modifiedTime, max( $mtimes ) );
|
|
}
|
|
$modifiedTime = max(
|
|
$modifiedTime,
|
|
$this->getMsgBlobMtime( $context->getLanguage() ),
|
|
$this->getDefinitionMtime( $context )
|
|
);
|
|
return $modifiedTime;
|
|
}
|
|
|
|
/**
|
|
* Get the definition summary for this module.
|
|
*
|
|
* @param ResourceLoaderContext $context
|
|
* @return array
|
|
*/
|
|
public function getDefinitionSummary( ResourceLoaderContext $context ) {
|
|
return array(
|
|
'class' => get_class( $this ),
|
|
'pages' => $this->getPages( $context ),
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @param ResourceLoaderContext $context
|
|
* @return bool
|
|
*/
|
|
public function isKnownEmpty( ResourceLoaderContext $context ) {
|
|
$titleInfo = $this->getTitleInfo( $context );
|
|
// Bug 68488: For modules in the "user" group, we should actually
|
|
// check that the pages are empty (page_len == 0), but for other
|
|
// groups, just check the pages exist so that we don't end up
|
|
// caching temporarily-blank pages without the appropriate
|
|
// <script> or <link> tag.
|
|
if ( $this->getGroup() !== 'user' ) {
|
|
return count( $titleInfo ) === 0;
|
|
}
|
|
|
|
foreach ( $titleInfo as $info ) {
|
|
if ( $info['length'] !== 0 ) {
|
|
// At least one non-0-lenth page, not empty
|
|
return false;
|
|
}
|
|
}
|
|
|
|
// All pages are 0-length, so it's empty
|
|
return true;
|
|
}
|
|
|
|
/**
|
|
* Get the modification times of all titles that would be loaded for
|
|
* a given context.
|
|
* @param ResourceLoaderContext $context Context object
|
|
* @return array Keyed by page dbkey. Value is an array with 'length' and 'timestamp'
|
|
* keys, where the timestamp is a UNIX timestamp
|
|
*/
|
|
protected function getTitleInfo( ResourceLoaderContext $context ) {
|
|
$dbr = $this->getDB();
|
|
if ( !$dbr ) {
|
|
// We're dealing with a subclass that doesn't have a DB
|
|
return array();
|
|
}
|
|
|
|
$hash = $context->getHash();
|
|
if ( isset( $this->titleInfo[$hash] ) ) {
|
|
return $this->titleInfo[$hash];
|
|
}
|
|
|
|
$this->titleInfo[$hash] = array();
|
|
$batch = new LinkBatch;
|
|
foreach ( $this->getPages( $context ) as $titleText => $options ) {
|
|
$batch->addObj( Title::newFromText( $titleText ) );
|
|
}
|
|
|
|
if ( !$batch->isEmpty() ) {
|
|
$res = $dbr->select( 'page',
|
|
array( 'page_namespace', 'page_title', 'page_touched', 'page_len' ),
|
|
$batch->constructSet( 'page', $dbr ),
|
|
__METHOD__
|
|
);
|
|
foreach ( $res as $row ) {
|
|
$title = Title::makeTitle( $row->page_namespace, $row->page_title );
|
|
$this->titleInfo[$hash][$title->getPrefixedDBkey()] = array(
|
|
'timestamp' => wfTimestamp( TS_UNIX, $row->page_touched ),
|
|
'length' => $row->page_len,
|
|
);
|
|
}
|
|
}
|
|
return $this->titleInfo[$hash];
|
|
}
|
|
}
|