Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
wiki.techinc.nl/includes
History
Aaron Schulz 4659cbcccc rdbms: fix table prefixing in "FOR UPDATE" clause generation in Postgres 
Make SqlPlatform::tableNameWithAlias() include the unqualified table
name as an alias if doing so is not redundant. This assures that the
default alias from JoinGroupBase::addJoin(), equal to the unqualified
table name, will be usable in SQL (regardless of table prefixes).

Clean up use of identifier quotes for sqlite_master tables. The called
methods expect unqualified names and a passthrough exception already
exists for sqlite_* tables.

Use "block_target.bt_user" directly in ApiQueryBlocks and BlockPager,
instead of using addIdentifierQuotes(). The "block_target" alias is
automatically added to the SQL by the rdbms layer when it's not clearly
redundant, so it is always safe to use block_target.bt_user. Also, there
is no reason for aliases to include quote characters. They are supposed
to be simple alphanumerics like column names. This makes it easy for
tableNameWithAlias() to avoid redundant aliases by checking tableName().

Avoid unneeded quotes around pg_catalog.* table names in the Postgres
installer. The relevant documentation of methods like selectField() is
that the table names be unqualified (no quotes nor dots), though dots
are still supported internally for compatibility reasons and ease of
querying schemas like pg_catalog and information_schema.

Change-Id: Ic7d7826da31f49915141692cb3bd84ed1e872e96
2025-06-24 22:33:30 +01:00
..
actions Apply proper restrictions on file revert action 2025-03-24 12:55:44 +00:00
api rdbms: fix table prefixing in "FOR UPDATE" clause generation in Postgres 2025-06-24 22:33:30 +01:00
auth Use anonymous user when creating named account from temp account 2025-05-29 12:06:33 +00:00
block block: Fix DBS::acquireTarget() race using GET_LOCK() 2025-04-07 11:43:34 +00:00
cache Use explicit nullable type on parameter arguments 2024-10-16 20:58:33 +02:00
Category
changetags ChangeTags: Optimize label and description parsing 2025-04-03 18:24:46 +01:00
collation Use namespaced classes 2024-10-21 20:41:20 +02:00
CommentFormatter Use explicit nullable type on parameter arguments 2024-10-16 20:58:33 +02:00
CommentStore Use explicit nullable type on parameter arguments 2024-10-16 20:58:33 +02:00
composer In .htaccess deny files, use "Satisfy All" 2025-04-04 13:17:15 +00:00
config
content Merge "Use explicit nullable type on parameter arguments" 2024-10-16 23:10:14 +00:00
context Use explicit nullable type on parameter arguments 2024-10-16 20:58:33 +02:00
dao
db Merge "CloneDatabase: Remove debug logging" 2024-10-17 23:38:11 +00:00
debug logger: Make log() methods return void 2025-06-18 02:21:42 +00:00
deferred Fix GREATEST usage in site_stats 2025-03-20 15:48:17 +00:00
diff Diffs: avoid getContentHandler on null error 2025-04-10 21:37:29 +00:00
edit parser: Gracefully handle invalid ParsoidRenderID keys 2025-02-04 14:54:31 +00:00
editpage PermissionManager: Differentiate between cascading protection of file content and file pages 2025-03-24 13:31:34 +00:00
exception HttpError: Cast Message to string 2025-03-11 21:58:06 +00:00
export Use namespaced classes 2024-10-21 20:41:20 +02:00
ExternalLinks ExternalLinks: fix mailto: links reversal 2025-02-28 16:33:54 +00:00
externalstore Use namespaced classes 2024-10-21 20:41:20 +02:00
Feed SECURITY: Escape newpage message in FeedUtils 2025-04-17 19:13:20 +00:00
filebackend filebackend: Check for old alias in FileBackendMultiWrite 2024-10-22 01:32:54 +02:00
filerepo filerepo: No exception on redirect without width in ThumbnailEntryPoint 2025-04-29 20:01:15 +00:00
gallery Use namespaced classes 2024-10-21 20:41:20 +02:00
historyblob
Hook
HookContainer WhatLinksHere: Allow extensible filters 2024-10-21 14:27:53 +05:30
Html SECURITY: Ensure emitted HTML is safe against Unicode NFC normalization 2025-04-10 15:56:06 +01:00
htmlform SECURITY: escape section labels in HTMLMultiSelectField 2025-04-10 15:56:06 +01:00
http Use explicit nullable type on parameter arguments 2024-10-16 20:58:33 +02:00
import Drop PHP 7.4/8.0 support from master (forward-port from MW 1.42) 2025-06-18 10:53:22 +01:00
installer rdbms: fix table prefixing in "FOR UPDATE" clause generation in Postgres 2025-06-24 22:33:30 +01:00
interwiki Use explicit nullable type on parameter arguments 2024-10-16 20:58:33 +02:00
jobqueue RefreshLinksJob: Don't retry job if "Revision x is not current" is returned 2024-11-19 16:08:11 +00:00
json Use explicit nullable type on parameter arguments 2024-10-16 20:58:33 +02:00
language Drop a few phan PhanImpossibleTypeComparison suppressions now we've dropped PHP 7.4 2025-06-18 10:54:01 +01:00
languages Add Central Kanuri (knc), deprecate Kanuri (kr) 2024-10-20 19:18:46 +00:00
libs rdbms: fix table prefixing in "FOR UPDATE" clause generation in Postgres 2025-06-24 22:33:30 +01:00
linkeddata
linker Use explicit nullable type on parameter arguments 2024-10-16 20:58:33 +02:00
logging SECURITY: Fix log entry search revealing suppressed data to users with 'deletedhistory' rights 2025-04-10 15:56:06 +01:00
mail Use explicit nullable type on parameter arguments 2024-10-16 20:58:33 +02:00
media FormatMetadata::formatFraction: Don't risk passing null to preg_match 2025-05-22 17:13:58 +00:00
Message SECURITY: Ensure emitted HTML is safe against Unicode NFC normalization 2025-04-10 15:56:06 +01:00
Navigation
objectcache objectcache: Cast explicitly to integer 2025-05-12 11:24:42 +00:00
Output Skin: [BREAKING CHANGE] Remove support for rendering outside body element 2024-10-30 15:18:51 +00:00
OutputTransform SECURITY: Ensure emitted HTML is safe against Unicode NFC normalization 2025-04-10 15:56:06 +01:00
page Use namespaced classes 2024-10-21 20:41:20 +02:00
pager ContributionsPager: Fix getTemplateParams() parameter 2024-10-25 13:52:47 +00:00
ParamValidator/TypeDef
parser Drop PHP 7.4/8.0 support from master (forward-port from MW 1.42) 2025-06-18 10:53:22 +01:00
password Use explicit nullable type on parameter arguments 2024-10-16 20:58:33 +02:00
Permissions RestrictionStore: Remove short-circuit mode when fetching cascading sources 2025-04-09 13:25:44 +00:00
poolcounter objectcache: Move RedisConnRef.php to /libs/objectcache/ 2024-11-07 08:40:54 +00:00
preferences Add explanation text for "Allow emails from brand-new users" 2025-02-21 22:34:44 +00:00
profiler Use explicit nullable type on parameter arguments 2024-10-16 20:58:33 +02:00
recentchanges objectcache: Move RedisConnRef.php to /libs/objectcache/ 2024-11-07 08:40:54 +00:00
registration
RenameUser
Request Request: Improve log message when headers already sent 2025-03-10 15:12:31 +00:00
ResourceLoader Drop a few phan PhanImpossibleTypeComparison suppressions now we've dropped PHP 7.4 2025-06-18 10:54:01 +01:00
Rest Localisation updates from https://translatewiki.net. 2025-06-24 07:33:27 +02:00
Revision Use explicit nullable type on parameter arguments 2024-10-16 20:58:33 +02:00
revisiondelete RevDelList: Ensure setVisibility always includes itemStatuses in value if applicable 2025-03-08 01:53:49 +00:00
revisionlist
search rdbms: fix table prefixing in "FOR UPDATE" clause generation in Postgres 2025-06-24 22:33:30 +01:00
session session: Do not set session.use_trans_sid 2025-01-06 22:12:05 +00:00
Settings Use explicit nullable type on parameter arguments 2024-10-16 20:58:33 +02:00
shell FileRepo: Add support for the new Shellbox large file feature 2024-10-29 02:50:07 +00:00
site
SiteStats
skins Merge "Hard deprecate soft deprecated skin methods" into REL1_43 2024-11-13 00:27:38 +00:00
sparql
specialpage Improve BrokenRedirects display 2025-06-03 20:52:50 +00:00
specials rdbms: fix table prefixing in "FOR UPDATE" clause generation in Postgres 2025-06-24 22:33:30 +01:00
Status Make Message and MessageValue compatible 2024-10-19 15:00:07 +02:00
Storage Merge "Use explicit nullable type on parameter arguments" 2024-10-16 23:10:14 +00:00
StubObject
templates img_auth: Output lang and dir in HTTP and HTML on error message 2024-10-29 15:18:52 +00:00
tidy SECURITY: Ensure emitted HTML is safe against Unicode NFC normalization 2025-04-10 15:56:06 +01:00
title title: Reset cached Title objects between tests 2025-05-27 12:35:10 +00:00
upload UploadBase: makeWarningsSerializable() should accept MessageParam objects 2025-04-12 22:40:51 +00:00
user Avoid trying to load the session user in MW_NO_SESSION endpoints 2025-03-11 00:28:38 +00:00
utils structure tests: allow PHP 8.1 syntax and autoload enums 2025-06-18 10:55:15 +01:00
watchlist Merge "Use explicit nullable type on parameter arguments" 2024-10-16 23:10:14 +00:00
widget widget: Remove outdated try/catch wrapper from SpinnerWidget 2025-06-14 10:42:05 +00:00
WikiMap
xml Use explicit nullable type on parameter arguments 2024-10-16 20:58:33 +02:00
.htaccess In .htaccess deny files, use "Satisfy All" 2025-04-04 13:17:15 +00:00
AutoLoader.php AutoLoader: Use require_once rather than require 2024-10-24 01:36:18 +00:00
BootstrapHelperFunctions.php
config-schema.php DnsBlacklistUrls: Remove sorbs.net 2025-01-06 22:57:01 +00:00
DefaultSettings.php
Defines.php Prep 1.43.1 2025-04-10 17:18:51 +00:00
DevelopmentSettings.php
EntryPointEnvironment.php
GlobalFunctions.php Deprecate wfArrayDiff2() 2024-11-04 19:34:41 +00:00
MainConfigNames.php Remove CryptHKDF and MWCryptHKDF 2024-11-10 22:49:37 -05:00
MainConfigSchema.php Update Pingback address 2025-04-24 16:18:06 +00:00
MediaWiki.php
MediaWikiEntryPoint.php
MediaWikiServices.php Remove CryptHKDF and MWCryptHKDF 2024-11-10 22:49:37 -05:00
PHPVersionCheck.php structure tests: allow PHP 8.1 syntax and autoload enums 2025-06-18 10:55:15 +01:00
ServiceWiring.php Remove CryptHKDF and MWCryptHKDF 2024-11-10 22:49:37 -05:00
Setup.php Setup: Update error message for composer dependencies check 2025-06-13 20:54:40 +00:00
SetupDynamicConfig.php
WebStart.php