61ae7504df
createMock() does the same, but is much easier to read. A small difference is that some of the replacements made in this patch didn't use disableOriginalConstructor() before. In case this was relevant we should see the respective test fail. If not we can save some CPU cycles and skip these constructors. Change-Id: Ib98fb06e0fe753b7a53cb087a47e1159515a8ad5
66 lines
1.7 KiB
PHP
66 lines
1.7 KiB
PHP
<?php
|
|
|
|
use Wikimedia\ParamValidator\ParamValidator;
|
|
|
|
/**
|
|
* TODO convert to unit test, no integration is needed
|
|
*
|
|
* @covers ApiOpenSearch
|
|
*/
|
|
class ApiOpenSearchTest extends MediaWikiIntegrationTestCase {
|
|
public function testGetAllowedParams() {
|
|
$config = $this->replaceSearchEngineConfig();
|
|
$config->method( 'getSearchTypes' )
|
|
->willReturn( [ 'the one ring' ] );
|
|
|
|
list( $engine, $engineFactory ) = $this->replaceSearchEngine();
|
|
|
|
$ctx = new RequestContext();
|
|
$apiMain = new ApiMain( $ctx );
|
|
$api = new ApiOpenSearch(
|
|
$apiMain,
|
|
'opensearch',
|
|
$this->getServiceContainer()->getLinkBatchFactory(),
|
|
$config,
|
|
$engineFactory
|
|
);
|
|
|
|
$engine->method( 'getProfiles' )
|
|
->willReturnMap( [
|
|
[ SearchEngine::COMPLETION_PROFILE_TYPE, $api->getUser(), [
|
|
[
|
|
'name' => 'normal',
|
|
'desc-message' => 'normal-message',
|
|
'default' => true,
|
|
],
|
|
[
|
|
'name' => 'strict',
|
|
'desc-message' => 'strict-message',
|
|
],
|
|
] ],
|
|
] );
|
|
|
|
$params = $api->getAllowedParams();
|
|
|
|
$this->assertArrayNotHasKey( 'offset', $params );
|
|
$this->assertArrayHasKey( 'profile', $params, print_r( $params, true ) );
|
|
$this->assertEquals( 'normal', $params['profile'][ParamValidator::PARAM_DEFAULT] );
|
|
}
|
|
|
|
private function replaceSearchEngineConfig() {
|
|
$config = $this->createMock( SearchEngineConfig::class );
|
|
$this->setService( 'SearchEngineConfig', $config );
|
|
|
|
return $config;
|
|
}
|
|
|
|
private function replaceSearchEngine() {
|
|
$engine = $this->createMock( SearchEngine::class );
|
|
$engineFactory = $this->createMock( SearchEngineFactory::class );
|
|
$engineFactory->method( 'create' )
|
|
->willReturn( $engine );
|
|
$this->setService( 'SearchEngineFactory', $engineFactory );
|
|
|
|
return [ $engine, $engineFactory ];
|
|
}
|
|
}
|