4160c223f2
Add a few missing `@group Language` tags as well. Remove stray `@group Cache` from two classes since "Cache" is not a MediaWiki core component (per T248519 and related tasks, we did long ago in Bugzilla have a "MediaWiki-Cache" category, but that's since been re-orged into BagOStuff, HTTP-Cache, and Parser/ParserCache, and Internationalization/LocalisationCache, per the description at <https://phabricator.wikimedia.org/project/profile/1329/>.) Ref https://gerrit.wikimedia.org/r/q/owner:Krinkle+is:merged+message:Widen > Given all called methods are de-facto and liberally claimed, and > that we keep the coverage limited to the subject class, it maintains > the spirit and intent by listing the class explicitly instead. > > PHPUnit offers a more precise tool when you need it (i.e. when testing > legacy monster/god classes), but for well-written code, the > class-wide tag is exactly what you want. > > We lose useful coverage and waste valuable time on keeping tags > accurate through refactors (or worse, forget to do so). > Tracking tiny per-method details wastes time in realizing (and > fixing) when people inevitably don't keep them in sync, and time > lost in finding uncovered code to write tests to realize it was > already covered but "not yet claimed". Bug: T364652 Change-Id: I9cfc4c210b90bfed6fd988a2525f80f5f5ee4870
19 lines
482 B
PHP
19 lines
482 B
PHP
<?php
|
|
|
|
/**
|
|
* @group Language
|
|
* @covers \ConverterRule
|
|
*/
|
|
class ConverterRuleTest extends MediaWikiIntegrationTestCase {
|
|
|
|
public function testParseEmpty() {
|
|
$converter = new EnConverter( new Language() );
|
|
$rule = new ConverterRule( '', $converter );
|
|
$rule->parse();
|
|
|
|
$this->assertSame( false, $rule->getTitle(), 'title' );
|
|
$this->assertSame( [], $rule->getConvTable(), 'conversion table' );
|
|
$this->assertSame( 'none', $rule->getRulesAction(), 'rules action' );
|
|
}
|
|
|
|
}
|