5f57d5d657
PHP, particularly with in_array, really has problems with integer 0 versus non-numeric strings. Let's clean that up by converting values to strings more agressively and using the $strict option to in_array. Oddly enough, the one place where strict in_array was being used already broke when If4175332 stringified the values in one array but not the other. Bug: 62268 Change-Id: Id34e654eb8d0e70d093b11445273e542e491e265
71 lines
1.7 KiB
PHP
71 lines
1.7 KiB
PHP
<?php
|
|
|
|
/**
|
|
* Radio checkbox fields.
|
|
*/
|
|
class HTMLRadioField extends HTMLFormField {
|
|
function validate( $value, $alldata ) {
|
|
$p = parent::validate( $value, $alldata );
|
|
|
|
if ( $p !== true ) {
|
|
return $p;
|
|
}
|
|
|
|
if ( !is_string( $value ) && !is_int( $value ) ) {
|
|
return false;
|
|
}
|
|
|
|
$validOptions = HTMLFormField::flattenOptions( $this->getOptions() );
|
|
|
|
if ( in_array( strval( $value ), $validOptions, true ) ) {
|
|
return true;
|
|
} else {
|
|
return $this->msg( 'htmlform-select-badoption' )->parse();
|
|
}
|
|
}
|
|
|
|
/**
|
|
* This returns a block of all the radio options, in one cell.
|
|
* @see includes/HTMLFormField#getInputHTML()
|
|
*
|
|
* @param $value String
|
|
*
|
|
* @return String
|
|
*/
|
|
function getInputHTML( $value ) {
|
|
$html = $this->formatOptions( $this->getOptions(), strval( $value ) );
|
|
|
|
return $html;
|
|
}
|
|
|
|
function formatOptions( $options, $value ) {
|
|
$html = '';
|
|
|
|
$attribs = $this->getAttributes( array( 'disabled', 'tabindex' ) );
|
|
$elementFunc = array( 'Html', $this->mOptionsLabelsNotFromMessage ? 'rawElement' : 'element' );
|
|
|
|
# @todo Should this produce an unordered list perhaps?
|
|
foreach ( $options as $label => $info ) {
|
|
if ( is_array( $info ) ) {
|
|
$html .= Html::rawElement( 'h1', array(), $label ) . "\n";
|
|
$html .= $this->formatOptions( $info, $value );
|
|
} else {
|
|
$id = Sanitizer::escapeId( $this->mID . "-$info" );
|
|
$radio = Xml::radio( $this->mName, $info, $info === $value, $attribs + array( 'id' => $id ) );
|
|
$radio .= ' ' . call_user_func( $elementFunc, 'label', array( 'for' => $id ), $label );
|
|
|
|
$html .= ' ' . Html::rawElement(
|
|
'div',
|
|
array( 'class' => 'mw-htmlform-flatlist-item' ),
|
|
$radio
|
|
);
|
|
}
|
|
}
|
|
|
|
return $html;
|
|
}
|
|
|
|
protected function needsLabel() {
|
|
return false;
|
|
}
|
|
}
|