wiki.techinc.nl/includes/diff
Matthias Mullie 7fe98fb56c Don't calculate amount of inbetween revisions for MCR undo
Ib404d29a662de7736b50a1d07380f651d332ad6b introduced a new sanity
check in RevisionStore::countRevisionsBetween to check whether
the ids are not null (otherwise, they're considered unsaved)

For MCR undo actions, diffs could be generated for unsaved revisions
(where one revision is a not yet pre-existing combination where
some slots remain unchanged, but some slot gets undone)

The existing if statement here was already trying to guard against
unsaved revisions, but was doing so in a way different from the
new checks in RevisionStore::countRevisionsBetween - even though this
was documented to only diff saved revisions, it wasn't checking
thoroughly enough, and an exception would crop up later.

Bug: T236320
Change-Id: If34766675f50b67d8b0788a6eab07d8d4e6fe183
2019-11-04 11:17:37 +01:00
..
ArrayDiffFormatter.php Unsuppress more phan issues (part 3) 2019-08-31 16:38:55 +00:00
ComplexityException.php Rethink diff limits 2016-06-01 16:30:58 -07:00
Diff.php Split DairikiDiff to class per file 2019-04-14 23:37:52 +01:00
DiffEngine.php Upgrade phan config to 0.7.1 2019-09-04 08:20:53 +00:00
DifferenceEngine.php Don't calculate amount of inbetween revisions for MCR undo 2019-11-04 11:17:37 +01:00
DifferenceEngineSlotDiffRenderer.php SlotDiffRenderer: add utility method for parameter type checks 2018-09-24 23:09:18 -07:00
DiffFormatter.php Add missing & to @param documentation to match functon call 2017-08-11 18:47:46 +02:00
DiffOp.php Unsuppress other phan issues (part 4) 2019-08-31 17:13:39 +00:00
DiffOpAdd.php Split DairikiDiff to class per file 2019-04-14 23:37:52 +01:00
DiffOpChange.php Split DairikiDiff to class per file 2019-04-14 23:37:52 +01:00
DiffOpCopy.php Split DairikiDiff to class per file 2019-04-14 23:37:52 +01:00
DiffOpDelete.php Split DairikiDiff to class per file 2019-04-14 23:37:52 +01:00
RangeDifference.php Move class RangeDifference to own file 2019-03-08 23:29:14 +01:00
SlotDiffRenderer.php Add UnknownContentHandler. 2019-08-29 10:43:11 +00:00
TableDiffFormatter.php Use \u{00A0} instead of   or   2018-06-24 01:20:13 +00:00
TextSlotDiffRenderer.php Unsuppress another phan issue (part 7) 2019-09-03 17:19:21 +00:00
UnifiedDiffFormatter.php DiffFormatter: Don't mess with PHP output buffering 2016-01-27 19:31:17 -05:00
UnsupportedSlotDiffRenderer.php Add UnknownContentHandler. 2019-08-29 10:43:11 +00:00
WordAccumulator.php Use \u{00A0} instead of   or   2018-06-24 01:20:13 +00:00
WordLevelDiff.php Change @inheritdoc to @inheritDoc 2017-08-11 16:49:52 +02:00