As we convert the RevisionRecord to using Authority, we no longer need Title instances, so we can convert that to PageIdentity. Ideally, we'd part away from using Title at all, but: 1. For foreign wikis PageIdentity has stronger validation, so calling PageIdentity getId() on Title will break things. There's still a lot of code depending on lax Title guarantees, so we keep it. 2. A lot of code still depends on Title, so we try to pass it through even if we don't nesessarily need to, to save cost on recreating it later on. Bug: T271458 Depends-On: I287400b967b467ea18bebbb579e881a785a19158 Change-Id: I63d9807264d7e2295afef51fc9d982447f92fcbd
153 lines
4.3 KiB
PHP
153 lines
4.3 KiB
PHP
<?php
|
|
/**
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @file
|
|
* @author Daniel Kinzler
|
|
*/
|
|
|
|
use MediaWiki\Page\PageIdentity;
|
|
use MediaWiki\Page\PageIdentityValue;
|
|
use Wikimedia\Assert\ParameterAssertionException;
|
|
use Wikimedia\Assert\PreconditionException;
|
|
|
|
/**
|
|
* @covers MediaWiki\Page\PageIdentityValue
|
|
*
|
|
* @group Title
|
|
*/
|
|
class PageIdentityValueTest extends MediaWikiUnitTestCase {
|
|
|
|
public function goodConstructorProvider() {
|
|
return [
|
|
[ 0, NS_MAIN, 'Test', false ],
|
|
[ 7, NS_MAIN, 'Test', false ],
|
|
[ 3, NS_USER, 'Test', 'h2g2' ],
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @dataProvider goodConstructorProvider
|
|
*/
|
|
public function testConstruction( $pageId, $namespace, $dbKey, $wikiId ) {
|
|
$pageIdentity = new PageIdentityValue( $pageId, $namespace, $dbKey, $wikiId );
|
|
|
|
$this->assertSame( $wikiId, $pageIdentity->getWikiId() );
|
|
$this->assertSame( $pageId, $pageIdentity->getId( $wikiId ) );
|
|
$this->assertSame( $pageId > 0, $pageIdentity->exists() );
|
|
$this->assertSame( $namespace, $pageIdentity->getNamespace() );
|
|
$this->assertSame( $dbKey, $pageIdentity->getDBkey() );
|
|
|
|
$this->assertTrue( $pageIdentity->canExist() );
|
|
}
|
|
|
|
public function testGetIdFailsForForeignWiki() {
|
|
$pageIdentity = new PageIdentityValue( 7, NS_MAIN, 'Foo', 'h2g2' );
|
|
|
|
$this->expectException( PreconditionException::class );
|
|
$pageIdentity->getId();
|
|
}
|
|
|
|
public function badConstructorProvider() {
|
|
return [
|
|
[ -1, NS_MAIN, 'Test', false ],
|
|
[ 0, NS_MAIN, 'Test', 2.3 ],
|
|
[ 0, NS_SPECIAL, 'Test', false ],
|
|
[ 0, NS_MAIN, 'Foo#Bar', false ],
|
|
[ 0, NS_MAIN, 'Foo|Bar', false ],
|
|
[ 0, NS_MAIN, "Foo\tBar", false ],
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @dataProvider badConstructorProvider
|
|
*/
|
|
public function testConstructionErrors( $pageId, $namespace, $dbKey, $wikiId ) {
|
|
$this->expectException( ParameterAssertionException::class );
|
|
new PageIdentityValue( $pageId, $namespace, $dbKey, $wikiId );
|
|
}
|
|
|
|
public function provideToString() {
|
|
yield [
|
|
new PageIdentityValue( 5, 0, 'Foo', PageIdentity::LOCAL ),
|
|
'#5 [0:Foo]'
|
|
];
|
|
yield [
|
|
new PageIdentityValue( 0, 1, 'Bar_Baz', PageIdentity::LOCAL ),
|
|
'#0 [1:Bar_Baz]'
|
|
];
|
|
yield [
|
|
new PageIdentityValue( 7, 200, 'tea', 'codewiki' ),
|
|
'#7@codewiki [200:tea]'
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @dataProvider provideToString
|
|
*/
|
|
public function testToString( PageIdentityValue $value, $expected ) {
|
|
$this->assertSame(
|
|
$expected,
|
|
$value->__toString()
|
|
);
|
|
}
|
|
|
|
public function provideIsSamePageAs() {
|
|
yield [
|
|
new PageIdentityValue( 1, 0, 'Foo', PageIdentity::LOCAL ),
|
|
new PageIdentityValue( 1, 0, 'Foo', PageIdentity::LOCAL ),
|
|
true
|
|
];
|
|
yield [
|
|
new PageIdentityValue( 0, 1, 'Bar_Baz', PageIdentity::LOCAL ),
|
|
new PageIdentityValue( 0, 1, 'Bar_Baz', PageIdentity::LOCAL ),
|
|
true
|
|
];
|
|
yield [
|
|
new PageIdentityValue( 0, 0, 'Foo', PageIdentity::LOCAL ),
|
|
new PageIdentityValue( 0, 0, 'Foozz', PageIdentity::LOCAL ),
|
|
false
|
|
];
|
|
yield [
|
|
new PageIdentityValue( 0, 0, 'Foo', PageIdentity::LOCAL ),
|
|
new PageIdentityValue( 0, 1, 'Foo', PageIdentity::LOCAL ),
|
|
false
|
|
];
|
|
yield [
|
|
new PageIdentityValue( 1, 0, 'Foo', '' ),
|
|
new PageIdentityValue( 1, 0, 'Foo', 'bar' ),
|
|
false
|
|
];
|
|
yield [
|
|
new PageIdentityValue( 0, 0, 'Foo', '' ),
|
|
new PageIdentityValue( 0, 0, 'Foo', 'bar' ),
|
|
false
|
|
];
|
|
yield [
|
|
new PageIdentityValue( 3, 0, 'Foo', 'bar' ),
|
|
new PageIdentityValue( 3, 0, 'Foo', 'bar' ),
|
|
true
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @dataProvider provideIsSamePageAs
|
|
*/
|
|
public function testIsSamePageAs( PageIdentityValue $a, PageIdentityValue $b, $expected ) {
|
|
$this->assertSame( $expected, $a->isSamePageAs( $b ) );
|
|
$this->assertSame( $expected, $b->isSamePageAs( $a ) );
|
|
}
|
|
}
|