Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
wiki.techinc.nl/includes
History
daniel 855988fd0e LinkCache: soft deprecate addGoodLinkObj() 
addGoodLinkObj() has many optional arguments, but omitting them actually
means corrupting the cache.

Nearly all existing callers are in tests.
So LinkCacheTestTrait::addGoodLinkObject() was created only
for testing. It is better to have this method in the
trait, because building the row directly in each test
would make these tests brittle against schema changes.

The only usage in WMF production code was in WikiPage and has been
fixed.

Bug: T284955
Change-Id: I03a2bd9ed64fcc0281ee29a286c8db395a9e03d9
2021-09-10 16:00:02 +02:00
..
actions build: Update mediawiki/mediawiki-phan-config to 0.11.0 2021-09-07 17:19:05 +02:00
api Localisation updates from https://translatewiki.net. 2021-09-10 08:01:08 +02:00
auth Using @return never documentation on always-throw-function 2021-09-07 17:29:03 +02:00
block docs: Remove wrong null types 2021-08-26 21:42:03 +02:00
cache LinkCache: soft deprecate addGoodLinkObj() 2021-09-10 16:00:02 +02:00
changes build: Update mediawiki/mediawiki-phan-config to 0.11.0 2021-09-07 17:19:05 +02:00
changetags RevDelList: Rename reloadFromMaster to reloadFromPrimary 2021-09-03 20:16:18 +00:00
collation collation: Create CollationFactory service 2021-09-04 02:46:06 +02:00
compat
composer Update Legoktm's email address 2021-05-02 05:39:37 +00:00
config Introduce includes/Storage/PageUpdaterFactory 2021-07-19 12:15:26 +02:00
content Using @return never documentation on always-throw-function 2021-09-07 17:29:03 +02:00
context Revert "Use CsrfTokenSet as CSRF token source" 2021-08-05 15:48:26 -07:00
dao build: Updating dependencies 2021-07-22 03:36:05 +00:00
db Using @return never documentation on always-throw-function 2021-09-07 17:29:03 +02:00
debug DeprecationHelper: Support mocking and dynamic properties 2021-08-04 12:38:02 -07:00
deferred Merge "MWExceptionHandler: Rename rollbackMasterChangesAndLog to rollbackPrimaryChangesAndLog" 2021-09-07 16:31:08 +00:00
diff Using @return never documentation on always-throw-function 2021-09-07 17:29:03 +02:00
edit
editpage Cleanup mixed space/tab line indent 2021-09-04 00:52:31 +02:00
exception Merge "MWExceptionHandler::rollbackMasterChangesAndLog: Hard-deprecate, unused anywhere" 2021-09-08 20:52:42 +00:00
export build: Update mediawiki/mediawiki-phan-config to 0.11.0 2021-09-07 17:19:05 +02:00
externalstore Merge "ExternalStoreDB::getMaster: Hard deprecate now it's unused in prod" 2021-09-08 20:52:48 +00:00
filebackend Tag various new 'primary' methods as @since 1.37 2021-09-02 11:58:19 -07:00
filerepo Using @return never documentation on always-throw-function 2021-09-07 17:29:03 +02:00
gallery build: Update mediawiki/mediawiki-phan-config to 0.11.0 2021-09-07 17:19:05 +02:00
historyblob Post Revision-removal cleanup 2021-06-24 00:32:39 +00:00
Hook Remove PHPUnit hooks 2021-08-30 00:28:32 +02:00
HookContainer Cleanup mixed space/tab line indent 2021-09-04 00:52:31 +02:00
htmlform Using @return never documentation on always-throw-function 2021-09-07 17:29:03 +02:00
http Using @return never documentation on always-throw-function 2021-09-07 17:29:03 +02:00
import Merge "Same code style and formatting for exists-style SQL queries" 2021-08-24 17:44:17 +00:00
installer Localisation updates from https://translatewiki.net. 2021-09-10 08:01:08 +02:00
interwiki Use @deprecated annotation on hook interfaces, not functions 2021-05-17 23:00:40 +02:00
jobqueue MWExceptionHandler: Rename rollbackMasterChangesAndLog to rollbackPrimaryChangesAndLog 2021-09-03 17:36:34 -07:00
json FormatJson: Optimize encode() for supported PHP versions 2021-08-20 08:03:11 -04:00
language build: Update mediawiki/mediawiki-phan-config to 0.11.0 2021-09-07 17:19:05 +02:00
languages Cleanup mixed space/tab line indent 2021-09-04 00:52:31 +02:00
libs Merge "ILoadBalancer::forEachOpenMasterConnection: Hard deprecate now it's unused in prod" 2021-09-08 20:52:36 +00:00
linkeddata
linker Suppress LinkCache warning about "non-proper" pages 2021-07-27 20:51:42 +10:00
logging Using @return never documentation on always-throw-function 2021-09-07 17:29:03 +02:00
mail Fix various typos in documentation 2021-08-23 09:03:44 +00:00
media build: Update mediawiki/mediawiki-phan-config to 0.11.0 2021-09-07 17:19:05 +02:00
Message
Navigation Use Message::page instead of Message::title 2021-06-09 13:18:22 +00:00
objectcache Cleanup mixed space/tab line indent 2021-09-04 00:52:31 +02:00
page LinkCache: soft deprecate addGoodLinkObj() 2021-09-10 16:00:02 +02:00
pager TablePager: fix param documentation for formatValue() 2021-09-09 08:44:27 +02:00
ParamValidator/TypeDef Cleanup mixed space/tab line indent 2021-09-04 00:52:31 +02:00
parser Merge "Using @return never documentation on always-throw-function" 2021-09-08 03:12:06 +00:00
password Remove PasswordCannotMatchUsername password policy 2021-09-06 14:55:12 +00:00
Permissions SimpleAuthority: Fix ignored typo 2021-09-09 21:04:30 +01:00
poolcounter
preferences Rename four config variables to avoid 'blacklist' term 2021-09-08 23:32:29 +01:00
profiler profiler: Add 'running' option to ProfilerXhprof 2021-09-07 03:25:56 +01:00
rcfeed Fix some @stable for ... annotations to use @stable to ... 2021-07-08 02:54:59 +00:00
registration Merge "registration: Apply manifest v2 logic to hypothetical v3" 2021-09-10 06:47:36 +00:00
resourceloader Merge "resourceloader: pass $VARS.storeDisabled instead of .storeEnabled" 2021-09-09 19:20:59 +00:00
Rest Using @return never documentation on always-throw-function 2021-09-07 17:29:03 +02:00
Revision Using @return never documentation on always-throw-function 2021-09-07 17:29:03 +02:00
revisiondelete build: Update mediawiki/mediawiki-phan-config to 0.11.0 2021-09-07 17:19:05 +02:00
revisionlist build: Updating dependencies 2021-07-22 03:36:05 +00:00
search build: Update mediawiki/mediawiki-phan-config to 0.11.0 2021-09-07 17:19:05 +02:00
session Cleanup mixed space/tab line indent 2021-09-04 00:52:31 +02:00
shell shell: Fix $wgShellboxUrls by passing service name when creating BoxedCommand 2021-09-01 11:43:22 -07:00
site Various updates and fixes to PHPDoc documentation 2021-08-09 09:26:23 +02:00
skins Cleanup mixed space/tab line indent 2021-09-04 00:52:31 +02:00
sparql sparql: Replace deprecated Http::userAgent() in SparqlClient 2021-08-04 13:54:13 +00:00
specialpage Merge "Mark hidden tags on Special:Tags and show in RCFilters" 2021-09-10 08:54:20 +00:00
specials Merge "Mark hidden tags on Special:Tags and show in RCFilters" 2021-09-10 08:54:20 +00:00
Storage Merge "Make WikiPage a ProperPageIdentity" 2021-09-07 19:48:14 +00:00
templates
tidy Using @return never documentation on always-throw-function 2021-09-07 17:29:03 +02:00
title Allow using MediaWikiTitleCodec with errors in unit tests 2021-07-27 11:27:56 +00:00
upload Rename four config variables to avoid 'blacklist' term 2021-09-08 23:32:29 +01:00
user Merge "Make UserRightsProxy implement UserIdentity" 2021-09-09 16:27:04 +00:00
utils Using @return never documentation on always-throw-function 2021-09-07 17:29:03 +02:00
watcheditem Merge "Using @return never documentation on always-throw-function" 2021-09-08 03:12:06 +00:00
watchlist build: Updating dependencies 2021-07-22 03:36:05 +00:00
widget Remove unreachable code after exception/die/exit 2021-09-03 23:14:28 +00:00
xml Simplify else-branches after continue/break 2021-08-17 22:51:43 +02:00
.htaccess
ActorMigration.php Schema migration for revison_actor_temp table removal 2021-07-14 08:29:04 +10:00
ActorMigrationBase.php Schema migration for revison_actor_temp table removal 2021-07-14 08:29:04 +10:00
AjaxDispatcher.php ILoadBalancer/ILBFactory: Rename commitMasterChanges() to commitPrimaryChanges() 2021-09-02 11:27:10 -07:00
AjaxResponse.php
AutoLoader.php Merge "AutoLoader: Use ?? instead of multiple if-isset-else branches" 2021-08-12 02:05:25 +00:00
BadFileLookup.php
CategoriesRdf.php
Category.php Category: store ReadOnlyMode in constructor 2021-08-13 02:29:21 +02:00
CategoryViewer.php collation: Create CollationFactory service 2021-09-04 02:46:06 +02:00
CommentStore.php Fix various typos in documentation 2021-08-23 09:03:44 +00:00
CommentStoreComment.php
ConfiguredReadOnlyMode.php
ContentSecurityPolicy.php Remove comments that repeat the code 2021-06-02 08:03:09 +00:00
DefaultSettings.php Rename four config variables to avoid 'blacklist' term 2021-09-08 23:32:29 +01:00
Defines.php MW_VERSION also exists in 1.33.3 and 1.34.1 2021-08-19 06:54:29 +00:00
DeprecatedGlobal.php StubObject: add magic __get() and __set() 2021-09-04 05:37:25 +00:00
DerivativeRequest.php build: Update mediawiki/mediawiki-phan-config to 0.11.0 2021-09-07 17:19:05 +02:00
DevelopmentSettings.php Set $wgIncludejQueryMigrate to false as default 2021-08-29 02:09:35 +02:00
DummyLinker.php Post Revision-removal cleanup 2021-06-24 00:32:39 +00:00
EditPage.php Merge "Drop wgAjaxEditStash, deprecated in 1.36" 2021-09-07 16:45:22 +00:00
Emptiable.php
EventRelayerGroup.php
ExtensionInfo.php
FauxRequest.php Remove backward compatibility $_FILES from FauxRequest::getUpload 2021-05-16 18:27:35 +00:00
FauxRequestUpload.php
FauxResponse.php
FeedUtils.php Merge "Make use of Html class utility methods in a few places" 2021-08-31 15:39:39 +00:00
FileDeleteForm.php ILoadBalancer/ILBFactory: Rename rollbackMasterChanges to rollbackPrimaryChanges 2021-09-02 12:50:52 -07:00
ForeignResourceManager.php
ForkController.php Unbreak ForkController 2021-07-14 14:08:22 +02:00
FormOptions.php
GitInfo.php
GlobalFunctions.php build: Update mediawiki/mediawiki-phan-config to 0.11.0 2021-09-07 17:19:05 +02:00
HeaderCallback.php
Hooks.php Mark Hooks::runner() as @internal 2021-07-28 23:49:27 +00:00
Html.php Html::openElement() micro-optimisations 2021-08-02 18:10:59 +00:00
Linker.php Remove unneeded explicit true/false inside conditions 2021-08-17 21:52:34 +02:00
LinkFilter.php
ListToggle.php
MagicWord.php
MagicWordArray.php build: Updating dependencies 2021-07-22 03:36:05 +00:00
MagicWordFactory.php build: Updating dependencies 2021-07-22 03:36:05 +00:00
MediaWiki.php MWExceptionHandler: Rename rollbackMasterChangesAndLog to rollbackPrimaryChangesAndLog 2021-09-03 17:36:34 -07:00
MediaWikiServices.php Add BacklinkCacheFactory Service 2021-09-09 09:58:52 +01:00
MediaWikiVersionFetcher.php
MergeHistory.php Support fluent interface for StatusValue 2021-08-02 15:14:11 -04:00
MovePage.php collation: Create CollationFactory service 2021-09-04 02:46:06 +02:00
MWGrants.php Use array_fill_keys() instead of array_flip() if that reflects the developer's intention 2021-06-15 00:11:10 +00:00
MWNamespace.php Hard-deprecate some MWNamespace methods 2021-07-26 11:53:11 +00:00
MWTimestamp.php Split TimeCorrection parser into separate class 2021-05-07 10:43:09 -07:00
NoLocalSettings.php
OrderedStreamingForkController.php
OutputHandler.php
OutputPage.php Soft deprecate Skin::bottomScripts 2021-09-03 19:26:51 +00:00
PageProps.php PageProps: be prepared that PageIdentity is not proper title 2021-05-19 12:50:26 -07:00
PathRouter.php
PHPVersionCheck.php Restore PHP 4.0 compatibility to PHPVersionCheck 2021-06-07 08:24:11 -07:00
Pingback.php build: Updating dependencies 2021-07-22 03:36:05 +00:00
ProtectionForm.php Revert "Use CsrfTokenSet as CSRF token source" 2021-08-05 15:48:26 -07:00
ProxyLookup.php
RawMessage.php
ReadOnlyMode.php
ServiceWiring.php Merge "PageStore: Use LinkCache" 2021-09-09 20:04:47 +00:00
Setup.php Rename four config variables to avoid 'blacklist' term 2021-09-08 23:32:29 +01:00
SiteConfiguration.php Use array_fill_keys() instead of array_flip() if that reflects the developer's intention 2021-06-15 00:11:10 +00:00
SiteStats.php ILoadBalancer/ILBFactory: Rename hasOrMadeRecentMasterChanges to hasOrMadeRecentPrimaryChanges 2021-09-02 16:34:44 -07:00
SiteStatsInit.php Same code style and formatting for exists-style SQL queries 2021-08-12 11:37:58 +02:00
Status.php build: Updating dependencies 2021-07-22 03:36:05 +00:00
StreamFile.php Rename four config variables to avoid 'blacklist' term 2021-09-08 23:32:29 +01:00
StubObject.php StubObject: add magic __get() and __set() 2021-09-04 05:37:25 +00:00
StubUserLang.php Remove StubUserLang::findVariantLink 2021-05-15 12:51:26 -07:00
TemplateParser.php
TemplatesOnThisPageFormatter.php
Title.php Merge "title: Avoid calling TitleArray::current on empty iterator" 2021-09-09 21:35:27 +00:00
TitleArray.php docs: Declare UserArray/TitleArray as Iterator<User>/Iterator<Title> 2021-08-30 22:37:54 +02:00
TitleArrayFromResult.php docs: Declare UserArray/TitleArray as Iterator<User>/Iterator<Title> 2021-08-30 22:37:54 +02:00
TitleFactory.php build: Updating dependencies 2021-07-22 03:36:05 +00:00
TrackingCategories.php Use Message::page instead of Message::title 2021-06-09 13:18:22 +00:00
WebRequest.php WebRequest: Document getVal caveat and recommend getText or getRawVal 2021-08-23 23:43:10 +00:00
WebRequestUpload.php
WebResponse.php
WebStart.php Using @return never documentation on always-throw-function 2021-09-07 17:29:03 +02:00
WikiMap.php
WikiReference.php