HHVM does not support variadic arguments with type hints. This is mostly not a big problem, because we can just drop the type hint, but for some reason PHPUnit adds a type hint of "array" when it creates mocks, so a class with a variadic method can't be mocked (at least in some cases). As such, I left alone all the classes that seem like someone might like to mock them, like Title and User. If anyone wants to mock them in the future, they'll have to switch back to func_get_args(). Some of the changes are definitely safe, like functions and test classes. In most cases, func_get_args() (and/or func_get_arg(), func_num_args() ) were only present because the code was written before we required PHP 5.6, and writing them as variadic functions is strictly superior. In some cases I left them alone, aside from HHVM compatibility: * Forwarding all arguments to another function. It's useful to keep func_get_args() here where we want to keep the list of expected arguments and their meanings in the function signature line for documentation purposes, but don't want to copy-paste a long line of argument names. * Handling deprecated calling conventions. * One or two miscellaneous cases where we're basically using the arguments individually but want to use them as an array as well for some reason. Change-Id: I066ec95a7beb7c0665146195a08e7cce1222c788
158 lines
4.9 KiB
PHP
158 lines
4.9 KiB
PHP
<?php
|
|
/**
|
|
* Copyright © 2013 Yuri Astrakhan "<Firstname><Lastname>@gmail.com"
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @file
|
|
*/
|
|
|
|
/** This class has some common functionality for testing query module
|
|
*/
|
|
abstract class ApiQueryTestBase extends ApiTestCase {
|
|
|
|
const PARAM_ASSERT = <<<STR
|
|
Each parameter must be an array of two elements,
|
|
first - an array of params to the API call,
|
|
and the second array - expected results as returned by the API
|
|
STR;
|
|
|
|
/**
|
|
* Merges all requests parameter + expected values into one
|
|
* @param array ...$arrays List of arrays, each of which contains exactly two
|
|
* @return array
|
|
*/
|
|
protected function merge( ...$arrays ) {
|
|
$request = [];
|
|
$expected = [];
|
|
foreach ( $arrays as $array ) {
|
|
list( $req, $exp ) = $this->validateRequestExpectedPair( $array );
|
|
$request = array_merge_recursive( $request, $req );
|
|
$this->mergeExpected( $expected, $exp );
|
|
}
|
|
|
|
return [ $request, $expected ];
|
|
}
|
|
|
|
/**
|
|
* Check that the parameter is a valid two element array,
|
|
* with the first element being API request and the second - expected result
|
|
* @param array $v
|
|
* @return array
|
|
*/
|
|
private function validateRequestExpectedPair( $v ) {
|
|
$this->assertInternalType( 'array', $v, self::PARAM_ASSERT );
|
|
$this->assertEquals( 2, count( $v ), self::PARAM_ASSERT );
|
|
$this->assertArrayHasKey( 0, $v, self::PARAM_ASSERT );
|
|
$this->assertArrayHasKey( 1, $v, self::PARAM_ASSERT );
|
|
$this->assertInternalType( 'array', $v[0], self::PARAM_ASSERT );
|
|
$this->assertInternalType( 'array', $v[1], self::PARAM_ASSERT );
|
|
|
|
return $v;
|
|
}
|
|
|
|
/**
|
|
* Recursively merges the expected values in the $item into the $all
|
|
* @param array &$all
|
|
* @param array $item
|
|
*/
|
|
private function mergeExpected( &$all, $item ) {
|
|
foreach ( $item as $k => $v ) {
|
|
if ( array_key_exists( $k, $all ) ) {
|
|
if ( is_array( $all[$k] ) ) {
|
|
$this->mergeExpected( $all[$k], $v );
|
|
} else {
|
|
$this->assertEquals( $all[$k], $v );
|
|
}
|
|
} else {
|
|
$all[$k] = $v;
|
|
}
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Checks that the request's result matches the expected results.
|
|
* Assumes no rawcontinue and a complete batch.
|
|
* @param array $values Array is a two element array( request, expected_results )
|
|
* @param array|null $session
|
|
* @param bool $appendModule
|
|
* @param User|null $user
|
|
*/
|
|
protected function check( $values, array $session = null,
|
|
$appendModule = false, User $user = null
|
|
) {
|
|
list( $req, $exp ) = $this->validateRequestExpectedPair( $values );
|
|
if ( !array_key_exists( 'action', $req ) ) {
|
|
$req['action'] = 'query';
|
|
}
|
|
foreach ( $req as &$val ) {
|
|
if ( is_array( $val ) ) {
|
|
$val = implode( '|', array_unique( $val ) );
|
|
}
|
|
}
|
|
$result = $this->doApiRequest( $req, $session, $appendModule, $user );
|
|
$this->assertResult( [ 'batchcomplete' => true, 'query' => $exp ], $result[0], $req );
|
|
}
|
|
|
|
protected function assertResult( $exp, $result, $message = '' ) {
|
|
try {
|
|
$exp = self::sanitizeResultArray( $exp );
|
|
$result = self::sanitizeResultArray( $result );
|
|
$this->assertEquals( $exp, $result );
|
|
} catch ( PHPUnit_Framework_ExpectationFailedException $e ) {
|
|
if ( is_array( $message ) ) {
|
|
$message = http_build_query( $message );
|
|
}
|
|
|
|
// FIXME: once we migrate to phpunit 4.1+, hardcode ComparisonFailure exception use
|
|
$compEx = 'SebastianBergmann\Comparator\ComparisonFailure';
|
|
if ( !class_exists( $compEx ) ) {
|
|
$compEx = 'PHPUnit_Framework_ComparisonFailure';
|
|
}
|
|
|
|
throw new PHPUnit_Framework_ExpectationFailedException(
|
|
$e->getMessage() . "\nRequest: $message",
|
|
new $compEx(
|
|
$exp,
|
|
$result,
|
|
print_r( $exp, true ),
|
|
print_r( $result, true ),
|
|
false,
|
|
$e->getComparisonFailure()->getMessage() . "\nRequest: $message"
|
|
)
|
|
);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Recursively ksorts a result array and removes any 'pageid' keys.
|
|
* @param array $result
|
|
* @return array
|
|
*/
|
|
private static function sanitizeResultArray( $result ) {
|
|
unset( $result['pageid'] );
|
|
foreach ( $result as $key => $value ) {
|
|
if ( is_array( $value ) ) {
|
|
$result[$key] = self::sanitizeResultArray( $value );
|
|
}
|
|
}
|
|
|
|
// Sort the result by keys, then take advantage of how array_merge will
|
|
// renumber numeric keys while leaving others alone.
|
|
ksort( $result );
|
|
return array_merge( $result );
|
|
}
|
|
}
|