wiki.techinc.nl/includes/site/SiteImporter.php
Tim Starling ca71e69fc6 Try not to discard Excimer timeout exceptions
Don't catch and discard exceptions from the RequestTimeout library,
except when the exception is properly handled and the code seems to be
trying to wrap things up.

In most cases the exception is rethrown. Ideally it should instead be
done by narrowing the catch, and this was feasible in a few cases. But
sometimes the exception being caught is an instance of the base class
(notably DateTime::__construct()). Often Exception is the root of the
hierarchy of exceptions being thrown and so is the obvious catch-all.

Notes on specific callers:

* In the case of ResourceLoader::respond(), exceptions were caught for API
  correctness, but processing continued. I added an outer try block for
  timeout handling so that termination would be more prompt.
* In LCStoreCDB the Exception being caught was Cdb\Exception not
  \Exception. I added an alias to avoid confusion.
* In ImageGallery I added a special exception class.
* In Message::__toString() the rationale for catching disappears
  in PHP 7.4.0+, so I added a PHP version check.
* In PoolCounterRedis, let the shutdown function do its thing, but
  rethrow the exception for logging.

Change-Id: I4c3770b9efc76a1ce42ed9f59329c36de04d657c
2022-02-02 16:27:44 +11:00

275 lines
7 KiB
PHP

<?php
use Wikimedia\RequestTimeout\TimeoutException;
/**
* Utility for importing site entries from XML.
* For the expected format of the input, see docs/sitelist.md and docs/sitelist-1.0.xsd.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
* http://www.gnu.org/copyleft/gpl.html
*
* @since 1.25
*
* @file
* @ingroup Site
*
* @license GPL-2.0-or-later
* @author Daniel Kinzler
*/
class SiteImporter {
/**
* @var SiteStore
*/
private $store;
/**
* @var callable|null
*/
private $exceptionCallback;
/**
* @param SiteStore $store
*/
public function __construct( SiteStore $store ) {
$this->store = $store;
}
/**
* @return callable
*/
public function getExceptionCallback() {
return $this->exceptionCallback;
}
/**
* @param callable $exceptionCallback
*/
public function setExceptionCallback( $exceptionCallback ) {
$this->exceptionCallback = $exceptionCallback;
}
/**
* @param string $file
*/
public function importFromFile( $file ) {
$xml = file_get_contents( $file );
if ( $xml === false ) {
throw new RuntimeException( 'Failed to read ' . $file . '!' );
}
$this->importFromXML( $xml );
}
/**
* @param string $xml
*
* @throws InvalidArgumentException
*/
public function importFromXML( $xml ) {
$document = new DOMDocument();
$oldLibXmlErrors = libxml_use_internal_errors( true );
// phpcs:ignore Generic.PHP.NoSilencedErrors -- suppress deprecation per T268847
$oldDisable = @libxml_disable_entity_loader( true );
$ok = $document->loadXML( $xml, LIBXML_NONET );
if ( !$ok ) {
$errors = libxml_get_errors();
libxml_use_internal_errors( $oldLibXmlErrors );
// phpcs:ignore Generic.PHP.NoSilencedErrors
@libxml_disable_entity_loader( $oldDisable );
foreach ( $errors as $error ) {
/** @var LibXMLError $error */
throw new InvalidArgumentException(
'Malformed XML: ' . $error->message . ' in line ' . $error->line
);
}
throw new InvalidArgumentException( 'Malformed XML!' );
}
libxml_use_internal_errors( $oldLibXmlErrors );
// phpcs:ignore Generic.PHP.NoSilencedErrors
@libxml_disable_entity_loader( $oldDisable );
$this->importFromDOM( $document->documentElement );
}
/**
* @param DOMElement $root
*/
private function importFromDOM( DOMElement $root ) {
$sites = $this->makeSiteList( $root );
$this->store->saveSites( $sites );
}
/**
* @param DOMElement $root
*
* @return Site[]
*/
private function makeSiteList( DOMElement $root ) {
$sites = [];
// Old sites, to get the row IDs that correspond to the global site IDs.
// TODO: Get rid of internal row IDs, they just get in the way. Get rid of ORMRow, too.
$oldSites = $this->store->getSites();
$current = $root->firstChild;
while ( $current ) {
if ( $current instanceof DOMElement && $current->tagName === 'site' ) {
try {
$site = $this->makeSite( $current );
$key = $site->getGlobalId();
if ( $oldSites->hasSite( $key ) ) {
$oldSite = $oldSites->getSite( $key );
$site->setInternalId( $oldSite->getInternalId() );
}
$sites[$key] = $site;
} catch ( TimeoutException $e ) {
throw $e;
} catch ( Exception $ex ) {
$this->handleException( $ex );
}
}
$current = $current->nextSibling;
}
return $sites;
}
/**
* @param DOMElement $siteElement
*
* @return Site
* @throws InvalidArgumentException
*/
public function makeSite( DOMElement $siteElement ) {
if ( $siteElement->tagName !== 'site' ) {
throw new InvalidArgumentException( 'Expected <site> tag, found ' . $siteElement->tagName );
}
$type = $this->getAttributeValue( $siteElement, 'type', Site::TYPE_UNKNOWN );
$site = Site::newForType( $type );
$site->setForward( $this->hasChild( $siteElement, 'forward' ) );
$site->setGlobalId( $this->getChildText( $siteElement, 'globalid' ) );
$site->setGroup( $this->getChildText( $siteElement, 'group', Site::GROUP_NONE ) );
$site->setSource( $this->getChildText( $siteElement, 'source', Site::SOURCE_LOCAL ) );
$pathTags = $siteElement->getElementsByTagName( 'path' );
for ( $i = 0; $i < $pathTags->length; $i++ ) {
$pathElement = $pathTags->item( $i );
'@phan-var DOMElement $pathElement';
$pathType = $this->getAttributeValue( $pathElement, 'type' );
$path = $pathElement->textContent;
$site->setPath( $pathType, $path );
}
$idTags = $siteElement->getElementsByTagName( 'localid' );
for ( $i = 0; $i < $idTags->length; $i++ ) {
$idElement = $idTags->item( $i );
'@phan-var DOMElement $idElement';
$idType = $this->getAttributeValue( $idElement, 'type' );
$id = $idElement->textContent;
$site->addLocalId( $idType, $id );
}
// @todo: import <data>
// @todo: import <config>
return $site;
}
/**
* @param DOMElement $element
* @param string $name
* @param string|null|bool $default
*
* @return null|string
* @throws MWException If the attribute is not found and no default is provided
*/
private function getAttributeValue( DOMElement $element, $name, $default = false ) {
$node = $element->getAttributeNode( $name );
if ( !$node ) {
if ( $default !== false ) {
return $default;
} else {
throw new MWException(
'Required ' . $name . ' attribute not found in <' . $element->tagName . '> tag'
);
}
}
return $node->textContent;
}
/**
* @param DOMElement $element
* @param string $name
* @param string|null|bool $default
*
* @return null|string
* @throws MWException If the child element is not found and no default is provided
*/
private function getChildText( DOMElement $element, $name, $default = false ) {
$elements = $element->getElementsByTagName( $name );
if ( $elements->length < 1 ) {
if ( $default !== false ) {
return $default;
} else {
throw new MWException(
'Required <' . $name . '> tag not found inside <' . $element->tagName . '> tag'
);
}
}
$node = $elements->item( 0 );
return $node->textContent;
}
/**
* @param DOMElement $element
* @param string $name
*
* @return bool
* @throws MWException
*/
private function hasChild( DOMElement $element, $name ) {
return $this->getChildText( $element, $name, null ) !== null;
}
/**
* @param Exception $ex
*/
private function handleException( Exception $ex ) {
if ( $this->exceptionCallback ) {
call_user_func( $this->exceptionCallback, $ex );
} else {
wfLogWarning( $ex->getMessage() );
}
}
}