c05bdcee8b
isset() does two things: It checks if a variable (or array element) is declared, *and* it checks if it is null. If a variable is null, isset() fails as if the variable was not set. All these additional null checks are dead code. Change-Id: I71e8cc26dac839c9d081bf00b4164b7b5147e586
61 lines
1.3 KiB
PHP
61 lines
1.3 KiB
PHP
<?php
|
|
|
|
/**
|
|
* Verifies that special page aliases are valid, with no slashes.
|
|
*
|
|
* @group Language
|
|
* @group SpecialPageAliases
|
|
* @group SystemTest
|
|
* @group medium
|
|
* @todo This should be a structure test
|
|
*
|
|
* @author Katie Filbert < aude.wiki@gmail.com >
|
|
*/
|
|
class SpecialPageAliasTest extends \MediaWikiUnitTestCase {
|
|
|
|
/**
|
|
* @coversNothing
|
|
* @dataProvider validSpecialPageAliasesProvider
|
|
*/
|
|
public function testValidSpecialPageAliases( $code, $specialPageAliases ) {
|
|
foreach ( $specialPageAliases as $specialPage => $aliases ) {
|
|
foreach ( $aliases as $alias ) {
|
|
$msg = "$specialPage alias '$alias' in $code is valid with no slashes";
|
|
$this->assertRegExp( '/^[^\/]*$/', $msg );
|
|
}
|
|
}
|
|
}
|
|
|
|
public function validSpecialPageAliasesProvider() {
|
|
$codes = array_keys( Language::fetchLanguageNames( null, 'mwfile' ) );
|
|
|
|
$data = [];
|
|
|
|
foreach ( $codes as $code ) {
|
|
$specialPageAliases = $this->getSpecialPageAliases( $code );
|
|
|
|
if ( $specialPageAliases !== [] ) {
|
|
$data[] = [ $code, $specialPageAliases ];
|
|
}
|
|
}
|
|
|
|
return $data;
|
|
}
|
|
|
|
/**
|
|
* @param string $code
|
|
*
|
|
* @return array
|
|
*/
|
|
protected function getSpecialPageAliases( $code ) {
|
|
$file = Language::getMessagesFileName( $code );
|
|
|
|
if ( is_readable( $file ) ) {
|
|
include $file;
|
|
return $specialPageAliases ?? [];
|
|
}
|
|
|
|
return [];
|
|
}
|
|
|
|
}
|