1e9c361960
It's unreasonable to expect newbies to know that "bug 12345" means "Task T14345" except where it doesn't, so let's just standardise on the real numbers. Change-Id: I46261416f7603558dceb76ebe695a5cac274e417
107 lines
2.5 KiB
PHP
107 lines
2.5 KiB
PHP
<?php
|
|
|
|
/**
|
|
* @group Database
|
|
*
|
|
* @covers UploadStash
|
|
*/
|
|
class UploadStashTest extends MediaWikiTestCase {
|
|
/**
|
|
* @var TestUser[] Array of UploadStashTestUser
|
|
*/
|
|
public static $users;
|
|
|
|
/**
|
|
* @var string
|
|
*/
|
|
private $bug29408File;
|
|
|
|
protected function setUp() {
|
|
parent::setUp();
|
|
|
|
// Setup a file for T31408
|
|
$this->bug29408File = wfTempDir() . '/bug29408';
|
|
file_put_contents( $this->bug29408File, "\x00" );
|
|
|
|
self::$users = [
|
|
'sysop' => new TestUser(
|
|
'Uploadstashtestsysop',
|
|
'Upload Stash Test Sysop',
|
|
'upload_stash_test_sysop@example.com',
|
|
[ 'sysop' ]
|
|
),
|
|
'uploader' => new TestUser(
|
|
'Uploadstashtestuser',
|
|
'Upload Stash Test User',
|
|
'upload_stash_test_user@example.com',
|
|
[]
|
|
)
|
|
];
|
|
}
|
|
|
|
protected function tearDown() {
|
|
if ( file_exists( $this->bug29408File . "." ) ) {
|
|
unlink( $this->bug29408File . "." );
|
|
}
|
|
|
|
if ( file_exists( $this->bug29408File ) ) {
|
|
unlink( $this->bug29408File );
|
|
}
|
|
|
|
parent::tearDown();
|
|
}
|
|
|
|
/**
|
|
* @todo give this test a real name explaining what is being tested here
|
|
*/
|
|
public function testBug29408() {
|
|
$this->setMwGlobals( 'wgUser', self::$users['uploader']->getUser() );
|
|
|
|
$repo = RepoGroup::singleton()->getLocalRepo();
|
|
$stash = new UploadStash( $repo );
|
|
|
|
// Throws exception caught by PHPUnit on failure
|
|
$file = $stash->stashFile( $this->bug29408File );
|
|
// We'll never reach this point if we hit T31408
|
|
$this->assertTrue( true, 'Unrecognized file without extension' );
|
|
|
|
$stash->removeFile( $file->getFileKey() );
|
|
}
|
|
|
|
public static function provideInvalidRequests() {
|
|
return [
|
|
'Check failure on bad wpFileKey' =>
|
|
[ new FauxRequest( [ 'wpFileKey' => 'foo' ] ) ],
|
|
'Check failure on bad wpSessionKey' =>
|
|
[ new FauxRequest( [ 'wpSessionKey' => 'foo' ] ) ],
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @dataProvider provideInvalidRequests
|
|
*/
|
|
public function testValidRequestWithInvalidRequests( $request ) {
|
|
$this->assertFalse( UploadFromStash::isValidRequest( $request ) );
|
|
}
|
|
|
|
public static function provideValidRequests() {
|
|
return [
|
|
'Check good wpFileKey' =>
|
|
[ new FauxRequest( [ 'wpFileKey' => 'testkey-test.test' ] ) ],
|
|
'Check good wpSessionKey' =>
|
|
[ new FauxRequest( [ 'wpFileKey' => 'testkey-test.test' ] ) ],
|
|
'Check key precedence' =>
|
|
[ new FauxRequest( [
|
|
'wpFileKey' => 'testkey-test.test',
|
|
'wpSessionKey' => 'foo'
|
|
] ) ],
|
|
];
|
|
}
|
|
/**
|
|
* @dataProvider provideValidRequests
|
|
*/
|
|
public function testValidRequestWithValidRequests( $request ) {
|
|
$this->assertTrue( UploadFromStash::isValidRequest( $request ) );
|
|
}
|
|
|
|
}
|