27a1d1151a
I've never liked how HTMLForm guesses the method names that return each field's HTML based on the $displayFormat property, for example `$displayFormat === 'div'` resulting in using `->getDiv()`. Recently this mechanism resulted in CodexHTMLForm lying about its display format to get the desired result. Instead, explicitly switch based on the display format and call the appropriate method, and override this in subclasses when using subclasses. Change-Id: I91b802ac63622e3b592be589d89ea11117a616f8
68 lines
1.8 KiB
PHP
68 lines
1.8 KiB
PHP
<?php
|
|
|
|
/**
|
|
* HTML form generation using Codex components.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @file
|
|
*/
|
|
|
|
use MediaWiki\Html\Html;
|
|
|
|
/**
|
|
* Codex based HTML form
|
|
*
|
|
* @since 1.41
|
|
*/
|
|
class CodexHTMLForm extends HTMLForm {
|
|
|
|
protected $displayFormat = 'codex';
|
|
|
|
public static function loadInputFromParameters( $fieldname, $descriptor,
|
|
HTMLForm $parent = null
|
|
) {
|
|
$field = parent::loadInputFromParameters( $fieldname, $descriptor, $parent );
|
|
$field->setShowEmptyLabel( false );
|
|
return $field;
|
|
}
|
|
|
|
public function getHTML( $submitResult ) {
|
|
$this->getOutput()->addModuleStyles( [
|
|
'codex-styles',
|
|
] );
|
|
|
|
return parent::getHTML( $submitResult );
|
|
}
|
|
|
|
/**
|
|
* @inheritDoc
|
|
*/
|
|
protected function formatField( HTMLFormField $field, $value ) {
|
|
// The "cdx-..." classes are added magically in the Html class. :(
|
|
return $field->getVForm( $value );
|
|
}
|
|
|
|
protected function getFormAttributes() {
|
|
$attribs = parent::getFormAttributes();
|
|
$attribs['class'] = [ 'mw-htmlform', 'mw-htmlform-codex' ];
|
|
return $attribs;
|
|
}
|
|
|
|
public function wrapForm( $html ) {
|
|
return Html::rawElement( 'form', $this->getFormAttributes(), $html );
|
|
}
|
|
}
|