wiki.techinc.nl/includes/changes
Tim Starling 95bd40b25c In query builders, use insertInto() and deleteFrom() instead of insert() and delete()
The design principle for SelectQueryBuilder was to make the chained
builder calls look as much like SQL as possible, so that developers
could leverage their knowledge of SQL to understand what the query
builder is doing.

That's why SelectQueryBuilder::select() takes a list of fields, and by
the same principle, it makes sense for UpdateQueryBuilder::update() to
take a table. However with "insert" and "delete", the SQL designers
chose to add prepositions "into" and "from", and I think it makes sense
to follow that here.

In terms of natural language, we update a table, but we don't delete a
table, or insert a table. We delete rows from a table, or insert rows
into a table. The table is not the object of the verb.

So, add insertInto() as an alias for insert(), and add deleteFrom() as
an alias for delete(). Use the new methods in MW core callers where
PHPStorm knows the type.

Change-Id: Idb327a54a57a0fb2288ea067472c1e9727016000
2023-09-08 10:16:08 +10:00
..
Hook Reorg: Namespace the Title class 2023-03-02 08:46:53 -05:00
CategoryMembershipChange.php Consistently use LogicException for test-only methods 2023-07-22 16:21:42 +00:00
ChangesFeed.php Reorg: Namespace the Title class 2023-03-02 08:46:53 -05:00
ChangesList.php ChangesList: Cache user links 2023-08-20 16:55:58 +02:00
ChangesListBooleanFilter.php Reorg: Move HTML-related classes out of includes/ to Html/ 2023-02-16 20:40:01 +01:00
ChangesListBooleanFilterGroup.php Reorg: Move HTML-related classes out of includes/ to Html/ 2023-02-16 20:40:01 +01:00
ChangesListFilter.php Reorg: Move HTML-related classes out of includes/ to Html/ 2023-02-16 20:40:01 +01:00
ChangesListFilterGroup.php Reorg: Move HTML-related classes out of includes/ to Html/ 2023-02-16 20:40:01 +01:00
ChangesListStringOptionsFilter.php Reorg: Move HTML-related classes out of includes/ to Html/ 2023-02-16 20:40:01 +01:00
ChangesListStringOptionsFilterGroup.php Reorg: Move HTML-related classes out of includes/ to Html/ 2023-02-16 20:40:01 +01:00
EnhancedChangesList.php EnhancedChangesList: Use HTML/CSS for collapsing 2023-07-13 23:12:45 +00:00
OldChangesList.php Reorg: Move HTML-related classes out of includes/ to Html/ 2023-02-16 20:40:01 +01:00
RCCacheEntry.php
RCCacheEntryFactory.php mark various anonymous functions as static 2023-08-22 19:38:38 +00:00
RecentChange.php In query builders, use insertInto() and deleteFrom() instead of insert() and delete() 2023-09-08 10:16:08 +10:00