95d75e831a
These are the same as taint-check's MediaWikiSecurityCheckPlugin.php. The notable exception is methods in WebRequest that were previously hardcoded as returning a safe value. This was a consequence of said methods return safe types (e.g., int, bool). Instead of adding taint-check annotations, add return typehints instead, which let taint-check remove any taintedness. Fix some taint-check issues that were previously not spotted or whose suppressions were removed in other patches. Also fix the following bugs spotted by phan thanks to the type hints: - SpecialExport did not have explicit handling of null $depth, and just returned 0 because null fails both the < and the > comparisons. - Improve documentation of params and props in ProtectedPagesPager. SpecialProtectedPages can pass null $namespace and $size. - Remove unused parameter from SpecialProtectedPages::showOptions, of which $ns and $size were not documented as nullable. - Add FIXMEs in SpecialVersion about very inconsistent escaping. Bug: T321806 Change-Id: I726f528856614c92329683a0ad8936a42e262748 |
||
|---|---|---|
| .. | ||
| Hook | ||
| TextDiffer | ||
| DifferenceEngine.php | ||
| DifferenceEngineSlotDiffRenderer.php | ||
| IncompatibleDiffTypesException.php | ||
| SlotDiffRenderer.php | ||
| TextSlotDiffRenderer.php | ||
| UnsupportedSlotDiffRenderer.php | ||