9632dfb041
This moves the implementation of ParserOutput::addTrackingCategory() to the TrackingCategories class as a non-static method. This makes invocation from ParserOutput awkward, but when invoking as Parser::addTrackingCategory() all the necessary services are available. As a result, we've also soft-deprecated ParserOutput::addTrackingCategory(); new users should use the TrackingCategories::addTrackingCategory() method, or else Parser::addTrackingCategory() if the parser object is available. The Parser class is already kind of bloated as it is (alas), but there aren't too many callsites which invoke ParserOutput::addTrackingCategory() and don't have the corresponding Parser object handy; see: https://codesearch.wmcloud.org/search/?q=%5BOo%5Dutput%28%5C%28%5C%29%29%3F-%3EaddTrackingCategory%5C%28&i=nope&files=&excludeFiles=&repos= Change-Id: I697ce188a912e445a6a748121575548e79aabac6
96 lines
3.1 KiB
PHP
96 lines
3.1 KiB
PHP
<?php
|
|
|
|
use MediaWiki\BadFileLookup;
|
|
use MediaWiki\Config\ServiceOptions;
|
|
use MediaWiki\Http\HttpRequestFactory;
|
|
use MediaWiki\Languages\LanguageConverterFactory;
|
|
use MediaWiki\Linker\LinkRendererFactory;
|
|
use MediaWiki\SpecialPage\SpecialPageFactory;
|
|
use MediaWiki\Tidy\TidyDriverBase;
|
|
use MediaWiki\User\UserFactory;
|
|
use MediaWiki\User\UserOptionsLookup;
|
|
use Wikimedia\TestingAccessWrapper;
|
|
|
|
/**
|
|
* @covers ParserFactory
|
|
*/
|
|
class ParserFactoryTest extends MediaWikiUnitTestCase {
|
|
private function createFactory() {
|
|
$options = $this->getMockBuilder( ServiceOptions::class )
|
|
->disableOriginalConstructor()
|
|
->onlyMethods( [ 'assertRequiredOptions', 'get' ] )->getMock();
|
|
|
|
$options->expects( $this->never() )
|
|
->method( $this->anythingBut( 'assertRequiredOptions', 'get' ) );
|
|
|
|
$this->assertInstanceOf( ServiceOptions::class, $options );
|
|
|
|
// Stub out a MagicWordFactory so the Parser can initialize its
|
|
// function hooks when it is created.
|
|
$mwFactory = $this->getMockBuilder( MagicWordFactory::class )
|
|
->disableOriginalConstructor()
|
|
->onlyMethods( [ 'get', 'getVariableIDs' ] )
|
|
->getMock();
|
|
$mwFactory
|
|
->method( 'get' )->will( $this->returnCallback( function ( $arg ) {
|
|
$mw = $this->getMockBuilder( MagicWord::class )
|
|
->disableOriginalConstructor()
|
|
->onlyMethods( [ 'getSynonyms' ] )
|
|
->getMock();
|
|
$mw->method( 'getSynonyms' )->willReturn( [] );
|
|
return $mw;
|
|
} ) );
|
|
$mwFactory
|
|
->method( 'getVariableIDs' )->willReturn( [] );
|
|
|
|
$factory = new ParserFactory(
|
|
$options,
|
|
$mwFactory,
|
|
$this->createNoOpMock( Language::class ),
|
|
"",
|
|
$this->createNoOpMock( SpecialPageFactory::class ),
|
|
$this->createNoOpMock( LinkRendererFactory::class ),
|
|
$this->createNoOpMock( NamespaceInfo::class ),
|
|
new TestLogger(),
|
|
$this->createNoOpMock( BadFileLookup::class ),
|
|
$this->createNoOpMock( LanguageConverterFactory::class ),
|
|
$this->createHookContainer(),
|
|
$this->createNoOpMock( TidyDriverBase::class ),
|
|
$this->createNoOpMock( WANObjectCache::class ),
|
|
$this->createNoOpMock( UserOptionsLookup::class ),
|
|
$this->createNoOpMock( UserFactory::class ),
|
|
$this->createNoOpMock( TitleFormatter::class ),
|
|
$this->createNoOpMock( HttpRequestFactory::class ),
|
|
$this->createNoOpMock( TrackingCategories::class )
|
|
);
|
|
return $factory;
|
|
}
|
|
|
|
/**
|
|
* @covers ParserFactory::__construct
|
|
*/
|
|
public function testConstructor() {
|
|
$factory = $this->createFactory();
|
|
$this->assertNotNull( $factory, "Factory should be created correctly" );
|
|
}
|
|
|
|
/**
|
|
* @covers ParserFactory::create
|
|
*/
|
|
public function testCreate() {
|
|
$factory = $this->createFactory();
|
|
$parser = $factory->create();
|
|
$this->assertNotNull( $factory, "Factory should be created correctly" );
|
|
$this->assertNotNull( $parser, "Factory should create parser correctly" );
|
|
$this->assertInstanceOf( Parser::class, $parser );
|
|
|
|
$parserWrapper = TestingAccessWrapper::newFromObject( $parser );
|
|
$factoryWrapper = TestingAccessWrapper::newFromObject( $factory );
|
|
$this->assertSame(
|
|
$factoryWrapper->languageConverterFactory, $parserWrapper->languageConverterFactory
|
|
);
|
|
$this->assertSame(
|
|
$factory, $parserWrapper->factory
|
|
);
|
|
}
|
|
}
|