9c57ea2b7f
This patch tries to make assertions in tests more readable by using more self-documenting assertions as provided by modern PHPUnit versions. Among a few others, these two main changes are done: * I found a lot of assertions with the expected value being the *second* parameter. I did not changed all of them. Only some that can be replaced with assertNull() and such. * I try to replace all `assertTrue( is_…() )` with dedicated assertions. Change-Id: I1fc72188fbd0edacf13886e7f9a9eacbd85f13c2
52 lines
1.3 KiB
PHP
52 lines
1.3 KiB
PHP
<?php
|
|
|
|
/**
|
|
* Modelled on Sebastian Bergmann's PHPUnit_Extensions_PhptTestCase class.
|
|
*
|
|
* @see https://github.com/sebastianbergmann/phpunit/blob/master/src/Extensions/PhptTestCase.php
|
|
* @author Sam Smith <samsmith@wikimedia.org>
|
|
* @coversNothing
|
|
*/
|
|
class LessFileCompilationTest extends ResourceLoaderTestCase {
|
|
|
|
/**
|
|
* @var string
|
|
*/
|
|
protected $file;
|
|
|
|
/**
|
|
* @var ResourceLoaderModule The ResourceLoader module that contains
|
|
* the file
|
|
*/
|
|
protected $module;
|
|
|
|
/**
|
|
* @param string $file
|
|
* @param ResourceLoaderModule $module The ResourceLoader module that
|
|
* contains the file
|
|
*/
|
|
public function __construct( $file, ResourceLoaderModule $module ) {
|
|
parent::__construct( 'testLessFileCompilation' );
|
|
|
|
$this->file = $file;
|
|
$this->module = $module;
|
|
}
|
|
|
|
public function testLessFileCompilation() {
|
|
$thisString = $this->toString();
|
|
$this->assertIsReadable( $this->file, "$thisString must refer to a readable file" );
|
|
|
|
$rlContext = $this->getResourceLoaderContext();
|
|
|
|
// Bleh
|
|
$method = new ReflectionMethod( $this->module, 'compileLessFile' );
|
|
$method->setAccessible( true );
|
|
$this->assertNotNull( $method->invoke( $this->module, $this->file, $rlContext ) );
|
|
}
|
|
|
|
public function toString() : string {
|
|
$moduleName = $this->module->getName();
|
|
|
|
return "{$this->file} in the \"{$moduleName}\" module";
|
|
}
|
|
}
|